From: Bart Van Assche <bvanassche@acm.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
martin.petersen@oracle.com, jejb@linux.ibm.com
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_cang@quicinc.com
Subject: Re: [PATCH 06/13] scsi: ufs: qcom: Export ufshcd_{enable/disable}_irq helpers and make use of them
Date: Fri, 1 Dec 2023 12:27:48 -0800 [thread overview]
Message-ID: <ac563d4a-29dc-4985-bdbf-f6e77ba74a82@acm.org> (raw)
In-Reply-To: <20231201151417.65500-7-manivannan.sadhasivam@linaro.org>
On 12/1/23 07:14, Manivannan Sadhasivam wrote:
> Instead of duplicating the enable/disable IRQ part, let's export the
> helpers available in ufshcd driver and make use of them. This also fixes
> the possible redundant IRQ disable before asserting reset (when IRQ was
> already disabled).
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2023-12-01 20:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 15:14 [PATCH 00/13] scsi: ufs: qcom: Minor code cleanups Manivannan Sadhasivam
2023-12-01 15:14 ` [PATCH 01/13] scsi: ufs: qcom: Use clk_bulk APIs for managing lane clocks Manivannan Sadhasivam
2023-12-06 18:08 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 02/13] scsi: ufs: qcom: Fix the return value of ufs_qcom_ice_program_key() Manivannan Sadhasivam
2023-12-01 17:49 ` Abel Vesa
2023-12-01 15:14 ` [PATCH 03/13] scsi: ufs: qcom: Fix the return value when platform_get_resource_byname() fails Manivannan Sadhasivam
2023-12-06 18:11 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 04/13] scsi: ufs: qcom: Remove superfluous variable assignments Manivannan Sadhasivam
2023-12-06 18:15 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 05/13] scsi: ufs: qcom: Remove the warning message when core_reset is not available Manivannan Sadhasivam
2023-12-06 18:36 ` Andrew Halaney
2023-12-07 5:18 ` Manivannan Sadhasivam
2023-12-07 13:50 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 06/13] scsi: ufs: qcom: Export ufshcd_{enable/disable}_irq helpers and make use of them Manivannan Sadhasivam
2023-12-01 20:27 ` Bart Van Assche [this message]
2023-12-01 15:14 ` [PATCH 07/13] scsi: ufs: qcom: Fail ufs_qcom_power_up_sequence() when core_reset fails Manivannan Sadhasivam
2023-12-06 18:41 ` Andrew Halaney
2023-12-07 5:26 ` Manivannan Sadhasivam
2023-12-01 15:14 ` [PATCH 08/13] scsi: ufs: qcom: Check the return value of ufs_qcom_power_up_sequence() Manivannan Sadhasivam
2023-12-06 18:43 ` Andrew Halaney
2023-12-07 8:27 ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 09/13] scsi: ufs: qcom: Remove redundant error print for devm_kzalloc() failure Manivannan Sadhasivam
2023-12-07 8:36 ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 10/13] scsi: ufs: qcom: Use dev_err_probe() to simplify error handling of devm_gpiod_get_optional() Manivannan Sadhasivam
2023-12-06 18:52 ` Andrew Halaney
2023-12-01 15:14 ` [PATCH 11/13] scsi: ufs: qcom: Remove unused ufs_qcom_hosts struct array Manivannan Sadhasivam
2023-12-06 18:54 ` Andrew Halaney
2023-12-07 5:31 ` Manivannan Sadhasivam
2023-12-07 13:46 ` Andrew Halaney
2023-12-07 8:43 ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 12/13] scsi: ufs: qcom: Sort includes alphabetically Manivannan Sadhasivam
2023-12-05 16:35 ` Nitin Rawat
2023-12-01 15:14 ` [PATCH 13/13] scsi: ufs: qcom: Initialize cycles_in_1us variable in ufs_qcom_set_core_clk_ctrl() Manivannan Sadhasivam
2023-12-05 16:33 ` Nitin Rawat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac563d4a-29dc-4985-bdbf-f6e77ba74a82@acm.org \
--to=bvanassche@acm.org \
--cc=andersson@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox