From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: bjorn.andersson@linaro.org, agross@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
vinod.koul@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs404: fix default pinctrl settings for blsp1_spi1
Date: Sat, 11 Jun 2022 23:03:24 +0300 [thread overview]
Message-ID: <acbf7147-7db0-2b2f-795c-d165b6f59f70@linaro.org> (raw)
In-Reply-To: <20220611195713.131597-1-andrey.konovalov@linaro.org>
On 6/11/22 22:57, Andrey Konovalov wrote:
> The current settings refer to "blsp_spi1" function which isn't defined.
> For this reason an attempt to enable blsp1_spi1 interface results in
> the probe failure below:
>
> [ 3.492900] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table
> [ 3.502460] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table
> [ 3.517725] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table
> [ 3.532998] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table
> [ 3.548277] spi_qup: probe of 78b6000.spi failed with error -22
>
> Fix this by making the functions used in qcs404.dtsi to match the contents
> of drivers/pinctrl/qcom/pinctrl-qcs404.c.
... and Documentation/devicetree/bindings/pinctrl/qcom,qcs404-pinctrl.txt.
>
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index d912166b7552..0d9e1f19aa67 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -669,8 +669,25 @@ blsp1_spi0_default: blsp1-spi0-default {
> };
>
> blsp1_spi1_default: blsp1-spi1-default {
> - pins = "gpio22", "gpio23", "gpio24", "gpio25";
> - function = "blsp_spi1";
> + mosi {
> + pins = "gpio22";
> + function = "blsp_spi_mosi_a1";
> + };
> +
> + miso {
> + pins = "gpio23";
> + function = "blsp_spi_miso_a1";
> + };
> +
> + cs_n {
> + pins = "gpio24";
> + function = "blsp_spi_cs_n_a1";
> + };
> +
> + clk {
> + pins = "gpio25";
> + function = "blsp_spi_clk_a1";
> + };
> };
>
> blsp1_spi2_default: blsp1-spi2-default {
next prev parent reply other threads:[~2022-06-11 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 19:57 [PATCH] arm64: dts: qcom: qcs404: fix default pinctrl settings for blsp1_spi1 Andrey Konovalov
2022-06-11 20:03 ` Andrey Konovalov [this message]
2022-06-22 5:18 ` Vinod Koul
2022-06-30 14:18 ` Bjorn Andersson
2022-07-01 4:40 ` Vinod Koul
2022-07-03 3:55 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acbf7147-7db0-2b2f-795c-d165b6f59f70@linaro.org \
--to=andrey.konovalov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).