From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08DD739DBD4; Tue, 31 Mar 2026 23:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774998004; cv=none; b=up8SOdCogSh7hw4nYD0yjw+hphI6FdIqyqVj1lP+6yGQMn1Z5+7HEGOiIO+rD4NwgjbcOTNzKQCXjtDni7+bangcdBoRXw8YZfMGx+GKv9fINbryrLlztMEH3be5DX+TwXXw3uxL0yDlWcpErPcOb2tyd1nceGGupaXHIV23DEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774998004; c=relaxed/simple; bh=wAZncBDwQwOuR44nK4v4tmMHviN2u3z1Mq/RMS8bO+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KucI3pgHp6dVfh4ZIwUh7eWa7+KjRjCzTRh+OAN5iyuPyWaAjRxENWXThqiDXWSOrZ5VTovFLwCQqas4BAF0C2lS9qSQIBHJ1mPzoGSxbtPzdz39/AhBDLxUgJ2ktCOW9R7FGr1uJj8Ppcm84tICHqb6sL0WofSewuUd3mkjCNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cvmbGkiR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cvmbGkiR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCBE8C19423; Tue, 31 Mar 2026 23:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774998003; bh=wAZncBDwQwOuR44nK4v4tmMHviN2u3z1Mq/RMS8bO+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cvmbGkiRPrw50EWaHalmSjA+aVj6I3tp7fJphPuyN1zvJdBjf+4tkABhCOyo/JIUp rdIQL4n8OHNCtiNA5TTuF1qWOxHoNpfBjpORiX8TKR6+TJ3vizzoeb+GxNzdwwu8fN 03y1U/I919fZqM1+/FCEMQDoydAT8u1E3uualWBxHk37PWSOjkiMcZfaoFG7u3pdyL bKNpPn05HjCCm93trmIsQq6ntZadmzX/L8Lgi+j/Yvvn9/MRUOQdHYfbKmXKzZZrDD i3UCs2iJz0Bdiq+R4ju7kRbCBN8qwCyfBo8dnwao3pYuzcdJbCFmXgYvW/qy7obU5u 9SXzbn10ZHt9g== Date: Tue, 31 Mar 2026 17:59:59 -0500 From: Bjorn Andersson To: Mukesh Ojha Cc: Bjorn Andersson , Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 6/7] slimbus: qcom-ngd-ctrl: Balance pm_runtime enablement for NGD Message-ID: References: <20260309-slim-ngd-dev-v1-0-5843e3ed62a3@oss.qualcomm.com> <20260309-slim-ngd-dev-v1-6-5843e3ed62a3@oss.qualcomm.com> <20260310080025.lbof4hj5zqytc3vy@hu-mojha-hyd.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310080025.lbof4hj5zqytc3vy@hu-mojha-hyd.qualcomm.com> On Tue, Mar 10, 2026 at 01:30:25PM +0530, Mukesh Ojha wrote: > On Mon, Mar 09, 2026 at 11:09:07PM -0500, Bjorn Andersson wrote: > > The pm_runtime_enable() and pm_runtime_use_autosuspend() calls are > > supposed to be balanced on exit, add these calls. > > > > Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") > > Cc: stable@vger.kernel.org > > Signed-off-by: Bjorn Andersson > > --- > > drivers/slimbus/qcom-ngd-ctrl.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c > > index d932f7fd6170773890f561e3af444ac2c5730338..54a4c6ee1e71fe55794f09575979826d9aa5be9f 100644 > > --- a/drivers/slimbus/qcom-ngd-ctrl.c > > +++ b/drivers/slimbus/qcom-ngd-ctrl.c > > @@ -1584,8 +1584,11 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev) > > pm_runtime_enable(dev); > > pm_runtime_get_noresume(dev); > > ret = qcom_slim_ngd_qmi_svc_event_init(ctrl); > > - if (ret) > > + if (ret) { > > dev_err(&pdev->dev, "QMI service registration failed:%d", ret); > > + pm_runtime_dont_use_autosuspend(dev); > > + pm_runtime_disable(dev); > > + } > > Can this entire pm_runtime_* calls moved after > qcom_slim_ngd_qmi_svc_event_init() ? > As soon as qcom_slim_ngd_qmi_svc_event_init() executes we might get a qcom_slim_ngd_qmi_new_server() if the service is already up which would complete(qmi_up), which would unblock qcom_slim_ngd_up_worker() which will invoke qcom_slim_ngd_enable() which currently operates conditionally on pm_runtime_enabled(). So, what you're proposing does make some sense, but I think we should try to clean that up in a subsequent series. Regards, Bjorn > > > > return ret; > > } > > @@ -1699,6 +1702,7 @@ static void qcom_slim_ngd_remove(struct platform_device *pdev) > > { > > struct qcom_slim_ngd_ctrl *ctrl = platform_get_drvdata(pdev); > > > > + pm_runtime_dont_use_autosuspend(&pdev->dev); > > pm_runtime_disable(&pdev->dev); > > qcom_slim_ngd_enable(ctrl, false); > > qcom_slim_ngd_exit_dma(ctrl); > > > > -- > > 2.51.0 > > > > -- > -Mukesh Ojha