From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Vikram Sharma <quic_vikramsa@quicinc.com>,
mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
bryan.odonoghue@linaro.org
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: qcs8300: Add support for camss
Date: Thu, 16 Oct 2025 12:52:07 +0300 [thread overview]
Message-ID: <ad05ed96-80fb-448a-a264-f4b4befc5d30@linaro.org> (raw)
In-Reply-To: <8966ddaf-9c10-4626-a4cc-36efd3fc93e2@kernel.org>
On 10/16/25 08:59, Krzysztof Kozlowski wrote:
> On 15/10/2025 20:49, Vladimir Zapolskiy wrote:
>> On 10/15/25 16:01, Vikram Sharma wrote:
>>> Add changes to support the camera subsystem on the QCS8300.
>>>
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/qcs8300.dtsi | 171 ++++++++++++++++++++++++++
>>> 1 file changed, 171 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300.dtsi b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>>> index 8d78ccac411e..acd475555115 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300.dtsi
>>> @@ -4769,6 +4769,177 @@ videocc: clock-controller@abf0000 {
>>> #power-domain-cells = <1>;
>>> };
>>>
>>> + camss: isp@ac78000 {
>>> + compatible = "qcom,qcs8300-camss";
>>> +
>>> + reg = <0x0 0xac78000 0x0 0x1000>,
>>> + <0x0 0xac7a000 0x0 0xf00>,
>>> + <0x0 0xac7c000 0x0 0xf00>,
>>> + <0x0 0xac84000 0x0 0xf00>,
>>> + <0x0 0xac88000 0x0 0xf00>,
>>> + <0x0 0xac8c000 0x0 0xf00>,
>>> + <0x0 0xac90000 0x0 0xf00>,
>>> + <0x0 0xac94000 0x0 0xf00>,
>>> + <0x0 0xac9c000 0x0 0x2000>,
>>> + <0x0 0xac9e000 0x0 0x2000>,
>>> + <0x0 0xaca0000 0x0 0x2000>,
>>> + <0x0 0xacac000 0x0 0x400>,
>>> + <0x0 0xacad000 0x0 0x400>,
>>> + <0x0 0xacae000 0x0 0x400>,
>>> + <0x0 0xac4d000 0x0 0xf000>,
>>> + <0x0 0xac60000 0x0 0xf000>,
>>> + <0x0 0xac85000 0x0 0xd00>,
>>> + <0x0 0xac89000 0x0 0xd00>,
>>> + <0x0 0xac8d000 0x0 0xd00>,
>>> + <0x0 0xac91000 0x0 0xd00>,
>>> + <0x0 0xac95000 0x0 0xd00>;
>>> + reg-names = "csid_wrapper",
>>> + "csid0",
>>
>> The list of 'reg-names' is not alphanumerically sorted, this is a newly
>> introduced sorting order pattern of CAMSS 'reg' property values.
>
> Please stop inventing ad-hoc or fake rules. There is no such sorting
> pattern for this property, which I expressed multiple times. Last time
> you claimed there is some sorting by "values", now this.
>
The sorting order above does not resemble the order present on other CAMSS
devices, which is the alphanumerical sorting order.
The same order is supposed to be kept.
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2025-10-16 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 13:01 [PATCH v4 0/2] qcom: qcs8300: Add qcs8300 camss support Vikram Sharma
2025-10-15 13:01 ` [PATCH v4 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies Vikram Sharma
2025-10-15 13:30 ` Bryan O'Donoghue
2025-10-15 18:41 ` Vladimir Zapolskiy
2025-10-15 19:12 ` Bryan O'Donoghue
2025-10-15 19:20 ` Vladimir Zapolskiy
2025-10-15 13:01 ` [PATCH v4 2/2] arm64: dts: qcom: qcs8300: Add support for camss Vikram Sharma
2025-10-15 18:49 ` Vladimir Zapolskiy
2025-10-15 19:58 ` Bryan O'Donoghue
2025-10-15 23:21 ` Vladimir Zapolskiy
2025-10-16 5:59 ` Krzysztof Kozlowski
2025-10-16 9:52 ` Vladimir Zapolskiy [this message]
2025-10-16 10:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad05ed96-80fb-448a-a264-f4b4befc5d30@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_svankada@quicinc.com \
--cc=quic_vikramsa@quicinc.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).