Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Akash Kumar <akash.kumar@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB2 controller Micro-USB OTG
Date: Wed, 11 Feb 2026 10:16:29 +0530	[thread overview]
Message-ID: <ad294a50-027f-4caa-a9b4-e145f709b50a@oss.qualcomm.com> (raw)
In-Reply-To: <y32g3rpgfjtr6qyic6goj24uw24tucdsenninqqok3r5ofahj2@7cxcwf4cn6cc>

Hi,

On 2/11/2026 2:45 AM, Dmitry Baryshkov wrote:
> On Tue, Feb 10, 2026 at 08:09:26PM +0530, Akash Kumar wrote:
>> Enable the secondary USB controller (USB2) and its High-Speed PHY to
>> support OTG functionality via a Micro-USB connector.
>>
>> Define a dedicated 'usb2-connector' node using the 'gpio-usb-b-connector'
>> compatible to handle ID and VBUS detection. Link this connector to the
>> DWC3 controller via OF graph ports to satisfy schema requirements and
>> enable role switching.
>>
>> Specific hardware configuration:
>> - ID pin: TLMM 61
>> - VBUS detection: PM7325 GPIO 9
>> - VBUS supply: Fixed regulator controlled by TLMM 63
>> - Configure &usb_2 in OTG mode with role switching enabled.
>> - Define a gpio-usb-b-connector node for Micro-USB support, mapping the
>>   ID pin to TLMM 61 and VBUS detection to PM7325 GPIO 9.
>> - Add the 'vdd_micro_usb_vbus' fixed regulator (controlled by TLMM 63) to
>>   supply VBUS to the connector.
>> - Add the 'usb2_id_detect' pinctrl state to configure GPIO 61 for ID
>>   detection.
>> - Enable &usb_2_hsphy and populate necessary voltage supplies (VDDA PLL,
>>   VDDA 1.8V, VDDA 3.3V).
>>
>> Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 68 ++++++++++++++++++++
>>  1 file changed, 68 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index f29a352b0288..ee472d8b2db1 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -217,6 +217,16 @@ pmic_glink_sbu_in: endpoint {
>>  		};
>>  	};
>>  
>> +	vdd_micro_usb_vbus: regulator-micro-usb-vbus {
>> +	       compatible = "regulator-fixed";
>> +	       regulator-name = "MICRO_USB_VBUS";
>> +	       gpio = <&tlmm 63 GPIO_ACTIVE_HIGH>;
>> +	       regulator-min-microvolt = <5000000>;
>> +	       regulator-max-microvolt = <5000000>;
>> +	       regulator-boot-on;
>> +	       enable-active-high;
>> +	};
>> +
>>  	vph_pwr: regulator-vph-pwr {
>>  		compatible = "regulator-fixed";
>>  		regulator-name = "vph_pwr";
>> @@ -262,6 +272,30 @@ active-config0 {
>>  		};
>>  	};
>>  
>> +	usb2-connector {
>> +		compatible = "gpio-usb-b-connector",
>> +			     "usb-b-connector";
>> +		label = "micro-USB";
>> +		type = "micro";
>> +		id-gpios = <&tlmm 61 GPIO_ACTIVE_HIGH>;
>> +		vbus-gpios = <&pm7325_gpios 9 GPIO_ACTIVE_HIGH>;
>> +		vbus-supply = <&vdd_micro_usb_vbus>;
>> +		pinctrl-0 = <&usb2_id_detect>;
>> +		pinctrl-names = "default";
>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port@0 {
>> +				reg = <0>;
>> +				usb2_connector_ep: endpoint {
>> +					remote-endpoint = <&usb2_controller_ep>;
>> +				};
>> +			};
>> +		};
>> +	};
>> +
>>  	wcn6750-pmu {
>>  		compatible = "qcom,wcn6750-pmu";
>>  		pinctrl-0 = <&bt_en>;
>> @@ -606,6 +640,7 @@ vreg_bob_3p296: bob {
>>  			regulator-max-microvolt = <3960000>;
>>  		};
>>  	};
>> +
> Stray empty line
will remove.
>>  };
>>  
>>  &gcc {
>> @@ -1137,6 +1172,12 @@ qup_uart7_sleep_tx: qup-uart7-sleep-tx-state {
>>  		 */
>>  		bias-pull-up;
>>  	};
>> +
>> +	usb2_id_detect: usb2-id-detect-state {
>> +		pins = "gpio61";
>> +		function = "gpio";
>> +		bias-pull-up;
>> +	};
>>  };
>>  
>>  &uart5 {
>> @@ -1200,6 +1241,33 @@ &usb_1_qmpphy {
>>  	status = "okay";
>>  };
>>  
>> +&usb_2 {
>> +	dr_mode = "otg";
> This is default and can be dropped
Sure.
>> +	usb-role-switch;
> THis should be moved to the kodiak.dtsi.
Kodiak.dtsi already has this property, so will remove from here.
>> +
>> +	status = "okay";
>> +
>> +	ports {
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>> +
>> +		port@0 {
>> +			reg = <0>;
>> +			usb2_controller_ep: endpoint {
>> +				remote-endpoint = <&usb2_connector_ep>;
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> +&usb_2_hsphy {
>> +	vdda-pll-supply = <&vreg_l10c_0p88>;
>> +	vdda18-supply = <&vreg_l1c_1p8>;
>> +	vdda33-supply = <&vreg_l2b_3p072>;
>> +
>> +	status = "okay";
>> +};
>> +
>>  &usb_dp_qmpphy_out {
>>  	remote-endpoint = <&redriver_phy_con_ss>;
>>  };
>> -- 
>> 2.43.0
>>
Thanks for review.

Will send v2 with these minor fixes.

Regards,
Akash.

      reply	other threads:[~2026-02-11  4:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 14:39 [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB2 controller Micro-USB OTG Akash Kumar
2026-02-10 21:15 ` Dmitry Baryshkov
2026-02-11  4:46   ` Akash Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad294a50-027f-4caa-a9b4-e145f709b50a@oss.qualcomm.com \
    --to=akash.kumar@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox