From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm/msm/dpu: drop SSPP's SRC subblock
Date: Fri, 19 May 2023 00:40:03 +0300 [thread overview]
Message-ID: <ae1cd755-ead4-79e0-8d12-074f08e592f1@linaro.org> (raw)
In-Reply-To: <seamj37nkkwn5n2b6jdhpul5kgouwrph22nsyunhibw2tjutxv@euo7k55aatx4>
On 19/05/2023 00:39, Marijn Suijten wrote:
> On 2023-05-19 00:06:15, Dmitry Baryshkov wrote:
>> On 18/05/2023 22:14, Marijn Suijten wrote:
>>> On 2023-04-29 04:23:51, Dmitry Baryshkov wrote:
>>>> The src_blk declares a lame copy of main SSPP register space. It's
>>>> offset is always 0. It's length has been fixed to 0x150, while SSPP's
>>>
>>> It's -> its, twice.
>>
>> Ack
>>
>>>
>>>
>>>
>>>> length is now correct. Drop the src_blk and access SSPP registers
>>>> without additional subblock lookup.
>>>
>>> Note that the block code still calls `dpu_debugfs_create_regset32()` on
>>> "src_blk", do we want to rename that?
>>>
>>
>> I could not come up with a better debugfs file name, so I decided to
>> leave it as is.
>
> Just "blk" or "reg(s)"? This already sits in a dspp/%d subfolder so no
> need to repeat "dspp" at least. But also fine to leave it untouched for
> now.
s/dspp/sspp/ ?
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-05-18 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 1:23 [PATCH v2 0/3] drm/msm/dpu: drop _sspp_subblk_offset() Dmitry Baryshkov
2023-04-29 1:23 ` [PATCH v2 1/3] drm/msm/dpu: drop SSPP's SRC subblock Dmitry Baryshkov
2023-05-18 19:14 ` Marijn Suijten
2023-05-18 21:06 ` Dmitry Baryshkov
2023-05-18 21:39 ` Marijn Suijten
2023-05-18 21:40 ` Dmitry Baryshkov [this message]
2023-05-19 12:05 ` Marijn Suijten
2023-04-29 1:23 ` [PATCH v2 2/3] drm/msm/dpu: access QSEED registers directly Dmitry Baryshkov
2023-05-18 19:18 ` Marijn Suijten
2023-04-29 1:23 ` [PATCH v2 3/3] drm/msm/dpu: access CSC/CSC10 " Dmitry Baryshkov
2023-05-18 19:20 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae1cd755-ead4-79e0-8d12-074f08e592f1@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox