From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DBEBC61DA4 for ; Wed, 25 Jan 2023 11:34:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235269AbjAYLeu (ORCPT ); Wed, 25 Jan 2023 06:34:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235692AbjAYLei (ORCPT ); Wed, 25 Jan 2023 06:34:38 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B80061164E for ; Wed, 25 Jan 2023 03:34:36 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id b7so16748914wrt.3 for ; Wed, 25 Jan 2023 03:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l0whpO4cbXzR1tiN4DzvNKJ/HfGU7YFSCpWie8Zua84=; b=CK2Et2ENldqVneTdeYBGCfDSADiC+JkZV9SYegfHCo46+6tX4hXP6e7gc1hZJRMIam gMQ4eIYhcW9MlUUTmUTBIvJmrjs54uEA5crk72FlVonOxx9atVFPAQtE6td1NFkaWXJu QdT+6NiMTS4gQ9P13schTIVsWV/MN8psRO2rF3GR/JDnoelCN1H9KcEoRD1Uq+qhe3M/ BnjkO00eOzi1MuzWd3UiX70Dcbxly2rdzRA2SjfmrL2LlmnPdWKNF5UprlbmZZg26JcP +bXfoRrOmgsIhioAOqpiOpUmYW5wnMDKJDo/iWQjPhNxvVBYO3eNF+O4bsW0JojDVQ/e q3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l0whpO4cbXzR1tiN4DzvNKJ/HfGU7YFSCpWie8Zua84=; b=ziyOD9QZW/tmfQsH9at172Clxqsil1zk53TtjwvUUX8/369rBRS9AzeC1yrOjkje4X Su98CN2WxMtGeUxDf6p00NnSrBS5Pa8C6Ipge+gpFOWOCvrW6JGcq63DnpzEFbY/MAMS GPGUW8uO1elol7OS4mBPcmooai++U7/GiCp+6UlOOsgN6OnoEhLjPcFZkA4Op3MGVx9v wlD2V4CWxXeszb+hWqBff1DngtU3bVvflbkb5uArBv717mj208/+2cM5GKuXHc3hI5rP U/StZxneMmJ51BXgUM6xRQbIubMuFpZAufthpXAcBOA+CIS9NoeKcUbpANM47qEV3LHP XpSg== X-Gm-Message-State: AO0yUKXmceG8YWWixnQbN+7Cu5ifjO0laGyJJ9pPcz+yS9z0Q/YVLwT1 BBF6+pAZ9/nsX58PibLJuLufPw== X-Google-Smtp-Source: AK7set/8+c33YavXOYtKD1LSh3zE+1ZWgScYR5anmuPGJvgD9aiQ4pFIQMGKXfwcJplkA009zs+OxQ== X-Received: by 2002:adf:ec0f:0:b0:2bf:b661:87d9 with SMTP id x15-20020adfec0f000000b002bfb66187d9mr3089897wrn.50.1674646475202; Wed, 25 Jan 2023 03:34:35 -0800 (PST) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id q14-20020adff78e000000b002be07cbefb2sm5011854wrp.18.2023.01.25.03.34.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 03:34:34 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 11:34:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: camss: Missing cleanup on probe error Content-Language: en-US To: Luca Weiss , Todor Tomov , Robert Foss Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <5898403.lOV4Wx5bFT@g550jk> From: Bryan O'Donoghue In-Reply-To: <5898403.lOV4Wx5bFT@g550jk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 24/01/2023 20:02, Luca Weiss wrote: > Hi all, > > I hit an issue that was already fixed with upstream commit 3d658980e6da > ("media: camss: Do not attach an already attached power domain on MSM8916 > platform") but this showed that some error handling is missing in camss_probe. > > After these errors the resources aren't cleaned up and e.g. sensor drivers > still try to probe but fail quite badly because some things are NULL or > whatever. > > [ 1.979098] qcom-camss fda0ac00.camss: Failed to configure power domains: > -17 > [ 1.989327] qcom-camss: probe of fda0ac00.camss failed with error -17 > > The commit causing this (or at least part of this) is 2f6f8af67203 ("media: > camss: Refactor VFE power domain toggling") > > I tried a bit to add some error handling but in this case it now fails at > v4l2_device_unregister_subdev -> media_device_unregister_entity -> > __media_device_unregister_entity -> ida_free. > And I'm not really sure how to fix (and honestly not super motivated). > > See following patch (formatting probably messed up, sorry). Maybe someone who > knows a bit more about the driver or the media subsystem can fix this, thanks! > > Regards > Luca > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/ > platform/qcom/camss/camss.c > index 16545cecc4f4..0ba3c378d241 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -1836,21 +1836,26 @@ static int camss_probe(struct platform_device *pdev) > } > } > > - ret = camss_configure_pd(camss); > + //ret = camss_configure_pd(camss); > + ret = -17; > if (ret < 0) { > dev_err(dev, "Failed to configure power domains: %d\n", > ret); > - return ret; > + goto err_configure_pd; > } > > pm_runtime_enable(dev); > > return 0; > > +err_configure_pd: > + media_device_unregister(&camss->media_dev); > + media_device_cleanup(&camss->media_dev); > err_register_subdevs: > camss_unregister_entities(camss); > err_register_entities: > v4l2_device_unregister(&camss->v4l2_dev); > err_cleanup: > + v4l2_async_nf_unregister(&camss->notifier); > v4l2_async_nf_cleanup(&camss->notifier); > > return ret; > > > I'll take a look