From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EB63339B47 for ; Thu, 30 Oct 2025 08:54:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761814464; cv=none; b=pZ46ouFbHsxtzYiv/P9ltrchD1Sy7mpGlBEmrbUQlBFwd+CBmh4jV4cqAT4dVEO28Wo2WniGjS1ImQ3wRtGw1EBDBF7C9vxC3+MVaD97flKSXDtrkxmJtqASIgAef/j2P7q1m60OHzqC9KEZmpzl++iZ4hcRScqIaaNblo3QcRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761814464; c=relaxed/simple; bh=4FbxbnCJDc/1oh2iUw/DiNtq0IJ+KihYhiAuxVGgt3k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ojKqpDpvfo+6j+HuYBk4IJzs0POIuuLv6wC9EY+2dpGl4XKSEqb201Ak8C00nlpoFqQQz0HqKz+J3pDQa2qo0phFhm9xjp1/KhhoVXO/aq5Dym3LCET1CUQgJjwrKyhcG9xe4P44R8HuvcQhlCZwLp+vm6AE6E0lAofNtvssteo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jXULy106; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jXULy106" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3401314d845so1122374a91.1 for ; Thu, 30 Oct 2025 01:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761814461; x=1762419261; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z1nbpNKxGZmwf2lpk230ytxyk1UWzh/Nxzqzjf3QY9s=; b=jXULy106eZuAjPjamE5lEQTRgXIck0xUm4Mc+g/UMbzE5iPATnRryx+BR3xiKhvcz4 UJ7UWBB0ecLREAuyIaRmdlruI61fq4pu071W9KK0S7v+RYM5Dv6Kv1FMZoVbuwky8zHl T88sSpHxCGfWaGVP3td9QWlnnz2qz4+eDVxLerFueMeFeOeweZOWEgLNwkP65pThABnX jCXzStZN40lwfq/gE4Y5z8WZBG24Tu+rF15vXoLeMDotA9L8bijyFisbLXIqLq9KUQ/5 lmty/0VDBApvHReBQFShREXxOw65dnSqE3UnKnsNLnXcv/OPFUiyxBJ8S9OcAleZ8SHR b0Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761814461; x=1762419261; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z1nbpNKxGZmwf2lpk230ytxyk1UWzh/Nxzqzjf3QY9s=; b=Pp0UUFGQAOGfMpH5jgFeI/tx1M6KZYSeQmNbagGr79z4KOgDkk8Ub7EmUuefA+4RKs JaGM+OLOplLxRqgaZqJdQgDaupiVAbXub6DQeuRmopJ1UIjb4+mmQ7kP6RufFhZawjWV WaitOKtdOagAgs1/LRPGVxlWHueSTZPdfpD4uFVvkrStGLytnnZ7Kw/W9RjfpYJWm6bV m/xlKvNkdd8vIvTXjTwApMbfHTZNK25aUsthDdFE8S6IhEPCXwFfLmkc1N6YFKocXjwg DdjiiwNTLbhdq+shalxFu6GeuT2SRR/yH4xdSu5i0YXzud08MnPaOD6tf7pEwUILl3Il 4p5g== X-Forwarded-Encrypted: i=1; AJvYcCXX/0XLLe4EETwbtQ1ACOFl2viy4l6Wj8HQFsAvG9VVecD2lQq4zfiMEibNCnEgl0b1GdxQIDayny4enOnC@vger.kernel.org X-Gm-Message-State: AOJu0YyZrqBwpuLCqcqzeq9FUum24ym/0nPfEBLUDUTFZmqqjm5U9tS+ ZUGl5ersNHtnHN1QuBM4Yax/1k9Df75FERCvub1BtZwbAWy82J+l0r18 X-Gm-Gg: ASbGncuImwFuJYIyFw+KTfT/hRLtfh2ght6x6ECFtamFLeeHKc5Iim6wohsN+qUPQ3k vT6h0Uo7Aktcpq0pKZiVGEq+xjip8kvKeqx0nhgusXmwfBlQM7syB+oQBhVraoVhu9jBD4jMwzV Q4TKCKyTBGUr0Z84bh8o1xAvuo1hqfu5xT9a5LcfLxVvIlKeiN+jQXtAbrv5JV+EVs0dweKko5i WzJQZgcTxc3f4qP1EoKGyn3oWZDki+g+wVWXC5sJrt0xomRAr/K0Av0GjL6YETqximo69+PDArs sH3/tY+LmS75uDn4gCsXMOkpseZFH6uTdNjIfUnm56UeGl6A/uIgm7uTpbQFU5cGJmbTORu1Ifa babIrFIhVvbcPLNXnyI2a74ACoSakapD5M63jHrD9EjJc8/vkPGA3ZzR1eFUlNYejfl6imGeBpB 9y5GDlh+uzG1eQ X-Google-Smtp-Source: AGHT+IGFeqYgROmr+sPNZXEEZkn6mYlrCgf3ZvBH+yTloU98WBNL4oCUsdI3RF82oEmk9ZTtm2e7CQ== X-Received: by 2002:a17:90b:580d:b0:340:29be:8afe with SMTP id 98e67ed59e1d1-3404c56f639mr2713860a91.33.1761814461463; Thu, 30 Oct 2025 01:54:21 -0700 (PDT) Received: from [172.17.49.162] ([103.218.174.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b712f880ef2sm15926777a12.38.2025.10.30.01.54.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Oct 2025 01:54:21 -0700 (PDT) Message-ID: Date: Thu, 30 Oct 2025 14:24:15 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] arm64: dts: qcom: talos-evk: Add support for dual-channel LVDS panel To: Dmitry Baryshkov Cc: Konrad Dybcio , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251028061636.724667-1-tessolveupstream@gmail.com> <20251028061636.724667-2-tessolveupstream@gmail.com> <9208d2ef-79da-4e80-ac1f-e01fa5feae0a@gmail.com> Content-Language: en-US From: Tessolve Upstream In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 29/10/25 18:04, Dmitry Baryshkov wrote: > On Wed, Oct 29, 2025 at 05:50:01PM +0530, Tessolve Upstream wrote: >> >> >> On 28/10/25 14:55, Konrad Dybcio wrote: >>> On 10/28/25 7:16 AM, Sudarshan Shetty wrote: >>>> This patch introduces a new device tree for the QCS615 Talos >>>> EVK platform with dual-channel LVDS display support. >>>> >>>> The new DTS file (`talos-evk-lvds.dts`) is based on the existing >>>> `talos-evk.dts` and extends it to enable a dual-channel LVDS display >>>> configuration using the TI SN65DSI84 DSI-to-LVDS bridge. >>>> >>>> where channel-A carries odd pixel and channel-B carries even pixel >>>> on the QCS615 talos evk platform. >>>> >>>> Signed-off-by: Sudarshan Shetty >>>> --- >>> >>> [...] >>> >>>> + backlight: backlight { >>>> + compatible = "gpio-backlight"; >>>> + gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>; >>>> + default-on; >>>> + }; >>>> + >>>> + lcd0_pwm_en { >>> >>> Use hyphens instead of underscores in node names >> >> Okay, will update in next patch. >>> >>>> + compatible = "pwm-gpio"; >>>> + gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>; >>>> + pinctrl-0 = <&lcd0_bklt_pwm>; >>> >>> I think your intention was to use pwm-backlight and wire this node >>> up to that >> >> Soc does not support the PWM interface hence we are using gpio >> as "pwm-gpio" by setting the duty cycle to 100%(i.e. "no pwm") > > Why do you mention PWM here at all? It's perfectly fine to use > gpio-backlight. That looks extremely suspicious since you are not > referecing the pwm-gpio device at all. Thanks for the feedback. GPIO59 (LED_PWM) connected to the panel’s dimming input. Since we can only drive the LED_PWM pin high (100% duty), it does not provide true PWM control. I’ll remove the non-standard "pwm-gpio" node and model both lines using the standard gpio-backlight binding, like this: backlight: backlight { compatible = "gpio-backlight"; gpios = <&tlmm 115 GPIO_ACTIVE_HIGH>, <&tlmm 59 GPIO_ACTIVE_HIGH>; default-on; pinctrl-0 = <&lcd0_bklt_en>, <&lcd0_bklt_pwm>; pinctrl-names = "default"; }; &tlmm { lcd0_bklt_en: lcd0-bklt-en-state { pins = "gpio115"; function = "gpio"; bias-disable; }; lcd0_bklt_pwm: lcd0-bklt-pwm-state { pins = "gpio59"; function = "gpio"; bias-disable; }; }; Let me know your opinion here, Thanks in advance. >