Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Val Packett <val@packett.cool>,
	Srinivas Kandagatla <srini@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: Bhushan Shah <bhushan.shah@machinesoul.in>,
	Luca Weiss <luca.weiss@fairphone.com>,
	Antoine Bernard <zalnir@proton.me>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] ASoC: qcom: qdsp6: q6routing: add Senary MI2S ports
Date: Thu, 7 May 2026 08:31:10 +0000	[thread overview]
Message-ID: <af0d5cd5-4d4d-4cf1-a347-4f40c595d07d@oss.qualcomm.com> (raw)
In-Reply-To: <20260506204142.659778-3-val@packett.cool>

On 5/6/26 8:33 PM, Val Packett wrote:
> This commit adds support for senary MI2S mixers.
> 
> Signed-off-by: Val Packett <val@packett.cool>
> ---

lgtm,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

>  sound/soc/qcom/qdsp6/q6routing.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c
> index 7386226046fa..55119cc33d95 100644
> --- a/sound/soc/qcom/qdsp6/q6routing.c
> +++ b/sound/soc/qcom/qdsp6/q6routing.c
> @@ -68,6 +68,7 @@
>  	{ mix_name, "SEC_MI2S_TX", "SEC_MI2S_TX" },	\
>  	{ mix_name, "QUAT_MI2S_TX", "QUAT_MI2S_TX" },	\
>  	{ mix_name, "QUIN_MI2S_TX", "QUIN_MI2S_TX" },	\
> +	{ mix_name, "SEN_MI2S_TX", "SEN_MI2S_TX" },	\
>  	{ mix_name, "TERT_MI2S_TX", "TERT_MI2S_TX" },		\
>  	{ mix_name, "SLIMBUS_0_TX", "SLIMBUS_0_TX" },		\
>  	{ mix_name, "SLIMBUS_1_TX", "SLIMBUS_1_TX" },		\
> @@ -145,6 +146,9 @@
>  	SOC_SINGLE_EXT("QUIN_MI2S_TX", QUINARY_MI2S_TX,			\
>  		id, 1, 0, msm_routing_get_audio_mixer,			\
>  		msm_routing_put_audio_mixer),				\
> +	SOC_SINGLE_EXT("SEN_MI2S_TX", SENARY_MI2S_TX,			\
> +		id, 1, 0, msm_routing_get_audio_mixer,			\
> +		msm_routing_put_audio_mixer),				\
>  	SOC_SINGLE_EXT("SLIMBUS_0_TX", SLIMBUS_0_TX,			\
>  		id, 1, 0, msm_routing_get_audio_mixer,			\
>  		msm_routing_put_audio_mixer),				\
> @@ -535,6 +539,9 @@ static const struct snd_kcontrol_new quaternary_mi2s_rx_mixer_controls[] = {
>  static const struct snd_kcontrol_new quinary_mi2s_rx_mixer_controls[] = {
>  	Q6ROUTING_RX_MIXERS(QUINARY_MI2S_RX) };
>  
> +static const struct snd_kcontrol_new senary_mi2s_rx_mixer_controls[] = {
> +	Q6ROUTING_RX_MIXERS(SENARY_MI2S_RX) };
> +
>  static const struct snd_kcontrol_new tertiary_mi2s_rx_mixer_controls[] = {
>  	Q6ROUTING_RX_MIXERS(TERTIARY_MI2S_RX) };
>  
> @@ -777,6 +784,9 @@ static const struct snd_soc_dapm_widget msm_qdsp6_widgets[] = {
>  	SND_SOC_DAPM_MIXER("QUIN_MI2S_RX Audio Mixer", SND_SOC_NOPM, 0, 0,
>  			   quinary_mi2s_rx_mixer_controls,
>  			   ARRAY_SIZE(quinary_mi2s_rx_mixer_controls)),
> +	SND_SOC_DAPM_MIXER("SEN_MI2S_RX Audio Mixer", SND_SOC_NOPM, 0, 0,
> +			   senary_mi2s_rx_mixer_controls,
> +			   ARRAY_SIZE(senary_mi2s_rx_mixer_controls)),
>  	SND_SOC_DAPM_MIXER("TERT_MI2S_RX Audio Mixer", SND_SOC_NOPM, 0, 0,
>  			   tertiary_mi2s_rx_mixer_controls,
>  			   ARRAY_SIZE(tertiary_mi2s_rx_mixer_controls)),
> @@ -969,6 +979,7 @@ static const struct snd_soc_dapm_route intercon[] = {
>  	Q6ROUTING_RX_DAPM_ROUTE("SLIMBUS_6_RX Audio Mixer", "SLIMBUS_6_RX"),
>  	Q6ROUTING_RX_DAPM_ROUTE("QUAT_MI2S_RX Audio Mixer", "QUAT_MI2S_RX"),
>  	Q6ROUTING_RX_DAPM_ROUTE("QUIN_MI2S_RX Audio Mixer", "QUIN_MI2S_RX"),
> +	Q6ROUTING_RX_DAPM_ROUTE("SEN_MI2S_RX Audio Mixer", "SEN_MI2S_RX"),
>  	Q6ROUTING_RX_DAPM_ROUTE("TERT_MI2S_RX Audio Mixer", "TERT_MI2S_RX"),
>  	Q6ROUTING_RX_DAPM_ROUTE("SEC_MI2S_RX Audio Mixer", "SEC_MI2S_RX"),
>  	Q6ROUTING_RX_DAPM_ROUTE("PRI_MI2S_RX Audio Mixer", "PRI_MI2S_RX"),


  reply	other threads:[~2026-05-07  8:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 20:33 [PATCH v2 0/6] ASoC: qcom: fixes and improvements Val Packett
2026-05-06 20:33 ` [PATCH v2 1/6] ASoC: qcom: qdsp6: q6afe: fix clk vote response type mismatch Val Packett
2026-05-07  0:02   ` Mark Brown
2026-05-07  1:46     ` Val Packett
2026-05-07  2:16       ` Mark Brown
2026-05-07  8:03         ` Konrad Dybcio
2026-05-07  8:23           ` Mark Brown
2026-05-06 20:33 ` [PATCH v2 2/6] ASoC: qcom: qdsp6: q6routing: add Senary MI2S ports Val Packett
2026-05-07  8:31   ` Srinivas Kandagatla [this message]
2026-05-06 20:33 ` [PATCH v2 3/6] ASoC: qcom: sm8250: add Senary MI2S RX support Val Packett
2026-05-07  8:34   ` Srinivas Kandagatla
2026-05-06 20:33 ` [PATCH v2 4/6] ASoC: qcom: sm8250: add TDM " Val Packett
2026-05-07  8:51   ` Srinivas Kandagatla
2026-05-07 20:24     ` Val Packett
2026-05-06 20:33 ` [PATCH v2 5/6] ASoC: qcom: sm8250: shut down MI2S/TDM AFE port clocks Val Packett
2026-05-07  8:57   ` Srinivas Kandagatla
2026-05-07 20:44     ` Val Packett
2026-05-06 20:33 ` [PATCH v2 6/6] ASoC: qcom: sm8250: apply codec_fmt to all codec DAIs Val Packett
2026-05-07  9:02   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af0d5cd5-4d4d-4cf1-a347-4f40c595d07d@oss.qualcomm.com \
    --to=srinivas.kandagatla@oss.qualcomm.com \
    --cc=bhushan.shah@machinesoul.in \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=perex@perex.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    --cc=val@packett.cool \
    --cc=zalnir@proton.me \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox