From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yQAZLgx0" Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FEF3AC for ; Wed, 13 Dec 2023 08:46:14 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3332fc9b9b2so6235125f8f.1 for ; Wed, 13 Dec 2023 08:46:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702485973; x=1703090773; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gl8eoLUzBb22dSI7qdnrUzIaG/dfbsYNZdAqMzHLZ4E=; b=yQAZLgx0pkjZq7nxJcuxXWkuYbqm3hpsd0n2bVSTdZCIKj4pV5NOOZsFiNDTgI5pTg iXUvyrBojqCe8Ts5lM8G0srwqYpsMmOZJs/OTgRKyUVsyaHUkNxzpoF+E3lbGtf2FnAg Il47sfTlcBZR+eqC3KX7htrOIUBL0pe241Nf2X7sU6afNONV1pMefoZ2d591N+oVkNxz pfG4Sbwp7GIOdoQDQ4bd/UmDXhN3I+SBAmh6AwOVaXHb3DtJcO6u3lvzXQ1nM8ENbekb XonoHp9Mvswb10L8ghDxDb73mYCHynASPLOK0RKspDcLOJLp2HBeXUuhA4dnZbLSzTpU t51w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485973; x=1703090773; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gl8eoLUzBb22dSI7qdnrUzIaG/dfbsYNZdAqMzHLZ4E=; b=nSkvDR60wuvbG8mXzz1yrbdsQvXxpwQpySDSINysnw6Le7svgyWzbXaOm3w8AaKzw5 9Nyt3B0JkwY7hau/HNEc9HDhVL9xLyTGaEB/ZLoY/WF6tc/q4/xT4V3+3UjrI+5ybC6D R92unMpup9B2VK0xCsPnRGHwdBTw6nd1QcnXxx5d+zqmMoJJoapAB98UxlMV+o5Q0Miz HOJYwmohZaf2/0C2GPgvORzXBzhRjj3UxM1NggcVaheuNwHZx+F0oZlQmz35OWdiEPr+ +9j0O/o4jV7b5dv8F24TiMqpzkFDDlL138Liq9fke4aD4WSpG1eZkW833k0YfhDkXXXq e5aA== X-Gm-Message-State: AOJu0YxJaogggHYcKTeY4k7Giphok7cuZL8t9S+g/OZ2EchCsp5luoXt IP0t62CmYuouU387oDADSOgCDw== X-Google-Smtp-Source: AGHT+IGntbw26qTvU7nU58AgDpvBGkGyiiv8pmNjWoGN6o68fk+7KZkLwAFhZEuqZDdWhq0H3KhoPQ== X-Received: by 2002:a05:6000:1a4e:b0:336:3743:5a5d with SMTP id t14-20020a0560001a4e00b0033637435a5dmr484831wry.48.1702485972967; Wed, 13 Dec 2023 08:46:12 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:ac4e:a5fe:7f71:8d59? ([2a01:e0a:982:cbb0:ac4e:a5fe:7f71:8d59]) by smtp.gmail.com with ESMTPSA id o4-20020a5d58c4000000b0033333bee379sm13767115wrf.107.2023.12.13.08.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 08:46:12 -0800 (PST) Message-ID: Date: Wed, 13 Dec 2023 17:46:11 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sm8550: drop unneeded assigned-clocks from codec macros Content-Language: en-GB To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231213162856.188566-1-krzysztof.kozlowski@linaro.org> <20231213162856.188566-5-krzysztof.kozlowski@linaro.org> From: Neil Armstrong In-Reply-To: <20231213162856.188566-5-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 13/12/2023 à 17:28, Krzysztof Kozlowski a écrit : > The MCLK clocks of codec macros have fixed 19.2 MHz frequency and > assigning clock rates is redundant. > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index d8f79b5895f5..68b05ab5f65f 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -2045,8 +2045,6 @@ lpass_wsa2macro: codec@6aa0000 { > <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > <&lpass_vamacro>; > clock-names = "mclk", "macro", "dcodec", "fsgen"; > - assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA2_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > - assigned-clock-rates = <19200000>; > > #clock-cells = <0>; > clock-output-names = "wsa2-mclk"; > @@ -2092,9 +2090,6 @@ lpass_rxmacro: codec@6ac0000 { > <&lpass_vamacro>; > clock-names = "mclk", "macro", "dcodec", "fsgen"; > > - assigned-clocks = <&q6prmcc LPASS_CLK_ID_RX_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > - assigned-clock-rates = <19200000>; > - > #clock-cells = <0>; > clock-output-names = "mclk"; > #sound-dai-cells = <1>; > @@ -2138,9 +2133,6 @@ lpass_txmacro: codec@6ae0000 { > <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > <&lpass_vamacro>; > clock-names = "mclk", "macro", "dcodec", "fsgen"; > - assigned-clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > - > - assigned-clock-rates = <19200000>; > > #clock-cells = <0>; > clock-output-names = "mclk"; > @@ -2156,9 +2148,6 @@ lpass_wsamacro: codec@6b00000 { > <&lpass_vamacro>; > clock-names = "mclk", "macro", "dcodec", "fsgen"; > > - assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > - assigned-clock-rates = <19200000>; > - > #clock-cells = <0>; > clock-output-names = "mclk"; > #sound-dai-cells = <1>; > @@ -2233,9 +2222,6 @@ lpass_vamacro: codec@6d44000 { > <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > clock-names = "mclk", "macro", "dcodec"; > > - assigned-clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > - assigned-clock-rates = <19200000>; > - > #clock-cells = <0>; > clock-output-names = "fsgen"; > #sound-dai-cells = <1>; Reviewed-by: Neil Armstrong