From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 594D6C54EBC for ; Thu, 12 Jan 2023 13:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229815AbjALNvM (ORCPT ); Thu, 12 Jan 2023 08:51:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbjALNvK (ORCPT ); Thu, 12 Jan 2023 08:51:10 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15D9848CE8 for ; Thu, 12 Jan 2023 05:51:03 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id ay40so13244125wmb.2 for ; Thu, 12 Jan 2023 05:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XfUbQ/ydCRRW+3mE1Orr5gwPDzcHINGiVYjYnLQJabM=; b=Nheg9M8T3r76JC0MyQyGTSuHDE/jZFJyg0jHOMls4lAc1wG28mV4rQdtQ08LaHhg0m mNKm6vItSKgNIvdKLIDbR+/cykBn0onE8cpKGk73XVuY4irZPeuki42YBvOo2sDpTbxf mRpDRxqshyHB2aU+ZJBpITlsaOuLhuI+wcQfJkH8d1h/utvof8xIjXk/9C0giqTqp82F PC9dRQ0KFFy8H+CjEavPv4kQes3Vp5YHEYqtDsK8NPRpqeKzOihdgoaIWyJbfZ/zdZF4 zgfAaSYrOW0JphqxdiN01ZK1fhD7sD9YKPRcW8kHfy+WFMgWnnRA8FU4pheCF62fFHw0 F1TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XfUbQ/ydCRRW+3mE1Orr5gwPDzcHINGiVYjYnLQJabM=; b=4GLNWAtgaZqnm0oS1gIBX03drZH8lolBhiSGmN181JgA7B1W0J1I6D7jWjvvosgome mkrJ9uAdN2eOtU0hWq0Fj/gmMn6UK8wnAWNR0W4ROuVh9hcAnGZO+wPBykmgs3lDv4F+ 8gw+m+FRZZpown07vyE1/be/TMSdvJOa1oth2W79QxlPZ57pK3DRedOtHn5mQgKiQcvz eLo1qeqhyfa+KkIGneaFrk1IGsRCt8sTQfVqzhu8nAGStJg/QCRThUCr9Gp22rmNJ5ag YUWfNT19+d4khWfjVhea9GqhiXQDNrndSj76GkGCQR/YB3ILmsJZI1ykMs4Wzj7OFDNJ OXkA== X-Gm-Message-State: AFqh2kqvTVkU1AwmnUEi06HeZrrKE7+9FzCO1Y/CLa9kDJ9IwXv+mYi/ emvuo4o50hy+7ejCTMWQlpbgCgohvq6XNEvw X-Google-Smtp-Source: AMrXdXvi5cu18zppjCtIm75u+gZcYTBzEXlUpuEp7dkaofSYD0wytooU0aAmOLOsMFAi0IEKaHnx4w== X-Received: by 2002:a05:600c:4f94:b0:3d9:f85c:97ff with SMTP id n20-20020a05600c4f9400b003d9f85c97ffmr8009219wmq.16.1673531461622; Thu, 12 Jan 2023 05:51:01 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:3b9e:7554:4633:9a59? ([2a01:e0a:982:cbb0:3b9e:7554:4633:9a59]) by smtp.gmail.com with ESMTPSA id m18-20020a05600c4f5200b003c6b70a4d69sm24902780wmq.42.2023.01.12.05.51.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jan 2023 05:51:01 -0800 (PST) Message-ID: Date: Thu, 12 Jan 2023 14:51:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 13/13] drm/bridge: lt9611: properly program the dual host mode To: Dmitry Baryshkov , Vinod Koul , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org References: <20230108165656.136871-1-dmitry.baryshkov@linaro.org> <20230108165656.136871-14-dmitry.baryshkov@linaro.org> Content-Language: en-US Organization: Linaro Developer Services In-Reply-To: <20230108165656.136871-14-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 08/01/2023 17:56, Dmitry Baryshkov wrote: > If the bridge is connected using both DSI ports, the driver should use > both of them all the time. Correct programming sequence to always use > dual-port mode if both dsi0 and dsi1 are connected. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/bridge/lontium-lt9611.c | 28 ++++++++++++------------- > 1 file changed, 13 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c > index df9f015aa3a0..561da6bd2698 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c > @@ -118,7 +118,7 @@ static int lt9611_mipi_input_digital(struct lt9611 *lt9611, > { 0x8306, 0x0a }, > }; > > - if (mode->hdisplay == 3840) > + if (lt9611->dsi1_node) > reg_cfg[1].def = 0x03; > > return regmap_multi_reg_write(lt9611->regmap, reg_cfg, ARRAY_SIZE(reg_cfg)); > @@ -191,16 +191,6 @@ static void lt9611_pcr_setup(struct lt9611 *lt9611, const struct drm_display_mod > { 0x832d, 0x38 }, > { 0x8331, 0x08 }, > }; > - const struct reg_sequence reg_cfg2[] = { > - { 0x830b, 0x03 }, > - { 0x830c, 0xd0 }, > - { 0x8348, 0x03 }, > - { 0x8349, 0xe0 }, > - { 0x8324, 0x72 }, > - { 0x8325, 0x00 }, > - { 0x832a, 0x01 }, > - { 0x834a, 0x10 }, > - }; > u8 pol = 0x10; > > if (mode->flags & DRM_MODE_FLAG_NHSYNC) > @@ -209,10 +199,18 @@ static void lt9611_pcr_setup(struct lt9611 *lt9611, const struct drm_display_mod > pol |= 0x1; > regmap_write(lt9611->regmap, 0x831d, pol); > > - if (mode->hdisplay == 3840) > - regmap_multi_reg_write(lt9611->regmap, reg_cfg2, ARRAY_SIZE(reg_cfg2)); > - else > - regmap_multi_reg_write(lt9611->regmap, reg_cfg, ARRAY_SIZE(reg_cfg)); > + regmap_multi_reg_write(lt9611->regmap, reg_cfg, ARRAY_SIZE(reg_cfg)); > + if (lt9611->dsi1_node) { > + unsigned int hact = mode->hdisplay; > + > + hact >>= 2; > + hact += 0x50; > + hact = min(hact, 0x3e0U); > + regmap_write(lt9611->regmap, 0x830b, hact / 256); > + regmap_write(lt9611->regmap, 0x830c, hact % 256); > + regmap_write(lt9611->regmap, 0x8348, hact / 256); > + regmap_write(lt9611->regmap, 0x8349, hact % 256); > + } > > regmap_write(lt9611->regmap, 0x8326, pcr_m); > Reviewed-by: Neil Armstrong