Re: [RFC 12/12] arm64: dts: qcom: x1e78100-thinkpad-t14s: Move keyb and touchpad to ACPI enumeration

[Bjorn Andersson <andersson@kernel.org>]

On Tue, Jun 23, 2026 at 04:52:25PM +0200, Hans de Goede wrote:
> Add acpi-path properties for DT-ACPI hybrid mode and remove the keyboard
> and touchpad description switching to relying on ACPI to enumerate these.
> 
> Also drop the clock-frequency this is also provided by ACPI now.
> 
> FIXME: Needs DT-bindings patch as pre-req
> 
> Note this depends on these 2 patch-series for working PDC support on Hamoa:
> https://lore.kernel.org/linux-arm-msm/20260410184124.1068210-1-mukesh.ojha@oss.qualcomm.com/
> https://lore.kernel.org/linux-arm-msm/20260616-hamoa_pdc_v3-v3-0-4d8e1504ea75@oss.qualcomm.com/
> 
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
> ---
>  .../qcom/x1e78100-lenovo-thinkpad-t14s.dtsi   | 59 +------------------
>  1 file changed, 3 insertions(+), 56 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> index 2fc01e8e8c04..a73576ec238d 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> @@ -1017,57 +1017,8 @@ &gpu_zap_shader {
>  };
>  
>  &i2c0 {
> -	clock-frequency = <400000>;
> -
> -	pinctrl-0 = <&qup_i2c0_data_clk>, <&tpad_default>;
> -	pinctrl-names = "default";
> -
> +	acpi-path = "\\_SB.I2C1";

The +/- are not equivalent, you're removing both pinctrl state and
device power management - relying on the default state (or other
client's votes).

In addition \\_SB.I2C1 is not a stable ABI.

Regards,
Bjorn

>  	status = "okay";
> -
> -	/* ELAN06E2 or ELAN06E3 */
> -	touchpad@15 {
> -		compatible = "hid-over-i2c";
> -		reg = <0x15>;
> -
> -		hid-descr-addr = <0x1>;
> -		interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
> -
> -		vdd-supply = <&vreg_misc_3p3>;
> -		vddl-supply = <&vreg_l12b_1p2>;
> -
> -		wakeup-source;
> -	};
> -
> -	/* SYNA8022 or SYNA8024 */
> -	touchpad@2c {
> -		compatible = "hid-over-i2c";
> -		reg = <0x2c>;
> -
> -		hid-descr-addr = <0x20>;
> -		interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
> -
> -		vdd-supply = <&vreg_misc_3p3>;
> -		vddl-supply = <&vreg_l12b_1p2>;
> -
> -		wakeup-source;
> -	};
> -
> -	/* ELAN06F1 or SYNA06F2 */
> -	keyboard@3a {
> -		compatible = "hid-over-i2c";
> -		reg = <0x3a>;
> -
> -		hid-descr-addr = <0x1>;
> -		interrupts-extended = <&tlmm 67 IRQ_TYPE_LEVEL_LOW>;
> -
> -		vdd-supply = <&vreg_misc_3p3>;
> -		vddl-supply = <&vreg_l15b_1p8>;
> -
> -		pinctrl-0 = <&kybd_default>;
> -		pinctrl-names = "default";
> -
> -		wakeup-source;
> -	};
>  };
>  
>  &i2c3 {
> @@ -1598,6 +1549,8 @@ wcd_tx: codec@0,3 {
>  };
>  
>  &tlmm {
> +	acpi-path = "\\_SB.GIO0";
> +
>  	gpio-reserved-ranges = <34 2>, /* Unused */
>  			       <44 4>, /* SPI (TPM) */
>  			       <72 2>, /* Secure EC I2C connection (?) */
> @@ -1655,12 +1608,6 @@ hdmi_hpd_default: hdmi-hpd-default-state {
>  		bias-disable;
>  	};
>  
> -	tpad_default: tpad-default-state {
> -		pins = "gpio3";
> -		function = "gpio";
> -		bias-pull-up;
> -	};
> -
>  	nvme_reg_en: nvme-reg-en-state {
>  		pins = "gpio18";
>  		function = "gpio";
> -- 
> 2.54.0
>