From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46D0E434418 for ; Thu, 9 Jul 2026 16:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783613329; cv=none; b=W7N+0mQxdUrkpT3UGJxS6xVpFPGzXKUxeDhrvs28pNFpZS+wn3A7Uu/bUHbTKXUkWdZNshr7nI+IfyVuI5PRdlDTRnMXRglYSMiZdytZZIjzqlIbPToyjZEwe2CUXsN3z68d5Dem51Jb8C2BV/MgAu3HRDljfSKQe4QMVdLDyGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783613329; c=relaxed/simple; bh=LdoEID+mftfieJuREjeHFGnl1pSH4i3KPMTl65rvBKc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UQo0k3Lp6uhvwJ9zQ9ZzSDsxFI31epXfYq4Cm6k7clDka3BCm97hsL1fpRWOhl5xvQf1i7hAMeFoC4vz2bZ2lQqwYTagJ2cMQxR88oJTnHd1y1zkhQg7wxZb7a1dSgIv1acOFn63Odty74pwkIpa90lpVm3Ns6HdRtXUfLDALqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=MIXNNbtc; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="MIXNNbtc" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47de008b020so4824f8f.1 for ; Thu, 09 Jul 2026 09:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783613326; x=1784218126; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Gov176wXURlzSR3dUDxqqJ+JUc69jBkAANSG0MToDuM=; b=MIXNNbtco0ot4EbgBCazIAcAgkmMGSlgBUkph/ZIj83xY7G7d+g0+5PdEK3X27kvuQ BCgcoilnMXnSkeyGhqzYX5wvmvQrWEqZLQO1azhpcTnqjQeke5xfEFEVISjPACdwyrnr RAKm0m8cPG95tV5BiD4eonZi5sCnbQR/1T2Rg0sVCfIJefpTAajuym6efVhpXRz2B5pe 6L5Y37FwLzwZo/Jo2pQLiLPEgRDJYwHhcQbUxzsRLf0gwH0tfrrWgmjB0133vUYurZtW Sm4/ByBq6+56bVB0VucJb8u5SS/3UZ2YcOT9E6Jy3Y1H4XcPrkqCMRWvG0q/k/8Nm90J dbYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783613326; x=1784218126; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gov176wXURlzSR3dUDxqqJ+JUc69jBkAANSG0MToDuM=; b=b7dcTSAQMzwmE0AjsaDP2Bb4pUjgA986mx6O2OFLlXSA60bCo3Ewsrd3/fjPXD5QZU K77hRuTCSUiFh+9fFrQNDPbpA3WrCGqyfT5F3/oLAFciSAMD9JGbH9AWffxn9s4BABPV 2yziDqf2Naqh7fEKVbA1I3aKsGca0c08fjA4rRAR0nnR2HJhIUDhcnX4IgyWdxMjA+Ny QQp6rgx6/GTfAuc2MKJlOBwKFMWCVKvWEnix89tIy45QbO6POjIdUXkk9hnHkxAxXe8t 2mBzgcfxBh0kPqcjuZ4MguiiTiAig5I1/+2l8g6JNxM6Vlm8iZoOIJQGv/upk7HMRRGu 2PhQ== X-Forwarded-Encrypted: i=1; AHgh+Rr5mZkcMHMOdIxkae64N9O9dBXbb1OdfxfmVWiE+iguadML6G/FqV1c0hZviUWjn8Ihp5uvf7lkQA/9SiYu@vger.kernel.org X-Gm-Message-State: AOJu0YzFsX5DIYSCOLTBCNLDX68u+CawRba+NxfMbG77K4BNqgdOD8QI izkePv7TS4p5T3Er+vpUaxVJTVwQ+Tvas1VkVborMvQKwmFoKSDL0xFIQ+Ss8Iig8II= X-Gm-Gg: AfdE7cnsXAcftfxAW5LqpgiRIL6K5X+1f0NoH3h2fFix0xs8oK0YYsddMo+0Gi0ENzS rPGo7puMm6TDo2nHjEgaBYKvA7yU4dyzLmWba/7K4coEPBogjWgy/uey20F4GT5modUFgQLLemk wL3B9O9q1oT90y0wcsmc3JzxvsqUGZmIWboTiOEQRwC367scA9qK3iBPe1FlNpLRte/37GEW4pN Yo/4rCvnw2kbBRCrykX4VfDMEbqq9vjfqNmaao1q4Jo5WsYSljVzU3TgQyFtWgxA4Ib7Z8z8ulM PI7L60FEW5qm+LOIirgZ+5sXhgsEnCiAsjOmulUygjTv8IbFUZ12ykHdT5OUEoS1PVjifsY9JhQ RY4IXbDF9EgIIblau9MI6b5bbVU+mAcDKQ3JVGxGOFDq5krsMzM//lShZqPKH8HMORt25K6fIEr dvqPNnEvdg1jun2+95d+Akq2fAABxmPsSmNZeywYBy92a0RWSdfm5l1FiyKIHGqojn09NVgLrrh 8aM X-Received: by 2002:a05:6000:230b:b0:46d:f979:1827 with SMTP id ffacd0b85a97d-47df757026bmr3824909f8f.23.1783613325532; Thu, 09 Jul 2026 09:08:45 -0700 (PDT) Received: from localhost (p200300f65f47db043de98c19b374aa68.dip0.t-ipconnect.de. [2003:f6:5f47:db04:3de9:8c19:b374:aa68]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47aa0960816sm50486350f8f.29.2026.07.09.09.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 09:08:43 -0700 (PDT) Date: Thu, 9 Jul 2026 18:08:42 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Andy Shevchenko Cc: Lee Jones , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , mfd@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, Qunqin Zhao , linux-crypto@vger.kernel.org, Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, Colin Foster , David Rhodes , Richard Fitzgerald , Mika Westerberg , Zha Qipeng , Thomas Richard , linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Xu Yilun , Tom Rix , Michael Hennerich , Chen-Yu Tsai , Marek Vasut , James Ogletree , Fred Treven , Ben Bright , Support Opensource , Andy Shevchenko , Charles Keepax , Chanwoo Choi , Krzysztof Kozlowski , =?utf-8?B?QW5kcsOp?= Draszik , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Samuel Kayode , Maxime Coquelin , Alexandre Torgue , linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Linus Walleij , linux@ew.tq-group.com, Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Peter Griffin , Alim Akhtar , Tim Harvey , Neil Armstrong , Sven Peter , Janne Grunau , Neal Gompa , Mathieu Dubois-Briand , Luca Ceresoli , Saravanan Sekar , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Matti Vaittinen , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Jernej Skrabec , Samuel Holland , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Geert Uytterhoeven , Magnus Damm , linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Peter Tyser Subject: Re: [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Message-ID: References: Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ka4fpqo6ejmxfupn" Content-Disposition: inline In-Reply-To: --ka4fpqo6ejmxfupn Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data MIME-Version: 1.0 Hello, On Wed, Jul 08, 2026 at 02:34:33PM +0300, Andy Shevchenko wrote: > On Wed, Jul 08, 2026 at 01:15:07PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > Hello, > >=20 > > this series superseeds my previous patch "[PATCH v1] mfd: Use named > > initializers for arrays of i2c_device_data" > > (https://lore.kernel.org/lkml/20260515095839.4005460-2-u.kleine-koenig@= baylibre.com) > > that Lee asked me to rebase and also the series "[PATCH v1 0/3] mfd: > > Initialize spi_device_id arrays using member names" > > (https://lore.kernel.org/lkml/cover.1783003256.git.u.kleine-koenig@bayl= ibre.com). > >=20 > > The objective for this series is to prepare mfd for changing > > of_device_id etc to make driver_data a union, see > > https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylib= re.com/ > > for the idea behind it. > >=20 > > This series is based on yesterday's next/master and it does the > > restructuring not only for i2c and spi (as the two series mentioned > > above), but for all *_device_id structures that I intend to modify with > > a union that affect mfd. So (I hope) this is the only patch series > > affecting mfd for this quest. > >=20 > > I don't care much about the last few patches unifying the coding style. > > I think it's a good opportunity to do that, but if you don't like them, > > just don't apply these. >=20 > The patches bring inconsistency (or still leave it) with the terminator s= tyle > in both I=B2C and ACPI ID tables. Can you revisit that? I found a few inconstencies for of_device_id, but not for acpi and i2c. I have a script for the acpi and i2c (and now also for the of) changes and don't spot inconsistencys in the terminator style for acpi and i2c devices apart from comments. (I looked at the output of: git grep -lE '(i2c|acpi)_device_id [a-z0-9_]*\[\]' drivers/mfd | xargs -r = sed -rn '/(i2c|acpi)_device_id [a-zA-Z0-9_]*\[/,/^};/p' | grep -B1 ^\} | so= rt | uniq -c ) Do you mean to unify the comments, too? Best regards Uwe --ka4fpqo6ejmxfupn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpPx4cACgkQj4D7WH0S /k624gf/dzy2q/+UDcko+3qRC/vjduntKV5JaImo1jv66pbGa0vVyVdYDHS/QwvV X+Jr6jTMyEZcw6O1onRP1ZIcKU6MTkl/wvtqeLkFJ4PXv/hKftTSkP/IHkLuekNm Cn37LNIalY7gpr1gfPvcL5Q/BN1qqXCUggmW0xXf+Gi9W5bwWuTaRsJ9ehVptA3+ rMp5HAYJ1isaiiqfMZJ/TqtNWHN6aVh8ZS6YU5b2iDitwtnRCQD1pOcYCYaXgfrt fbXqb+xpQvMfRgK+MLErhmJUfHf2tKi1s5OKoG1T9fiLCmp0VzTkB4+o4AgpQgeE pUTRSN5jhrCLDAt7v6B6b4XHPcYmTQ== =tSBk -----END PGP SIGNATURE----- --ka4fpqo6ejmxfupn--