From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31E1346E66 for ; Thu, 16 Jul 2026 10:44:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784198688; cv=none; b=LV14j742Mie0hNe8/LgkpiT7LGNimHW5K2GEm1r/FlHqWJyx/RJ8YH6P0SXWgT0yflBqkBq2cFoLKkOays5XggjJszx7RYNm+PB1RAKdz7um1QBsfP50qRZ2lsPlj8WYKx4NLQt64xxBm1yVy2QOkrwUjl9U9l0pv0+9GM2qV/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784198688; c=relaxed/simple; bh=QfvC1FGivIYwMNcU81A7ydKOruNfuDO836KrBsFCpag=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EL4GIWWRWCmoVoh5nlZTVzlJ5/uqeeiOXLjQH2KE1C6PF1F6TdmuQ8d9Qaknanc+HdfwaH692ix38KAmhNLnYJENIZt/+ITOhdjbn+OkAldMMOzqNG1Xmu8Mi6tdsZfkIlr8tzkeSqtQmmr6QOBm+02fqYDdzfl64X+uk/GMv80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SqXxYypC; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SqXxYypC" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4759b4f0897so1802480f8f.1 for ; Thu, 16 Jul 2026 03:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784198685; x=1784803485; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bG7DiFK2AkiQJxlm6ywiTGbJgNucHDn6Zq82S4v139g=; b=SqXxYypCpqoUaKnL+1ZBREuJm+K0EsRLoUl/CwRpnYe/yXcrJOnNa+nDUTo/NFoOWp lncl0kx7gvH0G6f4I3aRSayMztXMUMoY9/i64H4YAarlczoILYjEZ2JYs8ZjYXzBzmqW H5R/EI05tkHFOWiqbWsaJP8/4N7vvZl0KIAhtLaE+STBCqJQK1g45GsRS4kjcbH2Ed1b b4H1mkgX+FsKk09gnEfNTsh/VrPfQP1dTp13Y+unoOOrUovq90z4h11PLdgjunYbgQlo zsBtGRZ0HW4cmVI7ZV8GmyxxJVnCEbqcLBQJ4tkPlLcIqn3p6dZT1KlInfwoIiLQyM3G f5TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784198685; x=1784803485; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bG7DiFK2AkiQJxlm6ywiTGbJgNucHDn6Zq82S4v139g=; b=lwILlZYgN6rhukiJ11EuSJPZ1HXW/7hLmAQfCY43vLBLfF81x2nMDw/SS4NhjTCAjN N6BnHjhdvHHFDiOVWkxSImPh6KJXmBVbvD395QQD7saVnGaooT6HfqufFip2Osl0T9BC wt6r9Lu7Wi3SPcSm71qxY4SZy/HH4sc/WXL92xj52ckkQ0/A0CqH7+Rz8sFFcgWTWPH4 lqUxIHKBsaKuPIYV6+NUl4TtIxCyHUWp6DeHNAOZUPhT9TOtR6O+C/ubVj7C3wbtG4q/ nvFTeLAZzw0OT+bBZKP1uook708Dm/dF/FFYDYdYHhJ3tRkNyynzP6XMhHsSff4xvLOB Dmkg== X-Forwarded-Encrypted: i=1; AHgh+RpzBmJWbFe1iQ8o6YLDiuGUcktA96F0QXkwRNawFlknFC8tY/kjYDgf/WcDKt/yd1ZlWMsvFeuJGJaMcdFU@vger.kernel.org X-Gm-Message-State: AOJu0YwneRduY0TygjFFSDCm6j6ZLQnagFrfFIilHGUVWVKwHmpuJt9V wlrI3cVgA1qYpMre8gmwcO1ASORmV5sRGlGfJOXxazMd77tCak3WAraXRSDJkDHhlxA= X-Gm-Gg: AfdE7cnRMozox1vu5v9L2fYdwQO4ILkURYIWukdUyz/H3GipWMOpHHdVU6KLKxtzuJy n5i96vRC7vmujqhiFJnvoC1EAqz+x7o2+4VxeYno7aK9KqRc/L+oNd8Lr3m9bLiHZgtyQ1S8+la 35BN5IzyOyZjR/paU0BbAWVsvvegQsiZGxXfnzPCXHEKIpN7N9NnnDS4ezxVcq7ZJQGKvpOed75 Cizsba7YRKjlnef2EMa8Zehr1/Nlt5PNLPYKsrjqWYEl8KmNva22S+1Bdhrul/QT3Io6CGAHQ+a 54Uvqb0FSeIl+y4YYYDCmFtUaenewG2V0Crs1gYs9LtGMTmOBg9uIWOPlfP4DNvETDt34tgqwen LL8Yf+htZI+P4qXRTJF4Ed8E+IxcEJkoQ96qjtMuwE0UEqQZzVzM5KSM4VMlH8GlClO/wyVIcbZ PL0gm//6U46K3EYw== X-Received: by 2002:a05:6000:310d:b0:477:6da:1b6f with SMTP id ffacd0b85a97d-47f2dc9c5b1mr23909548f8f.23.1784198684979; Thu, 16 Jul 2026 03:44:44 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff24:7210:a01c:aecf:c14b:e17e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464c1f84sm23851143f8f.29.2026.07.16.03.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 03:44:44 -0700 (PDT) Date: Thu, 16 Jul 2026 12:44:39 +0200 From: Stephan Gerhold To: Bartosz Golaszewski Cc: Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Md Sadre Alam , Dmitry Baryshkov , Manivannan Sadhasivam , Bjorn Andersson , Peter Ujfalusi , Michal Simek , Frank Li , Andy Gross , Neil Armstrong , dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , Bartosz Golaszewski , Vinod Koul Subject: Re: [PATCH v21 06/14] dmaengine: qcom: bam_dma: add support for BAM locking Message-ID: References: <20260713-qcom-qce-cmd-descr-v21-0-bc2583e18475@oss.qualcomm.com> <20260713-qcom-qce-cmd-descr-v21-6-bc2583e18475@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 16, 2026 at 12:43:04AM -0700, Bartosz Golaszewski wrote: > On Wed, 15 Jul 2026 18:06:27 +0200, Stephan Gerhold > said: > > On Wed, Jul 15, 2026 at 09:06:46PM +0530, Vinod Koul wrote: > >> On 15-07-26, 14:43, Bartosz Golaszewski wrote: > >> > On Tue, 14 Jul 2026 11:49:14 +0200, Stephan Gerhold > > > > ... > > > I would avoid using struct dma_slave_config->dst_addr (like in v11) [1] > > though, since it's more a "address to dummy register" now than the > > actual dst_addr of the peripheral. That's why I suggested > > struct dma_slave_config->peripheral_config. > > As in: > > struct bam_dma_peripheral_config { > phys_addr_t scratchpad_addr; > }; > > struct dma_slave_config cfg = { .peripheral_config = &scratchpad_addr }; > > ? > I think you have the same thought in mind, but there are a little bit too many odd typos in your example to give you a simple "yes". :-) (Why assign &scratchpad_addr to .peripheral_config and not the struct?) While at it, perhaps we could rename scratchpad_addr to have something with "lock" in the name, to make it clearer what it is used for? (lock_scratchpad_addr? lock_dummy_register? lock_scratch_register?) Thanks, Stephan