From: Thomas Gleixner <tglx@linutronix.de>
To: Ankit Gupta <ankgupta@codeaurora.org>
Cc: rostedt@goodmis.org, mingo@redhat.com, agross@codeaurora.org,
davem@davemloft.net, rdunlap@infradead.org,
standby24x7@gmail.com, sboyd@codeaurora.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, gavidov@codeaurora.org,
sdharia@codeaurora.org, linux-arm-msm@vger.kernel.org,
mlocke@codeaurora.org
Subject: Re: [PATCH v2] trace/events: add chip name and hwirq to irq entry tracepoint
Date: Tue, 23 Jun 2015 10:25:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1506231024250.4037@nanos> (raw)
In-Reply-To: <1435014310-2080-1-git-send-email-ankgupta@codeaurora.org>
On Mon, 22 Jun 2015, Ankit Gupta wrote:
> Add chip name and hw-irq number to the trace_irq_handler_entry()
> tracepoint. When tracing interrupt events the chip-name and hw-irq
> numbers are stable and known in advance. This makes them a better
> choice as a filtering criteria for the trace buffer dump. On the
> flipside, the os-irq numbers are dynamically allocated which makes
> them difficult to use for the same purpose.
>
> Dump messages will look like:
> ...irq_handler_entry: irq=22 name=msm_serial0 domain=GIC hwirq=140
I can't see the domain name being captured/printed in the code below.
> - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
> + TP_printk("irq=%d name=%s chip_name=%s hwirq=%ld", __entry->irq,
> + __get_str(name), show_chip_name(__entry->irq),
> + show_hwirq(__entry->irq))
> );
Thanks,
tglx
next prev parent reply other threads:[~2015-06-23 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 23:05 [PATCH v2] trace/events: add chip name and hwirq to irq entry tracepoint Ankit Gupta
2015-06-23 8:25 ` Thomas Gleixner [this message]
2015-06-23 15:16 ` Ankit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1506231024250.4037@nanos \
--to=tglx@linutronix.de \
--cc=agross@codeaurora.org \
--cc=ankgupta@codeaurora.org \
--cc=davem@davemloft.net \
--cc=gavidov@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlocke@codeaurora.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@codeaurora.org \
--cc=sdharia@codeaurora.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox