From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D04F3551982 for ; Tue, 8 Sep 2026 13:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788875026; cv=none; b=OKMg+TUzoVnrlp3z1oR5a/pkhRvuV0Ju13wQ4oUaXfScpGB8F9+Wyc88jo5Sgj3SX62ZRXyalbq7AgLQb/yehK8oQ3NOfd8eg1IfzrEPyf7rMjGrXhphxVemENpXUkZRuNFBhFf+cwxtf5jl+Lwb2RbZrUGbs6XF6nd+CpwmnLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788875026; c=relaxed/simple; bh=/JZEh6olWPepouwU4hBOKCHkM0eWw9CAmBjHT5JKKw8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jyWiJveTLMuDlSuVk8OwzSvDheZbThuTz6A4qd8AETn5AZXCIdtOa7bcXZwzXT8LmYndGSX8q+ZhTeQ5ueRc4GE/jL05m9tioGTVirks/AWoMLB2gbv5GeFUHW/yU9Hf4KvizrYgVIqhA1x4grMkVVFC5BqPjZJUsjCABE+SqbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m4A999HM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hlPB1QZc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m4A999HM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hlPB1QZc" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 688Ckssr3013087 for ; Tue, 8 Sep 2026 13:43:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=FNv4YZM6Cu52UIrM7KpWyRo8 GDUAmOGuixGQjhwCuBY=; b=m4A999HMC9wgG4G2CMo484t+8Sx5PlNIbmg/aggS UbhWtJNQtdob+rwyA2BmXnfdSCogCZah2cRBHPkdDS2p0UUc6eBdIJ/YTZe7XtHe qgP5wDwVt4FD4tf6UsG+7eDd5G9eh4q1lu4mxoaq8LbN7IcM+dTvo2apr5aKK3kM 6ZgcZxw+5YRgXmzGLJ2kdFJObrjHdeO53Zj+z+IGTVHSs0C4JWE3mc9WiYfBjBHv xZO65WAdE6fshcCNnmSzDRO+Lwupx7kJqO/APJbUcdw+sQ1WR8ga78iFDU3LqkjN 0eImjhcFYwR0/em71q3GhQpRzYtF/BUaRY48r1nLX2fB8w== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gj1rwkqbn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 08 Sep 2026 13:43:29 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cbb20f82a0eso3326351a12.0 for ; Tue, 08 Sep 2026 06:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788875009; x=1789479809; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FNv4YZM6Cu52UIrM7KpWyRo8GDUAmOGuixGQjhwCuBY=; b=hlPB1QZcCp2SGEG/dBb56Kq5EOWtbkK2gO6EHFpo7Vdau62Q/UeSXQOzndAwROMH/F Sb3ALrHTDepzVYgAtcXq7Ck/7RarmmJiHvvOJ2fOXNGiHHjZL2280rNc1D4lSeDZ1kxA i2Srl6pHLmqQmjFg4xtzQZ2l7dCYolSEmBdzJRT6NhFCvjaLTYiJVHHaq+pKeU0fRdHy k7X3kpTJqbc71Lj0/V99fc4s7xistPv9OQpV/l4NvRJla2DefxjycSQV/H6awtIvQtsI hAEsItWmAkBg9acHG07xY02oh8yKIqHDGoNZhwhM/OLQ1Sy3lCbgYsmVN/chxujsJYU+ s/Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788875009; x=1789479809; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FNv4YZM6Cu52UIrM7KpWyRo8GDUAmOGuixGQjhwCuBY=; b=YEBLDPDZC6w0GisOIEpnvLnVKdYkQtJlwUp9V/Tc9942sf6wdWfDdD34gfaMWDt382 5VdxFFl8p38V/TMcFKASJh894ACLinp4BMPui3WUbIPC+aZzHJcPFyjnurdus5afBTfr yCQgSoEBO56lfYCAD716owZQ8pWKQEIUaEz53G81R8onpmKFhHoWwDKoGRcfzMeCDnl4 IEKJrhUiXHTcDbx6wH5hEoJ6bUbYIc0gqwTICmGPn4e8NuO8uIMvtnIsnLvWT7qHBIRK gaxkcHdRp1rWFuH2B7Bhi/w8N3wwFBuHfmp+Yg8QhnNLbNzfEUkzlCCrZc0hLk6d0TR1 k1Og== X-Forwarded-Encrypted: i=1; AKwUvBx35iBT3EBAmd9qcoBmHHMCpM8m2gcVmE9+teYS8qGGRJd5QoBIdp9vczqVaF7CCfl7EvnMs8uZKNQQWOP8@vger.kernel.org X-Gm-Message-State: AFuF++kn4tbAIhuxMWXYH66hebX49h0yVOT7UrsyTAgKbBluKsdrd1uB rwlYy/uyFpiVEmGHOty+tD3K0uh+pbtMuxVA8nPTGt9sp3OXdj7rfSbcMm0tM0FoqKg0tnHQ+Rg u1Db8DCkUHBK+0BIhG3I24KbOfHHB109Avi0Q94a1n6G22wTm7IVumw5FZr5upFz5T9RG X-Gm-Gg: AYBFou12GN8Q2VvkFaEaRi0Nc0aHHlkwOrJtB4U12LyeTQXb0Zil6QQ1h4+/nq9a6B5 i83Tdc7PqqcpfmGA5F61MSyvNAexw+TKXGGdIyQx/JiWu2PdP7kPJz93EQtKbrsH6ITvXnA6VrF kmo+Ut3b6S/kIKCZQdhp8litwgHU6vRw0dIHSxLTAmrYDDoDP1v68fdbtOnLhFzWSr0zDfX+w7H mFnPPo7pru4lknvtse75DFFI31cTSA2kM3iNFtNQ3/BL5StuOgWcVYnBoF44bjb5HrU8og6sWNv YNqsN3KSlLkYV0IfQ59DftkdMvvdpzNG3XJTLX1wc9+GnTIJhHor9WpP3bUe06aiVb2gYBNaYGn KQ8pM1iWNZDBFAg== X-Received: by 2002:a05:6a21:3e0d:b0:3da:7154:2ebc with SMTP id adf61e73a8af0-3da71543f94mr24925206637.7.1788875008952; Tue, 08 Sep 2026 06:43:28 -0700 (PDT) X-Received: by 2002:a05:6a21:3e0d:b0:3da:7154:2ebc with SMTP id adf61e73a8af0-3da71543f94mr24925119637.7.1788875008446; Tue, 08 Sep 2026 06:43:28 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-333c9db92b1sm36539625eec.9.2026.09.08.06.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 06:43:28 -0700 (PDT) Date: Tue, 8 Sep 2026 19:13:20 +0530 From: Mohd Ayaan Anwar To: Andrew Lunn Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Komal Bajaj , Anurag Pateriya , Dmitry Baryshkov , Richard Cochran , Andrew Lunn , Maxime Chevallier , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH PRELIMINARY 1/5] arm64: dts: qcom: shikra-iqs-som: fix GPIO138 reservation Message-ID: References: <20260908-shikra_ethernet_dts-v1-0-69c0c5c7c124@oss.qualcomm.com> <20260908-shikra_ethernet_dts-v1-1-69c0c5c7c124@oss.qualcomm.com> <169b2cd5-d0d8-4682-8756-bacf545a95a0@lunn.ch> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <169b2cd5-d0d8-4682-8756-bacf545a95a0@lunn.ch> X-Authority-Analysis: v=2.4 cv=Ga8nWwXL c=1 sm=1 tr=0 ts=6aa01102 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=mbnDeuF-4I0g7l0wkJUA:9 a=CjuIK1q_8ugA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA4MDE0NyBTYWx0ZWRfX5HA34PWZH9KB w1ALElXq9Aj2kv1tUIHRNXQfCzi53Ww/SIpBNKpLU+uhYCRHVLBmSmVPXPrBu55xFwIeRdxqB3y wWNDsleeladA9EQDWbr3rUHaBh0ZwtzXTU8DC2BRPfyEQBoO4YEDHDq4Z656HfJ/C7zx1XCc4S4 fnfBvVLe4iRrxO1NQxJBjT7Rs3UAYq3lWxQctIS2Eu2Sq44pS06d66Cfn+DrcgfH9RDBxGh/+Nc hUqoaNOzyjopHK3V3eE/OyE+09FUthlYwcua2Y8qXtAX3q4jALxjxxr7Q3qoJbIvw6XcWjE/r1i Ujsi3YZ0A/HdEe9BO4dbmjzWR67833ucRgRfB/8ONy/y3eS+/gFJEgOe436T1ills5eaWIn/9Cv 2G/gWYdzTP9keU5adNfosaaqPtqHMNTCnnzMcoVlQMcRBBdbc5sNrNR/ByHdtrvhEnOKLCvOe3/ ErgtFYs3HKQlFd1bWEw== X-Proofpoint-ORIG-GUID: BcgF4vmZNEuztvASadmSmlhYYx2PZgkl X-Proofpoint-GUID: BcgF4vmZNEuztvASadmSmlhYYx2PZgkl X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA4MDE0NyBTYWx0ZWRfX6cEGEJF6nVZj hIgU7GlsnytiJab9zEC6Mg31GoSmgZqbiJoCPMpcRPmjeI0Xai3qQ0SGKZYaKhphhpGlRMGAHpU NKmMtZ/7DjmMran3RPBvlu0JF3aychA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_02,2026-09-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609080147 On Tue, Sep 08, 2026 at 02:11:22PM +0200, Andrew Lunn wrote: > On Tue, Sep 08, 2026 at 11:53:30AM +0530, Mohd Ayaan Anwar wrote: > > The GPIO mappings on the IQS variant differ from the CQ variants. > > GPIO138 is connected to the RGMII1_RX_CTL pin rather than the NFC ESE > > Secure IO pin; the latter is connected to GPIO49. This incorrect > > reservation causes the probe of the second Ethernet port to fail: > > > > shikra-tlmm 500000.pinctrl: error -EINVAL: pin-138 (5d20000.ethernet) > > shikra-tlmm 500000.pinctrl: error -EINVAL: could not request pin 138 > > (GPIO_138) from group gpio138 on device 500000.pinctrl > > qcom-ethqos 5d20000.ethernet: Error applying setting, reverse things back > > > > Replace gpio138 with gpio49 in the reserved list. > > > > Fixes: 779aead2dace ("arm64: dts: qcom: shikra: Add gpio-reserved-ranges to tlmm") > > Signed-off-by: Mohd Ayaan Anwar > > If this is a fix, should it be posted for a different tree, so it > makes it way to stable? > > You don't normally mix fixes and on going development work. > You're right that it reads like a standalone fix, and that's on me for the commit message. There's no functional impact on current users: the reserved GPIO (138) is unused today, so applying this on a released kernel produces no error and there's nothing to backport to stable. I'll reword the commit message so it reads as a prerequisite for enabling Ethernet rather than implying a current break. Ayaan