From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2303147A870 for ; Sun, 20 Sep 2026 19:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789933187; cv=none; b=lcifvXHpKZ8A64ybhgmO+VnT4X1nJCFKYal/6bnGSuBUnFImEoFQ4/b1XiFVEIgzqbJOgV47QgytDDgigGm6EEtGm2hsQ4LIwYbAiLWr7TNER74ADbrP2/zmmGBQrR1rQeLYmS9XqZAGVvPKlhQ9motC8sDR+DMERyIEsZ7pmVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789933187; c=relaxed/simple; bh=BFGYGg6hFd6brXc8be9Lc+zgUDV/5uBkffDvcSv8+Yc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L0AQwq5Fmhi8vUrdn5bBVRBvoM7V30mTLx63e3Q+prHeDauvm3IZ+h0DK9GpmLWtQ8cwgiyx51nVq7reDoe/1qeb/O9A/706uJrS8n6xNHZbGKmEQpJLp92Pbm8Y7VbyzFlnZLBlWeW0QlYCX4/XbNEjkxcYFf3qUOTt7ReEtkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=UpoFBPzf; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="UpoFBPzf" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49b912e64ccso16577625e9.0 for ; Sun, 20 Sep 2026 12:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1789933183; x=1790537983; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rF0vHV+0AKSYzey1/84t/+UqW00wC12/mV03L9JGZxk=; b=UpoFBPzfbKfC+4D8uflO29K6XHkW8qdKbdmVDw1tYoj/eKVt3nHP1MzSXaY6ZUoCSd p7hnNsIT0zNI93b4eLYUjHEF5kj5qiFRMHoCEJ0RctULJQGIayodEkpeVDguNPIemR0F 4a9/J0UHrJJ1SBRjff6BwtlzH9/TNGQQzYo8BACplxYsL16n6FTodRlhOfj6T5kX0QGR HO1EDuCwCngljo+Cg7FOgqJ10xVvo/rTSmAkZL+Top0iJsN5CvBonZJEI0PHxHaJ1/0y Amw8ZCKeN5OgC3V7TQ1LLNL+gFdjpLFNtKDlEI+/6Y1LYACCGO6hUQI0RYL9fQTOt3YW 5CKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789933183; x=1790537983; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rF0vHV+0AKSYzey1/84t/+UqW00wC12/mV03L9JGZxk=; b=ZtMeCk7syj4xvccM6PL3tBicT9XWBeXS3zktX7mCXoHyRD0Q6jNDDscYfa+nzkOFqO O3YJgIJCoNF63s0CM+mNXxvNLTONkyJO0zfAG4gf60UqEKPj4wMNyhQpdQbeh324EV5o 1ug+FOSvYKU8ZbdEZfqZQGCb3Q2iGCKIFgGSdPA7OgBnfP68nDQ3GHQBP07NRo1DQIRy 5JiBDq+HW6zCXNSDpl7NOVMhjZQPp/5ja8YIkzRu8l/NEc2+NOM/qf6/g9wNzkW6lJir q0EmOBZXkmjTlpK/GMpyDSix+ZoiLifu8x9AIeVZ/JE8BLPUgkMyUz/xAqWZiN6stuKD 9Lqw== X-Forwarded-Encrypted: i=1; AKwUvByJOUEgpRzORQgK9xqOtrfQ85KeEWjxSCCX0Pngedurl2rEH4Ix6l5mO02r3xbeC9oQSB55XvBgpmvpkrcD@vger.kernel.org X-Gm-Message-State: AFuF++lNqF3iUCfs2cHT/FcsaVm6bDim9tFNd4lGoDMRvvAdLfqyvBGD lWxfVLOeTzBDgBN+hEZRR6HciuRJe8dr+Q6VNDxyzp7K+Z7jvY6Oq+SM5p5AWA1yLmw= X-Gm-Gg: AYBFou1xpBAZKhrrGD+xumLBE8FW6DFykiFRNDY8SbMPQLp/q2yXbAUmlDhN4JbwZ7Y VgeqEa79RAjCVLFHIMactNeHwWG4H5SeuK6SxccuAid0+fjS9ECFkjIaHTo6oSr/IzfsIKtNFZj pT+h9CWmkDY3Cde6ki5RjffLTeD0jgXCzA3tPN2uAiRmc1JVp9ZoPD4vhF2xgLQZsDJ+IawDpto y39lpt8I3YzxwQpaJm3iDD6KU26/J6kg77ZweQzN+ESc9lba2+09miQImZmm2CdHEr9iUd/4roi Mz+jkg2wlGFtHgw05inCv2QMmYQL1PZTFuZFvtgTiGo8cyxV+WklbyK2WALzgLv131vPdwrgc6b TBUYgOKa3bhypCYd/m+jMQXCj0XVegbJP3NRibnYZMc9h+9xm/iR7CKPWpK17Zoli4ue3ZLv1dU IsZu86vFu0n6q30OiUkvd2Wx4q9EJJgmbAKcY5dosKCh9mxud5Lizb9Kn3qpmF4GMIhfSDsmGmJ ag= X-Received: by 2002:a05:600c:3e19:b0:49f:bd3c:bc1a with SMTP id 5b1f17b1804b1-49fc572f27fmr119630965e9.21.1789933183359; Sun, 20 Sep 2026 12:39:43 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-49fcd0ece6esm234353675e9.2.2026.09.20.12.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Sep 2026 12:39:41 -0700 (PDT) Date: Sun, 20 Sep 2026 21:39:39 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Alex Elder Cc: sboyd@kernel.org, bmasney+clk@redhat.com, jbrunet+clk@baylibre.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, andersson@kernel.org, konradybcio@kernel.org, abelvesa@kernel.org, kees@kernel.org, gustavoars@kernel.org, p.zabel@pengutronix.de, daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, mfd@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] clk: toshiba: introduce a TC9564 SoC clock and reset driver Message-ID: References: <20260918165234.687224-1-elder@riscstar.com> <20260918165234.687224-4-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tk4w7pucaicwka36" Content-Disposition: inline In-Reply-To: <20260918165234.687224-4-elder@riscstar.com> --tk4w7pucaicwka36 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 3/4] clk: toshiba: introduce a TC9564 SoC clock and reset driver MIME-Version: 1.0 Hello Alex, On Fri, Sep 18, 2026 at 11:52:32AM -0500, Alex Elder wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Please rely on linux/platform_device.h to provide of_device_id and drop including . (If you want to go full iwyu, include instead.) > +static const struct of_device_id tc9564_clk_ids[] = { > + { .compatible = "toshiba,tc9564-clock" }, > + { }, > +}; Drop the trailing comma after the list terminator please. Best regards Uwe --tk4w7pucaicwka36 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqwNngACgkQj4D7WH0S /k6pNwf+Lem5dcJHNqZeQwO1vn2EY3m9bTRWfD8WbvhlPJ79o5a3UXt/dBcaMHqJ RquJw/Iwe5AOARXNI2za1AWXKNpjbTyEXg0PG0/xV0FiyYXR+lz33BXvcKDWPl2S 0SilXiIV0VuCARwFkjcibTk4qZaP5tvRg/cD2nsoiDmMdl/2EbQpD5KqEVu1+v/b ZPj9we1Tm9elAc76W5CGrKLynb8dLHe5kI7balWhxGgV94XZhJCKLvK7Laa9ucYc abBaruwJGES79c9Uz6Fkn4CxZIcnhc5DwXHEzoTkQMMPt1u1L9ZaAxpPojFCv+D6 SBroUn8lSetw56k5hBWYPlyq5qgKAw== =ddJ0 -----END PGP SIGNATURE----- --tk4w7pucaicwka36--