From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795347366; b=5mGwfK2tWKTVXDYF/3dOt3K2ycNuLjx3WL2hhkExquOeYdkmOzzKGLjDdE1lOcFxWe0t JRqX2QXhcw3HJept93Juy3+FT1LRU25Y0QH2qPYtEEUc40in8aEG/xI2gsnJ5zkNlIxqe tJZFCQcQZxXyiaSJaGze0Jsp0laI4ovHYyc7Y++z4N91Tlu8BGiYsMrE6JarBO6MJh/Q+ 7xqAxuEaDVnW1XZUYSJRyrx9LfFfYbOZ+IUnn9eSl4y6M5AEb4/2DiQek6H9ZyO/wWO6b cqSZIMItXG3p+R41WdgusBPDgohCeyLmAVNORPq9FMUTlf2p5pnfRMdyFJncn9YKVIQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795347366; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Date:From: To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-ORIG-GUID:X-Authority-Analysis:X-Proofpoint-Spam-Info: X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=muP6DUXg9dLTYnQcGiDX4DlIbKU6QaKtbQTgxjz4/ac=; b=M5hhev4WCWuChmvYeHZyK+GgvjtEf07nq0WqEuG4iB1cPVJ8Y8rJanVglRw9FL2B163Q tsrEMwBonuyvus2nCOspXzUYEru+3pS3M59683ylq4baeaNH5ZOvZjoOnXgOAPcM85hfS XOOb7y0JUeaLo8VCjPR4GOnvUFe3ouBFdE7gVxvowem3UcxC4V+YahZvQoUvlU2z6ZpTu L70o9xCIEgxbokys4jaFMyBEfLYM9yeYswHnHUbtrlk1WTthpbyXfD0TtlEm3u8GIV7KS 9hAOU8FiZsg9/Ot0lazSeJII/i6dhEA2Zx9AytgxyvoSJq/hvTfj86TKWKDtKmleHlA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=OoVMAZwD; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Du7TtbHq; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B26C606A333 for ; Sun, 22 Nov 2026 11:36:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9B26C606A333 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=OoVMAZwD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Du7TtbHq Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AM86tVI972548 for ; Sun, 22 Nov 2026 11:36:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=muP6DUXg9dLTYnQcGiDX4DlI bKU6QaKtbQTgxjz4/ac=; b=OoVMAZwDbDBmoUb8eL+mcd6tZqZuGBWTCaYdmzvH a4LczG6uBQdDCngULHnaLsEti630LKNx+rmTtFs/DtrydtD+etmxlurqOl60/gn3 5HHU2BY5OGxG2VD2QNT6ZM4IcAsQEBWBConkyp8WWHj0heYkBstjxkcNanBWsPcH OG/DyLDsLAvsoi8fjVEgRoUsXnrvThzLU+KGKhUdDeFOLRG6iCmsk79EPQZ+qSYt PJblJILb8la5oFCW59v4HjjtHQZO3RHoH2RaiBTjKvuKhH19y9LLwsm/kyZJ4PxJ eWZmY1U2a5M9ztCfItMRjezgsGRXbsG1FfPJWtTehEIT/g== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j30nnumwc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 22 Nov 2026 11:36:03 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-1a5005fd0f8so4474379c88.0 for ; Sun, 22 Nov 2026 03:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1795347362; x=1795952162; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=muP6DUXg9dLTYnQcGiDX4DlIbKU6QaKtbQTgxjz4/ac=; b=Du7TtbHqr1vjCwWUmT+Gkp1MRR6z0kDHQ0awROW0/OoGhKnynW3K65dzjWb6dmyU/V iS0QBbi5JpEXDiZcsDzxsgMsQkPRth6t8jKTLZ/707UwSsSDPcZb+Ci1TWKRj6O2Lhll 7L6zcQ+p3Z0S5l2kzgPZLX9Q3l8aF1FBfJDmI0OibFYtdCG+3u4q6Q2EYdIUyHOHCV5i /MttkT0EwY7FYygub2MPZtVEY8vlzglni8b7vxHJsn42VDxmmUMSq9bc75gltsdB32dp 7Bgcre3jIhv2HAvJJvcbq10WZW/uBKWGWI+IgbLLxE9L5h0/sHMFafLrm5ijBYQ2kbuq 5drw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795347362; x=1795952162; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=muP6DUXg9dLTYnQcGiDX4DlIbKU6QaKtbQTgxjz4/ac=; b=WaE22NDRg4IV9ghYghWs/twyDU1raA9gDo+D1/qySatz0HxYdaQIyMeSVVzZQi+4xu mo1c353tgC3TY1u1hsei6mOJunwSslNS8B90p8CbUokNpi54Q1lA/XniWgBdy7TUoIHe WEVSO9OCiy0JOPrAF9zaIewAiX6OKjnjre6Q87cR92SYobVGHG8quqjHyWDeGNl7yJ0w JfLNkuQVnz0/lQZQOYd8SYT3L0XMV1G2V9nxxXiPIxTU/9kV+Hah+BrZYLAiMAr6sgfn cgbGzk7XpmiYTsm1wKTHMFAGB/waG806VgCxu/yEqn0PCuHFB8XuE4gK2SO73cspgk5e fSgg== X-Forwarded-Encrypted: i=1; AL+hErFZLS9CMSBRG2WdkEwmRcmLS7Ny6UxHu40XG39849ZMFHD3DV5E8S52tvrZlboPnETSd68cv/FlSspUS1c0@vger.kernel.org X-Gm-Message-State: APuU4Z+ZV95ErbigkA2tHDbFr3giATADmzkCuzuqMmqfBR6oIMzRtLgn THtpBjrkU5eHaPSLvUTSH0mkY7o5jCuV2z3SngQk7UjJq2oEPrWbyZ2HZtVD7Mw+RHLLsB2Sz2B 4YEeQgV1CcQtTSkPg+i/1gFESzK6Kbn3WUlLF3eQBDlM5VRni+qQy1FuF76kfNuMachKz X-Gm-Gg: AZFdTZdz6VQYXzRj3jvi8Cptky0CMNNSdU4rX9Uu+EHeOP/H1Rqw4DAu9nCiraWG6Xh lx/wS3aqFK+nd9m2/i9fd4qOsY3CtimjoTKT/Ez447x7puXD0ACz45cKr8AGAupbn2hdV0riKDR LyE8o3AF7SonFdkOziiK6so8VMBH1qThj/avnxd3A+LqX97qC/YTSJdJWum6PQzGCuL1UZOP3mU r8uQCuubWGD80+KdH8SMTpuQLm5KwAwfyzQRylitMmGpZau8PMIGIlJgEPASIdwU8sy+wV3EeAW q5NV1SwTZNtkEehxacuQup2QHt9s5jMhvCbwIrA7SruUZa13UMa9zCOtzxqScxEiMvNJ+9Cs9Fs TFoMa/FkEZBc7MCjzGlqj/KPNdyJiSv7I8GKqoFBfBFpt62/Z5892DvrkiU0WPXQ= X-Received: by 2002:a05:7022:7f04:b0:166:af48:a2ba with SMTP id a92af1059eb24-1b5566fdfc3mr10202023c88.0.1795347362057; Sun, 22 Nov 2026 03:36:02 -0800 (PST) X-Received: by 2002:a05:7022:7f04:b0:166:af48:a2ba with SMTP id a92af1059eb24-1b5566fdfc3mr10201991c88.0.1795347361468; Sun, 22 Nov 2026 03:36:01 -0800 (PST) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b556847fdasm23234990c88.13.2026.11.22.03.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Nov 2026 03:36:01 -0800 (PST) Date: Sun, 22 Nov 2026 17:05:51 +0530 From: Mohd Ayaan Anwar To: Rob Herring Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , Lorenzo Bianconi , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v4 03/10] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible Message-ID: References: <20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com> <20261117-shikra_ethernet-v4-3-c41902e5f2fa@oss.qualcomm.com> <20261118190745.GA198891-robh@kernel.org> X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261118190745.GA198891-robh@kernel.org> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTIyMDA0NiBTYWx0ZWRfX5x6DUyJLloWx p4zLx/uYxUXSIsVF82oyuf5EtVyKIW4fgfgkVAWgixA43GuMLHImC1RFMIETtUNoktb1mYxiGYJ oehUOzQ+2yy2MLievURprYdvQcLqa1D5oK1OMgPntWZ2njGIiQ9h6WUASfTf9Bn98UYHkMo+2Ng KbDooUH7x/SwuomwQLq9Ol89Nziyv0LtJVVnaLD7hz4/EoLIm6sGJwhMxefJLQGRM6DOa9Vk3jw FBYsrxlrpIclzQt16a+4vWSgBkZt+JspBzIJWSxuXnDehnVLBf1VfQaUq/8/trb8AYMVn7kaj7K jGtwluocQLCdclMmHn6HotsL1JdD04Hk0IiEmAMxG9ULr82qzA3QPNWMefKn7Qut3m0vepkZa/2 B+NTAaIeV9SgERzdD0HHjUsLOsly5/1/INsl/yGb4dWyJ5R4DEr96Ge/o/SZ0N1jn0dP4YUTDT1 0aUjAguB7IHzi/BXxLw== X-Proofpoint-ORIG-GUID: X0W_qkiVCnR1neLnjaeqSMklTSkcoCP9 X-Authority-Analysis: v=2.4 cv=LITz05W9 c=1 sm=1 tr=0 ts=6b02d3a3 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=cC9zmzg-b8Z3h8VEsn8A:9 a=CjuIK1q_8ugA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTIyMDA0NiBTYWx0ZWRfX0EdDglH3Gd0W 7XBYUhJP2JhfinmvwLqhfLU6n7N7Kc2rxBb9TYFjUede2y+HCBq5WrlQpg9Docfq5Q2rj1UCufi shvMkSzB0kyaNUQZJq9jnctFs2iKyO0= X-Proofpoint-GUID: X0W_qkiVCnR1neLnjaeqSMklTSkcoCP9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-22_02,2026-11-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611220046 On Wed, Nov 18, 2026 at 01:07:45PM -0600, Rob Herring wrote: > On Tue, Nov 17, 2026 at 02:15:23PM +0530, Mohd Ayaan Anwar wrote: > > Shikra's EMAC requires two additional clocks for NOC interconnect > > access (axi-noc, pcie-tile-axi-noc) beyond the standard four, and an > > OPP table with required-opps to vote VDD_CX to SVS when the NOC clocks > > are enabled. > > > > Add qcom,shikra-ethqos to the compatible enum and use an if/else > > block to constrain Shikra to exactly six clocks and require > > operating-points-v2 and power-domains, while leaving existing > > compatibles unchanged. > > > > Add the relevant compatible to the binding document for snps,dwmac as > > well. > > > > Signed-off-by: Mohd Ayaan Anwar > > --- > > v4: moved operating-points description to the top-level, and added > > power-domains as a required property for Shikra. > > --- > > .../devicetree/bindings/net/qcom,ethqos.yaml | 54 ++++++++++++++++++++-- > > .../devicetree/bindings/net/snps,dwmac.yaml | 2 + > > 2 files changed, 52 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > > index ef520f810577..6bd4bded650a 100644 > > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > > @@ -14,9 +14,6 @@ description: > > dwmmac based Qualcomm ethernet devices which support Gigabit > > ethernet (version v2.3.0 and onwards). > > > > -allOf: > > - - $ref: snps,dwmac.yaml# > > - > > properties: > > compatible: > > oneOf: > > @@ -32,6 +29,7 @@ properties: > > - qcom,qcs404-ethqos > > - qcom,sa8775p-ethqos > > - qcom,sc8280xp-ethqos > > + - qcom,shikra-ethqos > > - qcom,sm8150-ethqos > > > > reg: > > @@ -57,9 +55,11 @@ properties: > > - const: sfty > > > > clocks: > > - maxItems: 4 > > + minItems: 4 > > + maxItems: 6 > > > > clock-names: > > + minItems: 4 > > items: > > - const: stmmaceth > > - const: pclk > > @@ -67,6 +67,8 @@ properties: > > - enum: > > - rgmii > > - phyaux > > + - const: axi-noc > > + - const: pcie-tile-axi-noc > > These sound like inter-connect clocks. Shouldn't they be controlled by > a interconnect driver? On other platforms, yes, the EMAC AXI clock is only a gate, and the interconnect provider scales its rate along with the NoC. However, on Shikra, the EMAC AXI path is fed by a dedicated GCC RCG: gcc_emac0_axi_clk_src (RCG) +- gcc_emac0_axi_clk "stmmaceth" +- gcc_emac0_axi_sys_noc_clk "axi-noc" +- gcc_pcie_tile_axi_sys_noc_clk "pcie-tile-axi-noc" This RCG is outside the Shikra interconnect provider's control. EMAC DMA does not work unless all three clocks stay enabled, so the EMAC has to hold them and also scale their frequency for the line rate. I am hoping that I understood your question correctly, please let me know if you were asking something else. > > .. > > > > +allOf: > > + - $ref: snps,dwmac.yaml# > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: qcom,shikra-ethqos > > + then: > > + properties: > > + clocks: > > + minItems: 6 > > + clock-names: > > + items: > > + - const: stmmaceth > > + - const: pclk > > + - const: ptp_ref > > + - const: rgmii > > + - const: axi-noc > > + - const: pcie-tile-axi-noc > > No need to repeat the names here. Just 'minItems: 6'. I suppose you > might also want: > > contains: > const: rgmii Understood, I will make this change. > > > + required: > > + - operating-points-v2 > > + - power-domains > > + else: > > + properties: > > + clocks: > > + maxItems: 4 > > + clock-names: > > + items: > > + - const: stmmaceth > > + - const: pclk > > + - const: ptp_ref > > + - enum: > > + - rgmii > > + - phyaux > > Just 'minItems: 4' > I take it you meant 'maxItems: 4' here? If so, I will make that change in the next revision. Thank you for the review. Ayaan