From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A543C433EF for ; Mon, 21 Feb 2022 05:49:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344746AbiBUFt5 (ORCPT ); Mon, 21 Feb 2022 00:49:57 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237634AbiBUFt5 (ORCPT ); Mon, 21 Feb 2022 00:49:57 -0500 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2AE550E30; Sun, 20 Feb 2022 21:49:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1645422574; x=1676958574; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=YMNOqWJhLBUNCUljk8vXY6ouIh5oq9skN6nUvVW8b0g=; b=soLPyNbxxEX90wv3mxo7dHRGEGKt8FQ7+9+jeb2QI9zgatwt37G3kNwx 0w21tgiQikB6bMZIYQWQj5lTYXqYdw1q2qkrwcZ3gqBLcnz9CCFb3d1fZ u01nzW/RawdWdufH1/aGcv0fVK4CD3KydGVTMBJpp5vzYG2vfNPw8hxYP 0=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 20 Feb 2022 21:49:34 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2022 21:49:32 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Sun, 20 Feb 2022 21:49:32 -0800 Received: from [10.216.51.15] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Sun, 20 Feb 2022 21:49:25 -0800 Message-ID: Date: Mon, 21 Feb 2022 11:19:21 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings Content-Language: en-US To: Pavan Kondeti , Stephen Boyd CC: Andy Gross , Bjorn Andersson , Dmitry Baryshkov , Doug Anderson , Greg Kroah-Hartman , Kishon Vijay Abraham I , Krzysztof Kozlowski , Matthias Kaehlcke , Rob Herring , Vinod Koul , Wesley Cheng , , , , , , References: <1644952755-15527-1-git-send-email-quic_c_sanm@quicinc.com> <1644952755-15527-2-git-send-email-quic_c_sanm@quicinc.com> <20220216034702.GA8486@hu-pkondeti-hyd.qualcomm.com> From: Sandeep Maheswaram In-Reply-To: <20220216034702.GA8486@hu-pkondeti-hyd.qualcomm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2/16/2022 9:17 AM, Pavan Kondeti wrote: > On Tue, Feb 15, 2022 at 06:10:45PM -0800, Stephen Boyd wrote: >> Quoting Dmitry Baryshkov (2022-02-15 11:55:18) >>> On 15/02/2022 22:19, Sandeep Maheswaram wrote: >>>> Add support for overriding SNPS phy tuning parameters in device tree >>>> bindings. >>> This does not really benefit the users and does not help developers. >>> Could you please change the dt bindings to specify values for >>> thresholds, durations, impedance, etc. The values should be represented >>> in the human units (e.g. us, Ohms, mV), not in the internal register >>> 'bits' representation. >> +1 > Agreed to this proposal. > > Sandeep, > > We have a similar implemention in QUSB phy driver. can we have something like > that for SNPSHS PHY too? > > Thanks, > Pavan Okay. Will do in the next version.