From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799D8EB64DC for ; Mon, 10 Jul 2023 12:14:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231319AbjGJMOv (ORCPT ); Mon, 10 Jul 2023 08:14:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231447AbjGJMOs (ORCPT ); Mon, 10 Jul 2023 08:14:48 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 792A618F for ; Mon, 10 Jul 2023 05:14:43 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4fb863edcb6so6732066e87.0 for ; Mon, 10 Jul 2023 05:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688991282; x=1691583282; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FIUM80sem4wvBeLJM7gxDVfcq4hFkz0TAKhA7YTlha0=; b=CM/h05LBdzNNfatrfLN7zDsRHxIyJPeh8P7N3VasIH7sCErwoKYRQ91NRoDT5golq6 yOn7zwL2WdLaAv5e6i+XlpCa2l7ihZ+ZZFHumn3zhPG1pvLmVcKk9v8LoVR0RASM4zia 752kRYDPMnoBOu/DcBTnXFNP2ZS8mmIrd0FUJh1w0qSKsAM/lB92/dJ/lqG8tlhuF7YG OEOQ5afhhJ1lRobu64KC9GvqqrjFKqDXF/w0hcc5CcSh3Kk7pA1WzlIWT/q7JIvIZk0E SGIiMhNtPZmIVrr5QCvH01XCPBbkzHNmv1b6dVbHDxIu3miA27BXakVo2zqhHL5+cnvF Pjgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688991282; x=1691583282; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FIUM80sem4wvBeLJM7gxDVfcq4hFkz0TAKhA7YTlha0=; b=MOmps2JF8BgPqz/JLxxQJKu5mfTs37cfDB9Xpdcmq4QJ7qZ2gvoybqLqSlAu6xwYlM klHNc06BYy3QMBUNk5DzeLICiGMzbO9ZcdYjO1wR/u4wtkyUktg2IB+U4Krif8Gbl7o1 98FrG2IGeDJr3NAY5jSb3SNLZqcWVtYmECu8wOaabFVBdSO3lgMaRlKdJxw4kY8Kf8dN gPv+TSOVYu46qSLQr3t6hFRQl5IUBFGrrPuOzeOGCTm4mOajbAeoNr6/QXAhlr6bfIxq 7szwz+HuqZH2ATBWQViSysGYewRGii8cJH3xVczEOIT4Lh7sX4XQxZPJU4FrbppJsJ2K MtYw== X-Gm-Message-State: ABy/qLbH+VGfgb7rTtOq6b2IbsC3BAh0ALDSGAw0mlLg3XIpkxi+uOid uwgk0lxSXg2C7PdbTTE+qru62Q== X-Google-Smtp-Source: APBJJlEggwbPNBYWyFhjvfF6GLwQ/BHHtenN1h2x1ww8Fde/Lb05kPWkKWYva1WKoqvyG5xx6CJVPw== X-Received: by 2002:a05:6512:239f:b0:4fb:77d6:89c3 with SMTP id c31-20020a056512239f00b004fb77d689c3mr11852649lfv.12.1688991281113; Mon, 10 Jul 2023 05:14:41 -0700 (PDT) Received: from [192.168.1.101] (abxj141.neoplus.adsl.tpnet.pl. [83.9.3.141]) by smtp.gmail.com with ESMTPSA id e7-20020ac25467000000b004fb763b5171sm1678441lfn.86.2023.07.10.05.14.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 05:14:40 -0700 (PDT) Message-ID: Date: Mon, 10 Jul 2023 14:14:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/6] arm64: dts: qcom: ipq5332: Add thermal zone nodes Content-Language: en-US To: Dmitry Baryshkov , Praveenkumar I , agross@kernel.org, andersson@kernel.org, amitk@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_varada@quicinc.com References: <20230710103735.1375847-1-quic_ipkumar@quicinc.com> <20230710103735.1375847-6-quic_ipkumar@quicinc.com> <3f6ab4b4-b5f5-5807-0cb4-8ae782bd6044@linaro.org> From: Konrad Dybcio In-Reply-To: <3f6ab4b4-b5f5-5807-0cb4-8ae782bd6044@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10.07.2023 13:23, Dmitry Baryshkov wrote: > On 10/07/2023 13:37, Praveenkumar I wrote: >> This patch adds thermal zone nodes for sensors present in >> IPQ5332. >> >> Signed-off-by: Praveenkumar I >> --- >>   arch/arm64/boot/dts/qcom/ipq5332.dtsi | 72 +++++++++++++++++++++++++++ >>   1 file changed, 72 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> index a1e3527178c0..8b276aeca53e 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> @@ -527,4 +527,76 @@ timer { >>                    , >>                    ; >>       }; >> + >> +    thermal-zones { >> +        rfa-0-thermal{ thermal { >> +            polling-delay-passive = <0>; >> +            polling-delay = <0>; >> +            thermal-sensors = <&tsens 11>; >> + >> +            trips { Indentation seems off, tab size for kernel code is 8 spaces. Konrad >> +                rfa-0-critical { >> +                    temperature = <125000>; >> +                    hysteresis = <1000>; >> +                    type = "critical"; >> +                }; >> +            }; >> +        }; >> + >> +        rfa-1-thermal { >> +            polling-delay-passive = <0>; >> +            polling-delay = <0>; >> +            thermal-sensors = <&tsens 12>; >> + >> +            trips { >> +                rfa-1-critical { >> +                    temperature = <125000>; >> +                    hysteresis = <1000>; >> +                    type = "critical"; >> +                }; >> +            }; >> +        }; >> + >> +        misc-thermal { >> +            polling-delay-passive = <0>; >> +            polling-delay = <0>; >> +            thermal-sensors = <&tsens 13>; >> + >> +            trips { >> +                misc-critical { >> +                    temperature = <125000>; >> +                    hysteresis = <1000>; >> +                    type = "critical"; >> +                }; >> +            }; >> +        }; >> + >> +        cpu-top-thermal { >> +            polling-delay-passive = <0>; >> +            polling-delay = <0>; >> +            thermal-sensors = <&tsens 14>; >> + >> +            trips { >> +                cpu-top-critical { >> +                    temperature = <125000>; >> +                    hysteresis = <1000>; >> +                    type = "critical"; >> +                }; >> +            }; > > Could you please add a passive cooling devices for the CPU? > >> +        }; >> + >> +        top-glue-thermal { >> +            polling-delay-passive = <0>; >> +            polling-delay = <0>; >> +            thermal-sensors = <&tsens 15>; >> + >> +            trips { >> +                top-glue-critical { >> +                    temperature = <125000>; >> +                    hysteresis = <1000>; >> +                    type = "critical"; >> +                }; >> +            }; >> +        }; >> +    }; >>   }; >