From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52F4C7618E for ; Thu, 20 Apr 2023 19:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbjDTTsD (ORCPT ); Thu, 20 Apr 2023 15:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjDTTsC (ORCPT ); Thu, 20 Apr 2023 15:48:02 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEA6D40F0; Thu, 20 Apr 2023 12:48:00 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33KJPLMe003383; Thu, 20 Apr 2023 19:47:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=mlnc+kqm8lHe3JiGho4uw6t7nr2+BJu0rsJCPtSJX6Q=; b=ZFHHWfbHP8MC6wsr6CPZDUhxS94ImLRxbrI3NsAfyRWCm7N2RBD2FtErYvaCq5Tfdq/2 IQcpUM1Dk5x9BX8PKWQwvS1ykSJJ/1zTvIh236T66Xj9ZsvoRqRk4ICTyC62QxqB2ezI TKOAwFKeXLAnNP6xPZ5i3YUhqrkSCKvJOO4LX6lgOMQqVfjufFfIgiYVSIrVq02VhDDX xdfZ1dYwYbTcK/AqOa/rweMSsVdEY83k3GXWbEm9FEMvoynkURDXoikRJ+ZXZXdzIwSl hbzahFFx2Beths0KAxfp+2OdN3yU1i2fF18DNF18NBr059spSGdsoagq3z/it8tT+n/I Ng== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3q2hd9kwvx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 19:47:53 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33KJlqGJ018923 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 19:47:52 GMT Received: from [10.110.74.190] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 20 Apr 2023 12:47:51 -0700 Message-ID: Date: Thu, 20 Apr 2023 12:47:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 0/2] DPU1 GC1.8 wiring-up Content-Language: en-US To: Dmitry Baryshkov , Konrad Dybcio , Rob Clark , Sean Paul , David Airlie , Daniel Vetter CC: Marijn Suijten , , , , References: <20230420-topic-dpu_gc-v1-0-d9d1a5e40917@linaro.org> <5b133c55-e4f5-bfd2-b542-a7d44313c038@linaro.org> <3f3b3637-ed85-09a1-22b7-3ccd4bc929bb@quicinc.com> <2dff9d62-cffe-c66f-9e50-3ecd64e44d37@linaro.org> <6a335df7-ff0b-098a-feec-45714159df04@linaro.org> From: Abhinav Kumar In-Reply-To: <6a335df7-ff0b-098a-feec-45714159df04@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: r6S6Rnba1kohL_UaH_-EEfb1DHFzt7S_ X-Proofpoint-ORIG-GUID: r6S6Rnba1kohL_UaH_-EEfb1DHFzt7S_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-20_15,2023-04-20_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 impostorscore=0 adultscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=768 phishscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304200165 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: > On 20/04/2023 04:36, Konrad Dybcio wrote: >> >> >> On 20.04.2023 03:28, Abhinav Kumar wrote: >>> >>> >>> On 4/19/2023 6:26 PM, Konrad Dybcio wrote: >>>> >>>> >>>> On 20.04.2023 03:25, Dmitry Baryshkov wrote: >>>>> On 20/04/2023 04:14, Konrad Dybcio wrote: >>>>>> Almost all SoCs from SDM845 to SM8550 inclusive feature a GC1.8 >>>>>> dspp sub-block in addition to PCCv4. The other block differ a bit >>>>>> more, but none of them are supported upstream. >>>>>> >>>>>> This series adds configures the GCv1.8 on all the relevant SoCs. >>>>> >>>>> Does this mean that we will see gamma_lut support soon? >>>> No promises, my plate is not even full, it's beyond overflowing! :P >>>> >>>> Konrad >>> >>> So I think I wrote about this before during the catalog rework/fixes >>> that the gc registers are not written to / programmed. >>> >>> If thats not done, is there any benefit to this series? >> Completeness and preparation for the code itself, if nothing else? > > The usual problem is that if something is not put to use, it quickly > rots or becomes misused for newer platforms. We have seen this with the > some of DPU features. > > In case of GC (and the freshly defined DPU_DSPP_IGC, but not used) we > have three options: > - drop the unused GC from msm8998_sblk. > - keep things as is, single unused GC entry > - fill all the sblk with the correct information in hope that it stays > correct > > Each of these options has its own drawbacks. I have slight bias towards > the last option, to have the information in place (as long as it is > accurate). > My vote is for (1) . Today, GC is unused and from the discussion here, there is no concrete plan to add it. If we keep extending an unused bitmask for all the chipsets including the ones which will get added in the future in the hope that someday the feature comes, it doesnt sound like a good idea. I would rather do (1), if someone has time. OR lets stay at (2) till someone does (1). When someone implements GC, we can re-use this patch and that time keep konrad's author rights or co-developed by.