Re: [PATCH] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller

[Krishna Kurapati PSSNV <krishna.kurapati@oss.qualcomm.com>]

On 10/3/2025 6:57 PM, Konrad Dybcio wrote:
> On 10/2/25 7:29 PM, Krishna Kurapati wrote:
>> Enable OTG support for primary USB controller on EVK Platform. Add
>> HD3SS3220 Type-C port controller present between Type-C port and SoC
>> that provides role switch notifications to controller.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>> Link to driver and binding changes:
>> https://lore.kernel.org/all/20251002172539.586538-1-krishna.kurapati@oss.qualcomm.com/
>>
>>   arch/arm64/boot/dts/qcom/lemans-evk.dts | 122 +++++++++++++++++++++++-
>>   1 file changed, 121 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> index c7dc9b8f4457..0b6d8d2d19d6 100644
>> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> @@ -37,6 +37,32 @@ chosen {
>>   		stdout-path = "serial0:115200n8";
>>   	};
>>   
>> +	connector0 {
>> +		compatible = "usb-c-connector";
>> +		label = "USB0-Type-C";
> 
> Are there other, non-type-C ports labeled USB0 onboard?
> 

There is another Type-C port connected to secondary controller.
There is one Micro USB Port connected to tertiary controller.

>> +		data-role = "dual";
> 
> power-role = "xxx"
> 

ACK. Will add it.

> [...]
> 
>> +	vbus_supply_regulator_0: vbus-supply-regulator-0 {
> 
> the suffix suggests there are going to be more - is that the case?
> 

The second Typec port would have another connector added. So another 
vbus node would be added.

> [...]
> 
>>   &usb_0 {
>> -	dr_mode = "peripheral";
>> +	dr_mode = "otg";
> 
> otg is default, you can probably drop it
> 

ACK.

Regards,
Krishna,