linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
	Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kapatrala Syed <akapatra@quicinc.com>,
	Hariram Purushothaman <hariramp@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	cros-qcom-dts-watchers@chromium.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/10] media: dt-bindings: media: qcs6490-rb3gen2-vision-mezzanine: Add dt bindings
Date: Wed, 4 Sep 2024 13:29:44 +0200	[thread overview]
Message-ID: <b17ad6e0-a99b-46c9-89e6-df72773a0bd4@kernel.org> (raw)
In-Reply-To: <20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-2-b18ddcd7d9df@quicinc.com>

On 04/09/2024 13:10, Vikram Sharma wrote:
> Add bindings for qcs6490-rb3gen2-vision-mezzanine.

This we see from the diff. Explain what is this. What are the differences.

Subject: drop duplicated, second media.


A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Best regards,
Krzysztof


  reply	other threads:[~2024-09-04 11:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 11:10 [PATCH 00/10] (no cover subject) Vikram Sharma
2024-09-04 11:10 ` [PATCH 01/10] media: dt-bindings: media: camss: Add qcom,sc7280-camss binding Vikram Sharma
2024-09-04 11:28   ` Krzysztof Kozlowski
2024-09-05  6:47   ` Krzysztof Kozlowski
2024-09-04 11:10 ` [PATCH 02/10] media: dt-bindings: media: qcs6490-rb3gen2-vision-mezzanine: Add dt bindings Vikram Sharma
2024-09-04 11:29   ` Krzysztof Kozlowski [this message]
2024-09-04 11:10 ` [PATCH 03/10] media: qcom: camss: Fix potential crash if domain attach fails Vikram Sharma
2024-09-05 12:13   ` Konrad Dybcio
2024-09-04 11:10 ` [PATCH 04/10] media: qcom: camss: Sort CAMSS version enums and compatible strings Vikram Sharma
2024-09-04 14:44   ` Bryan O'Donoghue
2024-09-04 11:10 ` [PATCH 05/10] media: qcom: camss: Add support for camss driver on SC7280 Vikram Sharma
2024-09-04 11:10 ` [PATCH 06/10] media: qcom: camss: Add camss_link_entities_v2 Vikram Sharma
2024-09-04 14:50   ` Bryan O'Donoghue
2024-09-04 11:10 ` [PATCH 07/10] arm64: dts: qcom: sc7280: Add support for camss Vikram Sharma
2024-09-04 11:31   ` Krzysztof Kozlowski
2024-09-04 11:10 ` [PATCH 08/10] arm64: dts: qcom: qcs6490-rb3gen2-vision-mezzanine: Enable IMX577 sensor Vikram Sharma
2024-09-04 11:32   ` Krzysztof Kozlowski
2024-09-04 11:10 ` [PATCH 09/10] arm64: dts: qcom: sc7280: Add default and suspend states for GPIO Vikram Sharma
2024-09-04 11:33   ` Krzysztof Kozlowski
2024-09-04 11:10 ` [PATCH 10/10] arm64: defconfig: Enable camcc driver for SC7280 Vikram Sharma
2024-09-04 11:33   ` Krzysztof Kozlowski
2024-09-04 11:21 ` [PATCH 00/10] (no cover subject) Bryan O'Donoghue
2024-09-04 11:22   ` Bryan O'Donoghue
2024-09-04 13:36 ` Rob Herring (Arm)
2024-09-30 10:52 ` Luca Weiss
2024-09-30 11:54   ` Bryan O'Donoghue
2024-10-01  8:24     ` Luca Weiss
2024-10-01  8:51       ` Vikram Sharma
2024-10-01  9:30       ` Bryan O'Donoghue
2024-10-01 11:39         ` Luca Weiss
2024-10-01 12:49           ` Bryan O'Donoghue
2024-10-01 14:22             ` Luca Weiss
2024-10-01 14:58               ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b17ad6e0-a99b-46c9-89e6-df72773a0bd4@kernel.org \
    --to=krzk@kernel.org \
    --cc=akapatra@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hariramp@quicinc.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vikramsa@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=todor.too@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).