From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78AA1C64E90 for ; Mon, 30 Nov 2020 10:28:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B70920809 for ; Mon, 30 Nov 2020 10:28:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vi5Gi2uW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726337AbgK3K2L (ORCPT ); Mon, 30 Nov 2020 05:28:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728523AbgK3K2K (ORCPT ); Mon, 30 Nov 2020 05:28:10 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2FFAC0613CF for ; Mon, 30 Nov 2020 02:27:29 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id qw4so10641415ejb.12 for ; Mon, 30 Nov 2020 02:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mojUcFaFWrmPvm6PQa/ffpB+mQE3ctox4g4XwFjgJQU=; b=Vi5Gi2uW0ePyQwuhHVG6mPQ9oE3+Ttcbi2FUtWJjB9M4bdg9zYGKEMsGe+CbOplB3p 579/JECS5wOn/2XBn3w0JEw44fhdy7mAO+LHDTfyiycQ2M/nu1j1ux7vE7XwYY5fPu9L XwC3UF17fL0W0riQ8V5PBff4aW/rtjKgixQmCtQDwbuFk6+0tdiAh3z1ucLFsw++QTOn ZSkkZfhTYsHBt3a6QdRzEgBmOhHDZfSnrvUgu+tLGd4DP+Z5pQq2RYg9manUDscxNgrt BMUn/a9UEB62o4gr+qdZzuTV5WVtbyYmD+Kh1vYtTuytVH60WM3GsxpsGilzEV3kr/D3 gNtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mojUcFaFWrmPvm6PQa/ffpB+mQE3ctox4g4XwFjgJQU=; b=a2BHESWHmIFxruJVot45PKh6cGN+KQNTMGRO9v3voMhwLQ+hXUQfRLPW18tnqHHCuC E+nvwLB8CVDxf3GmXC+UUewIQQGG4VDyTQAcNnoiajakXPni5d2YU76/xlWBnh+oDkyV pVDcI8GWErepZGXYGYwKaC1C7ryB2H+EOHmVngZ8p/QwghvFLKOn2yUdwvy6S4aSL4+v fNt/jYckKd8mUSSr4/hFkeNW/KKGnglPQ2dCBGPmoJD+ZfACP8ZGzBfOv2LHUKjKVIVV RnRpgdiAh/lD413KifD3Gq8rMG+3ZgRxUDaA4Sqtm7QP1SGG6buoS92RYl78tTsMVkEG t2QA== X-Gm-Message-State: AOAM530MjVKFDp8K+q19iJqBpQgTjVynkXfuzSfaMiWmjuKkpva2X0aP zX6Nnc6DjZyW4jyk6ngOzfEqug== X-Google-Smtp-Source: ABdhPJzAIzL2sKXKKrMMVllrcQybVgI3uV4V/IXtJPiFulg+z0WjnIFVw1DwvfJoNGFqWfYIozE+ug== X-Received: by 2002:a17:906:6d52:: with SMTP id a18mr20155432ejt.224.1606732048726; Mon, 30 Nov 2020 02:27:28 -0800 (PST) Received: from [192.168.0.3] (hst-221-94.medicom.bg. [84.238.221.94]) by smtp.googlemail.com with ESMTPSA id v16sm2476312eds.64.2020.11.30.02.27.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Nov 2020 02:27:28 -0800 (PST) Subject: Re: [PATCH] venus: core: add support to dump FW region To: Dikshita Agarwal , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org References: <1606714572-1113-1-git-send-email-dikshita@codeaurora.org> From: Stanimir Varbanov Message-ID: Date: Mon, 30 Nov 2020 12:27:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1606714572-1113-1-git-send-email-dikshita@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11/30/20 7:36 AM, Dikshita Agarwal wrote: > Add support to dump video FW region during FW crash > using devcoredump helpers. > > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/venus/core.c | 47 ++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index 6103aaf..01a0cfe 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -7,8 +7,10 @@ > #include > #include > #include > +#include > #include > #include > +#include > #include > #include > #include > @@ -22,6 +24,48 @@ > #include "firmware.h" > #include "pm_helpers.h" > > +static int subsystem_dump(struct venus_core *core) this function could return void because we don't handle the error in venus_sys_error_handler(). > +{ > + struct device_node *node; > + struct device *dev; > + struct resource r; > + void *mem_va; > + size_t mem_size; > + void *data; > + int ret; > + > + dev = core->dev; > + node = of_parse_phandle(dev->of_node, "memory-region", 0); > + if (!node) > + return -EINVAL; > + > + ret = of_address_to_resource(node, 0, &r); > + if (ret) > + goto err_put_node; > + > + mem_size = resource_size(&r); could you reuse the resource from venus_load_fw by adding r.sart and resource size in venus_core->fw{} structure. > + > + mem_va = memremap(r.start, mem_size, MEMREMAP_WC); > + if (!mem_va) { > + ret = -ENOMEM; > + goto err_put_node; > + } > + > + data = vmalloc(mem_size); > + if (!data) { > + ret = -EINVAL; > + goto err_unmap; > + } > + > + memcpy(data, mem_va, mem_size); > + > + dev_coredumpv(dev, data, mem_size, GFP_KERNEL); > +err_unmap: > + memunmap(mem_va); > +err_put_node: > + of_node_put(node); > + return ret; > +} > static void venus_event_notify(struct venus_core *core, u32 event) > { > struct venus_inst *inst; > @@ -67,6 +111,9 @@ static void venus_sys_error_handler(struct work_struct *work) > > venus_shutdown(core); > > + dev_warn(core->dev, "dumping FW region!\n"); this warn is not needed, please drop it. > + subsystem_dump(core); Are we sure that the dump is always required? > + > pm_runtime_put_sync(core->dev); > > while (core->pmdomains[0] && pm_runtime_active(core->pmdomains[0])) > -- regards, Stan