From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: rfoss@kernel.org, konradybcio@kernel.org, andersson@kernel.org,
krzk+dt@kernel.org, robh@kernel.org,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com
Subject: Re: [PATCH v3 5/6] media: dt-bindings: media: camss: Add qcom,qcm2290-camss binding
Date: Thu, 24 Apr 2025 08:38:54 +0200 [thread overview]
Message-ID: <b1dc0b10-03a2-4605-8837-a1698e8e6a3d@kernel.org> (raw)
In-Reply-To: <d19ce1ba-2b72-4c04-b405-f5a9d3df07e1@linaro.org>
On 22/04/2025 13:59, Bryan O'Donoghue wrote:
> On 22/04/2025 10:15, Krzysztof Kozlowski wrote:
>> On Fri, Apr 18, 2025 at 04:11:46PM GMT, Loic Poulain wrote:
>>> + vdda-csiphy-1p2-supply:
>>
>> Why isn't this named vdd-phy-supply like in every other binding?
>>
>>> + description:
>>> + Phandle to a 1.2V regulator supply to CSI PHYs.
>>> +
>>> + vdda-pll-1p8-supply:
>>
>> Similar question.
>>
>>> + description:
>>> + Phandle to 1.8V regulator supply to CAMSS refclk pll block.
>>
>> Best regards,
>> Krzysztof
>>
>
> In this series we agreed to include the voltage level in the regulator name.
>
> https://lore.kernel.org/linux-arm-msm/20250314-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v6-0-edcb2cfc3122@linaro.org/
So the series there might need fixes as well? The supply name should
match (more or less) real pins and real pins do not have voltage name.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-24 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 14:11 [PATCH v3 0/6] media: qcom: camss: Add qcm2290 support Loic Poulain
2025-04-18 14:11 ` [PATCH v3 1/6] media: qcom: camss: Add support for TFE (Spectra 340) Loic Poulain
2025-04-18 14:11 ` [PATCH v3 2/6] media: qcom: camss: Add CSID 340 support Loic Poulain
2025-04-18 14:11 ` [PATCH v3 3/6] media: qcom: camss: csiphy-3ph: Add CSIPHY 2ph DPHY v2.0.1 init sequence Loic Poulain
2025-04-18 14:11 ` [PATCH v3 4/6] media: qcom: camss: add support for QCM2290 camss Loic Poulain
2025-04-18 14:11 ` [PATCH v3 5/6] media: dt-bindings: media: camss: Add qcom,qcm2290-camss binding Loic Poulain
2025-04-22 9:15 ` Krzysztof Kozlowski
2025-04-22 11:59 ` Bryan O'Donoghue
2025-04-24 6:38 ` Krzysztof Kozlowski [this message]
2025-04-22 16:46 ` Loic Poulain
2025-04-18 14:11 ` [PATCH v3 6/6] arm64: dts: qcom: qcm2290: Add CAMSS node Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1dc0b10-03a2-4605-8837-a1698e8e6a3d@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox