From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51EC17BAF9 for ; Tue, 16 Apr 2024 14:34:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713278098; cv=none; b=pXIeduPeFezNoBYqHOdzbu3bbcCP6b8yLQcp4FbkNF6sQjTLzSMFp4AdHd30bn2c+PRxoTEW7lu16kMGhZBkaAlOVAUMpdDbzYCO/cjb7/oekuHE8EezvHUJrTVaic7G89GVwV4XGo8yVjxTkiYLmQLxDPA5OPWDxZvT7zZUtns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713278098; c=relaxed/simple; bh=9gWEqpeQ44KAT26aG8dQwX9JQ/Rx+NiPE+QCZt7ZX80=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dRFAO0gl/mpg6vm8eG+wEnK7aefanS7Q9Jrbu6KcunqUkuHg8d0AJDRVz8K7YHvAHmnUiWCFYq3+neMMr+bL2JiB+vaFd2zwSx6mFmp/RgrD0D0COCLYpvwXm6gYRoFbeVn1bjFgwsFLflbzQf8fNIgccdJjMdNkULb9A1ZSu6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Aj1AmpYE; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Aj1AmpYE" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2d895e2c6efso57389581fa.0 for ; Tue, 16 Apr 2024 07:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713278093; x=1713882893; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UsftWv75jPp8q+uPwfqAdrYpSmyrP3n9PngY1U3XH1s=; b=Aj1AmpYErLKiIiVuMej+Ahfwd0EQnGloXGdLTPx9s5aDFZnL6zPuVXuf5gqG/U30yZ InctDQSJCGLYsOiimH0jtJfFNvxrR8EtVT8TvVh7OV9572RFoK6LHUXKYsknRNaUKEeP 7lqFSit+aBIC7qfQTgpCoYiDQDkBF0WOk6A/gpJ+d8mKn94l5/5eR3Ydvq0WFUyTKcLn NogyJZ3FMl7tGIEemvzUHi75qEWIb3yQjAB13P1mmUDyq4UytjL3RNBzvGjXk5Svpa5R r/mzF1f3XqY4jqWTsMnCF+gFPCmgKrPSqT0Ob1krIxWkxWdkF9Mii4NWwylFyrEIXC1A mpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713278093; x=1713882893; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UsftWv75jPp8q+uPwfqAdrYpSmyrP3n9PngY1U3XH1s=; b=JH7bpXA2ESgV2uQe8AD0fX1Goy+/1HM0R49FrQT011wpOLOXxJq174eKtEkFqq8HFl mg4sY9cBrlDLb8zQwkaSCkLt/qPvku9NBX0eOCwzvKyejA/sX8qAK61e17u8btVH8kda 47YfCSK7pld5yi+qDi50CQJuuhDhHKtfN905duWxW/RaEmNlsha4jLwPz10gQn7qFpGl VKHhWMRCjLitCA8p8DWTiTp57FYFML1ijP3HLtefhq0revJ0k/zMnkVWQOG4ZaRwlHyB boX1E/EDGG9UT8o1xnHtoth+QQ5NoiQkEL6SyyV/vRCbY9j201P6Zz8MigL81/WaysRE injQ== X-Forwarded-Encrypted: i=1; AJvYcCUQ8BMdsCsO9T32fMsSkVs6B9AtBflmuMLPgKMm3FSwf8Sc0CN4iJD5gfXkEeWoj0v0WIHC7kZmWro3Z0TScAD3Rf/WoC1d2d/57FDJkg== X-Gm-Message-State: AOJu0YwhD3/fRBCmU0l/Jq5t3ai/zAu0GE5KW1/HB/21Dy7Fizft3d6G ajjNOCqKYOBgs/MejG3EDIQmn/XZffQdRxYAXOE6i06Ta922AAl07tZibhX5lsc= X-Google-Smtp-Source: AGHT+IFchFdCnQlrtXB4f/SFQaCb1JAvuZa4jE2HDMoyWfZXlpIWyk3eg9eZ4xr4mPAhjC7hOBDeTA== X-Received: by 2002:a2e:9b49:0:b0:2d8:df61:9c6c with SMTP id o9-20020a2e9b49000000b002d8df619c6cmr8444196ljj.20.1713278093557; Tue, 16 Apr 2024 07:34:53 -0700 (PDT) Received: from [172.30.205.49] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id u12-20020a2e2e0c000000b002d9f87402e3sm1426372lju.51.2024.04.16.07.34.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Apr 2024 07:34:53 -0700 (PDT) Message-ID: Date: Tue, 16 Apr 2024 16:34:52 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] usb: typec: ucsi: glink: use le32 for message data To: Dmitry Baryshkov , Heikki Krogerus , Greg Kroah-Hartman , Neil Armstrong , Bjorn Andersson Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20240416-ucsi-glink-altmode-v1-0-890db00877ac@linaro.org> <20240416-ucsi-glink-altmode-v1-4-890db00877ac@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240416-ucsi-glink-altmode-v1-4-890db00877ac@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/16/24 04:20, Dmitry Baryshkov wrote: > The message structures as transferred by the PMIC_GLINK use le32 for > data encoding. Correct struct accessors to follow the lead of the main > pmic_glink.c driver. > > Fixes: 62b5412b1f4a ("usb: typec: ucsi: add PMIC Glink UCSI driver") > Signed-off-by: Dmitry Baryshkov > --- There are a couple of if (resp->ret_code) occurences, but zero is zero no matter the bit order, so that works out Reviewed-by: Konrad Dybcio Konrad