From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31F16653; Tue, 26 Nov 2024 06:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732603366; cv=none; b=CdsQFj8EX4n+V7KZDNcVH2yGP+GigVBSdRnBmlZVuD4S3hWK4VHIpdGR4EH70d7ziASopHWPO9Z+UWHWU807ovfje+UCq8qS1zXuuyXye+VFZQdmEgjP9wkyhJ1YrulinXGQJEzlCZoPCjD4aryplE8a/qMTKt5KuS2xOMoYltg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732603366; c=relaxed/simple; bh=8ZbNyjVm35zLAUZ9wINtxezmg9NeriQrGO0zeqDP4Ng=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=amhmWYnd1wYXkbKaL1apig1WrnPVEQ6N4pLnTI6NPHLpw62jNy/IIkpjGHouK9ie0SSC6o5nMuYS62jISRBsTRn6X67sBPVW0zn3Vxk+5UrBxjka0XG/7nbyU4vLO2P1E5W1unrnpF2eGb0Pb/zsQ+gpRsvdMnnydMPcjw9Glyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R6tlioGs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R6tlioGs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9A56C4CECF; Tue, 26 Nov 2024 06:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732603365; bh=8ZbNyjVm35zLAUZ9wINtxezmg9NeriQrGO0zeqDP4Ng=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=R6tlioGsDg+5Fkw69WEBUi5xgGOJjHyaz3slojfuLHInMgTaRQs+KmNCFOpGNnS4M NHSjYYeK3CbP07zB7MtBYe1t634Ly6gC7r21GPmHgs32pzP18JfBsFsMG+pWx9Q/Jl Xc+L+XuGZrgi+LBlAHqLRnFD8m8Kv7ISfAAWC5w/b7c8xY17bjmbK65VR0dsYbA4ER 7Ug2H2ZAAzC3f5ile3JzW00d5mM2PlaAuRhGtRiBCXEyZXmjvgo/EXimattc3024lv JlcV4/Mpuqmy3c6o1i5XIIWVzcYXP4e21OTHtr0a3bSGJDqfmxujkZCebl8boH04rg rcubQF0/BL6PQ== Message-ID: Date: Tue, 26 Nov 2024 07:42:33 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: qcom,qcs615-venus: add support for video hardware To: Renjiang Han Cc: Stanimir Varbanov , "Vikash Garodia (QUIC)" , "bryan.odonoghue@linaro.org" , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , "linux-media@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , quic_qiweil@quicinc.com References: <20241125-add-venus-for-qcs615-v3-0-5a376b97a68e@quicinc.com> <20241125-add-venus-for-qcs615-v3-1-5a376b97a68e@quicinc.com> <18cc654b4377463e8783de0b4659a27d@quicinc.com> <474cef98-4644-4838-b07c-950ad7515b73@kernel.org> <8c60696c-df14-4300-8a92-59eb134a96d2@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <8c60696c-df14-4300-8a92-59eb134a96d2@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/11/2024 07:07, Renjiang Han wrote: > > On 11/25/2024 11:55 PM, Krzysztof Kozlowski wrote: >> On 25/11/2024 16:49, Renjiang Han (QUIC) wrote: >>>>> + video-decoder: >>>>> + type: object >>>>> + >>>>> + additionalProperties: false >>>>> + >>>>> + properties: >>>>> + compatible: >>>>> + const: venus-decoder >>>>> + >>>>> + required: >>>>> + - compatible >>>>> + >>>>> + video-encoder: >>>>> + type: object >>>> Both nodes are useless - no resources here, nothing to control. >>>> Do not add nodes just to instantiate Linux drivers. Drop them. >>> Do you mean I should remove video-decoder and video-encoder from here? >> Yes, that's my suggestion. >> >>> If so, do I also need to remove these two nodes from the dtsi file and add >> Yes >> >>> them in the qcs615-ride.dts file? >> Well, no, how would it pass dtbs_check? >> >> Don't add nodes purely for Linux driver instantiation. > OK, I got it. I'll update like this. If video-decoder and video-encoder are > > removed from dtsi file and not added to qcs615-ride.dts file, then the > > video decoder and encoder functions will not be available on the qcs615 > > platform. So I think these two nodes should be added to the > > qcs615-ride.dts file to ensure that the qcs615 platform can enable the > > video decoder and encoder functions. You just repeated the same sentences. Address my comment instead - empty device nodes should not be used just to instantiate Linux device drivers. Best regards, Krzysztof