Re: [PATCH RESEND v3] leds: flash: leds-qcom-flash: limit LED current based on thermal condition

[Fenglin Wu <quic_fenglinw@quicinc.com>]

On 7/5/2024 3:55 PM, Fenglin Wu via B4 Relay wrote:
> From: Fenglin Wu <quic_fenglinw@quicinc.com>
> 
> The flash module has status bits to indicate different thermal
> conditions which are called as OTSTx. For each OTSTx status,
> there is a recommended total flash current for all channels to
> prevent the flash module entering into higher thermal level.
> For example, the total flash current should be limited to 1000mA/500mA
> respectively when the HW reaches the OTST1/OTST2 thermal level.
> 
> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
> ---
> Changes in v3:
> - Fix coding style issues to address review comments in v2.
> - Link to v2: https://lore.kernel.org/r/20240513-qcom_flash_thermal_derating-v2-1-e41a07d0eb83@quicinc.com
> 
> Changes in v2:
> - Update thermal threshold level 2 register definition for mvflash_4ch_regs.
>      Mvflash_4ch module thermal threshold level 2 configuration register
>      offset is 0x78, not succeeding from thermal threshold level 1 register 0x7a.
>      Hence it is not appropriate to use REG_FIELD_ID to define thermal threshold
>      register fileds like mvflash_3ch. Update to use REG_FIELD instead.
> - Link to v1: https://lore.kernel.org/r/20240509-qcom_flash_thermal_derating-v1-1-1d5e68e5d71c@quicinc.com
> ---

Hi Jones,

Can you help to review the change again when you are available?

Fenglin
> 
> Best regards,