From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] soc: qcom: socinfo: Add SoC ID for Nord SA8797P
Date: Tue, 21 Apr 2026 17:37:21 +0200 [thread overview]
Message-ID: <b2c9158f-ebaa-41b0-b471-22413ed5bc2b@kernel.org> (raw)
In-Reply-To: <20260421040231.1256998-3-shengchao.guo@oss.qualcomm.com>
On 21/04/2026 06:02, Shawn Guo wrote:
> From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
>
> Nord is a SoC family from Qualcomm designed as the next generation of
> Lemans series. SA8797P is the automotive variant of Nord, where
> the platform resources such as clocks, regulators, interconnects, etc.
> are managed by firmware through SCMI.
Binding said it, no need to say the same twice. Binding commit is
describing the hardware, not the driver commit. Please look at Git
history for some examples.
With above paragraph dropped:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-21 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 4:02 [PATCH 0/2] Add SoC ID for Nord SA8797P Shawn Guo
2026-04-21 4:02 ` [PATCH 1/2] dt-bindings: arm: qcom,ids: " Shawn Guo
2026-04-21 4:19 ` Jingyi Wang
2026-04-21 14:21 ` Shawn Guo
2026-04-21 15:37 ` Krzysztof Kozlowski
2026-04-21 4:02 ` [PATCH 2/2] soc: qcom: socinfo: " Shawn Guo
2026-04-21 15:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c9158f-ebaa-41b0-b471-22413ed5bc2b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=deepti.jaggi@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox