Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: weifu wu <wwfu06@163.com>,
	andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org
Cc: krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11
Date: Wed, 28 Jan 2026 12:55:39 +0100	[thread overview]
Message-ID: <b3460102-c624-43d3-8cc5-fd2d4b730a9a@oss.qualcomm.com> (raw)
In-Reply-To: <20260121112721.2981491-2-wwfu06@163.com>

On 1/21/26 12:27 PM, weifu wu wrote:
> Add DT binding documentation for Acer Swift SFA14-11 laptop based on Qualcomm X1E78100 SoC.
> 
> This introduces a new compatible string for the Acer Swift SFA14-11 board.
> 
> dt_binding_check and dtbs_check passed without errors
> 
> Signed-off-by: weifu wu <wwfu06@163.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index d48c625d3fc4..3de631667701 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1076,6 +1076,7 @@ properties:
>  
>        - items:
>            - enum:
> +              - acer,swift-sfa14-11
>                - lenovo,thinkpad-t14s-lcd
>                - lenovo,thinkpad-t14s-oled
>            - const: lenovo,thinkpad-t14s

This needs its own hunk, your patch as-is says:

"Acer built the Swift SFA14-11 on top of the Lenovo ThinkPad T14s's
motherboard."

Which I'm sure isn't true

Konrad

  parent reply	other threads:[~2026-01-28 11:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 11:27 [PATCH v3 0/2] arm64: dts: qcom: add Acer Swift SFA14-11 support weifu wu
2026-01-21 11:27 ` [PATCH v3 1/2] dt-bindings: arm: qcom: add Acer Swift SFA14-11 weifu wu
2026-01-21 11:48   ` Krzysztof Kozlowski
2026-01-28 11:55   ` Konrad Dybcio [this message]
2026-01-28 13:19     ` Konrad Dybcio
2026-01-21 11:27 ` [PATCH v3 2/2] arm64: dts: qcom: add Acer Swift SFA14-11 device tree weifu wu
2026-01-21 11:50   ` Krzysztof Kozlowski
2026-01-28 12:25   ` Konrad Dybcio
2026-01-28 14:05     ` wwf
2026-02-03 11:02       ` Konrad Dybcio
2026-02-05 10:13         ` wwf
2026-02-17 15:15           ` Konrad Dybcio
2026-01-21 11:52 ` [PATCH v3 0/2] arm64: dts: qcom: add Acer Swift SFA14-11 support Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3460102-c624-43d3-8cc5-fd2d4b730a9a@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=wwfu06@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox