From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Gaurav Kohli <gkohli@codeaurora.org>, linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, Shiraz Hashim <shashim@codeaurora.org>
Subject: Re: [PATCH v0] nvmem: core: Export nvmem cell info to userspace
Date: Fri, 22 Mar 2019 15:23:48 +0000 [thread overview]
Message-ID: <b356f99c-15ff-06ce-e40b-4bb8b664b6c9@linaro.org> (raw)
In-Reply-To: <1553061201-28894-1-git-send-email-gkohli@codeaurora.org>
On 20/03/2019 05:53, Gaurav Kohli wrote:
> From: Shiraz Hashim <shashim@codeaurora.org>
>
> Existing nvmem framework export full register space
> as nvmem binary, but not exporting child node of nvmem
> which is nvmem cell. Kernel can read the specific cell
> by using nvmem_cell_read but userspace don't have such
> provision.
>
> Add framework to export nvmem cell as well, So
> userspace can use it directly.
>
> Signed-off-by: Shiraz Hashim <shashim@codeaurora.org>
> Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
> Co-developed-by: Gaurav Kohli <gkohli@codeaurora.org>
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
Thankyou for the patch.
Why do you need such provision when the userspace can just get the cell
values using correct offset and size.
This will also bring over head of managing entries dynamically +
confusing userspace abi.
Unless you have a valid reason or usecase I don't see the need for this.
thanks,
srini
next prev parent reply other threads:[~2019-03-22 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 5:53 [PATCH v0] nvmem: core: Export nvmem cell info to userspace Gaurav Kohli
2019-03-22 15:23 ` Srinivas Kandagatla [this message]
2019-03-24 15:25 ` Gaurav Kohli
2019-03-25 10:58 ` Srinivas Kandagatla
2019-03-26 13:14 ` Gaurav Kohli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b356f99c-15ff-06ce-e40b-4bb8b664b6c9@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=gkohli@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shashim@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox