From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68623C76196 for ; Sun, 2 Apr 2023 11:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbjDBL2D (ORCPT ); Sun, 2 Apr 2023 07:28:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbjDBL2C (ORCPT ); Sun, 2 Apr 2023 07:28:02 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CF2E7EC4 for ; Sun, 2 Apr 2023 04:28:01 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id y20so34580893lfj.2 for ; Sun, 02 Apr 2023 04:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680434879; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8dRjeb1n7Wvcw6uGzT8QJh1z7gswxsKnW33SjxwiLi4=; b=LTGvv2ApCNo2eU5PUkM8zq/+mHd6wL+Cvp1AGN4xnd0b4sC4vOyetIGPrbgGaQCGQi cLLrGomHxi7PJRTyl9BgnTP1oU7jBlSy2vSsgz4x7EJ7WlPBeBn4l6fg33Wpn0iyO+vx nqiQwM9YNyfYP5gftfobtSlpDhKGHY1cS+DDsOA9/Z7lpdJjjXRTplq38ta+nX5+B3xt XD9rt+v3VDiI+Y+SyqGus/0M2Faeiaq3c1sjJVm8gkyzqUKdJ9JKHmxK0uCjcto3APfx 4m6/KWfp6a1iD9fBkNQHY1w5c5VAQCP13TsYVc4Gwf3EQesKgcYoW6Yk4EK5BR+5wBMs g0rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680434879; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8dRjeb1n7Wvcw6uGzT8QJh1z7gswxsKnW33SjxwiLi4=; b=qNMISLf6AmlwFimAY+SSfFc/6ZEsrrc6HTKKqkWJCfwg8GvaIGrbQPldmCjR64b7GC 4a2dj6T9q2VrPYCDf4kqQgq5ppBZ7VHZnLy8EjNsy9CikNs6EqkLAf+Cw7uHhFHDf0R3 9e6f+Ax9bnkRtP138k1WEHpHX94T7Xkvt8czM4pmhYHbbCez7sKnp/2Em9ZL/Mlgkz9C 46pdfSCU+BNg3SYWIUjyDh/1YH0JWjoo8kWUHWbM6lvOf5Dm5RarQJ7sPH1Rhpc2Il57 z79zc4bBKHKtI8KY8EZhf7LTbAgsY8k+RsFGaiuNSlXNOQ1X8MN4xMv2Yl+m70qX4xjF MGqw== X-Gm-Message-State: AAQBX9fptha2hb7UrXXV+hazLAhUWhTo6TrMh2uV6eyCoVrui5iVhBTv 9GnOJkDj1y/MRpJLT84EoJABjA== X-Google-Smtp-Source: AKy350bkjJYdW21mqXfNhkBCKfo6mfSqbS6Hv4aapsFlBOMGs2rz+G8zFTST84NIdoN/yaApZnI1dw== X-Received: by 2002:a19:ad45:0:b0:4eb:1495:44ee with SMTP id s5-20020a19ad45000000b004eb149544eemr5587315lfd.48.1680434879673; Sun, 02 Apr 2023 04:27:59 -0700 (PDT) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id i15-20020a056512006f00b004dc4d26c30dsm1250315lfo.63.2023.04.02.04.27.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Apr 2023 04:27:59 -0700 (PDT) Message-ID: Date: Sun, 2 Apr 2023 14:27:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH RFC v2 4/6] drm/msm/dpu: Fix slice_last_group_size calculation Content-Language: en-GB To: Jessica Zhang , freedreno@lists.freedesktop.org Cc: Marijn Suijten , Konrad Dybcio , Daniel Vetter , Rob Clark , Abhinav Kumar , Sean Paul , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org References: <20230329-rfc-msm-dsc-helper-v2-0-3c13ced536b2@quicinc.com> <20230329-rfc-msm-dsc-helper-v2-4-3c13ced536b2@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <20230329-rfc-msm-dsc-helper-v2-4-3c13ced536b2@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 31/03/2023 21:49, Jessica Zhang wrote: > Correct the math for slice_last_group_size so that it matches the > calculations downstream. > > Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") > Signed-off-by: Jessica Zhang > Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > index b952f7d2b7f5..9312a8d7fbd9 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > @@ -56,7 +56,11 @@ static void dpu_hw_dsc_config(struct dpu_hw_dsc *hw_dsc, > if (is_cmd_mode) > initial_lines += 1; > > - slice_last_group_size = 3 - (dsc->slice_width % 3); > + slice_last_group_size = dsc->slice_width % 3; > + > + if (slice_last_group_size == 0) > + slice_last_group_size = 3; Hmm. As I went on checking this against techpack: mod = dsc->slice_width % 3 mod | techpack | old | your_patch 0 | 2 | 3 | 3 1 | 0 | 2 | 1 2 | 1 | 1 | 2 So, obviously neither old nor new code match the calculations of the techpack. If we assume that sde_dsc_helper code is correct (which I have no reasons to doubt), then the proper code should be: slice_last_group_size = (dsc->slice_width + 2) % 3; Could you please doublecheck and adjust. > + > data = (initial_lines << 20); > data |= ((slice_last_group_size - 1) << 18); > /* bpp is 6.4 format, 4 LSBs bits are for fractional part */ > -- With best wishes Dmitry