From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F27C74A5B for ; Thu, 23 Mar 2023 17:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231659AbjCWR11 (ORCPT ); Thu, 23 Mar 2023 13:27:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230132AbjCWR10 (ORCPT ); Thu, 23 Mar 2023 13:27:26 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 201E8F1; Thu, 23 Mar 2023 10:27:25 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DC3CB2F4; Thu, 23 Mar 2023 10:28:08 -0700 (PDT) Received: from [10.57.53.151] (unknown [10.57.53.151]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B25633F766; Thu, 23 Mar 2023 10:27:21 -0700 (PDT) Message-ID: Date: Thu, 23 Mar 2023 17:27:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 08/11] coresight-tpdm: Add nodes to configure pattern match output To: Tao Zhang , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org References: <1679551448-19160-1-git-send-email-quic_taozha@quicinc.com> <1679551448-19160-9-git-send-email-quic_taozha@quicinc.com> From: Suzuki K Poulose In-Reply-To: <1679551448-19160-9-git-send-email-quic_taozha@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 23/03/2023 06:04, Tao Zhang wrote: > Add nodes to configure trigger pattern and trigger pattern mask. > Each DSB subunit TPDM has maximum of n(n<7) XPR registers to > configure trigger pattern match output. Eight 32 bit registers > providing DSB interface trigger output pattern match comparison. > And each DSB subunit TPDM has maximum of m(m<7) XPMR registers to > configure trigger pattern mask match output. Eight 32 bit > registers providing DSB interface trigger output pattern match > mask. > > Signed-off-by: Tao Zhang > --- > .../ABI/testing/sysfs-bus-coresight-devices-tpdm | 24 +++++++ > drivers/hwtracing/coresight/coresight-tpdm.c | 84 ++++++++++++++++++++++ > drivers/hwtracing/coresight/coresight-tpdm.h | 8 +++ > 3 files changed, 116 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > index 094d624..c06374f 100644 > --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm > @@ -71,3 +71,27 @@ Description: > value 1: Start EDCMR register number > value 2: End EDCMR register number > value 3: The value need to be written > + > +What: /sys/bus/coresight/devices//dsb_trig_patt_val > +Date: March 2023 > +KernelVersion 6.3 > +Contact: Jinlong Mao (QUIC) , Tao Zhang (QUIC) > +Description: > + (Write) Set the trigger pattern value of DSB tpdm. > + Read the trigger pattern value of DSB tpdm. > + > + Accepts the following two values. > + value 1: Index number of XPR register > + value 2: The value need to be written minor nit: What values are acceptable ? Otherwise looks fine. Reviewed-by: Suzuki K Poulose