From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexey Minnekhanov <alexeymin@postmarketos.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Craig Tatlor <ctatlor97@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: qcom: gcc-sdm660: Add missing SDCC block resets
Date: Thu, 30 Jan 2025 08:35:56 +0100 [thread overview]
Message-ID: <b44f0dd4-1793-429d-a8c8-0cf23481be2a@kernel.org> (raw)
In-Reply-To: <09d57c27-f287-4ae5-8c78-db39dd9cc820@postmarketos.org>
On 29/01/2025 21:52, Alexey Minnekhanov wrote:
> On 1/29/25 10:06 PM, Krzysztof Kozlowski wrote:
>>
>> No line breaks between tags (see `git log`).
>>
>
> Will fix in v2.
>
>>
>>> include/dt-bindings/clock/qcom,gcc-sdm660.h | 2 ++
>>
>> That's a separate patch. Always.
>>
>
> No big deal, but I've looked at git log and found previous commit
> b538304da785 ("clk: qcom: gcc-sdm660: Add missing modem reset") [1] that
> did similar things, but in a single patch, so I did the same.
>
> Will fix in v2.
Is there DT Ack for that commit? No.
You also marked this commit as fixes, so explain in commit msg
user-observable bug being fixed here.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-01-30 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 17:18 [PATCH 1/2] clk: qcom: gcc-sdm660: Add missing SDCC block resets Alexey Minnekhanov
2025-01-29 17:18 ` [PATCH 2/2] arm64: dts: qcom: sdm630: Add missing resets to mmc blocks Alexey Minnekhanov
2025-01-29 19:06 ` [PATCH 1/2] clk: qcom: gcc-sdm660: Add missing SDCC block resets Krzysztof Kozlowski
2025-01-29 20:52 ` Alexey Minnekhanov
2025-01-30 7:35 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b44f0dd4-1793-429d-a8c8-0cf23481be2a@kernel.org \
--to=krzk@kernel.org \
--cc=alexeymin@postmarketos.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=ctatlor97@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox