Re: [PATCH v3 2/3] media: i2c: ov02c10: Correct power-on sequence and timing

[Hans de Goede <hansg@kernel.org>]

Hi,

On 27-Jan-26 11:40, Hans de Goede wrote:

...

>> @@ -676,27 +685,53 @@ static int ov02c10_power_on(struct device *dev)
>>  	struct ov02c10 *ov02c10 = to_ov02c10(sd);
>>  	int ret;
>>  
>> -	ret = clk_prepare_enable(ov02c10->img_clk);
>> -	if (ret < 0) {
>> -		dev_err(dev, "failed to enable imaging clock: %d", ret);
>> -		return ret;
>> +	if (ov02c10->reset) {
>> +		gpiod_set_value_cansleep(ov02c10->reset, 1);
>> +		usleep_range(10000, 11000);
>>  	}
> 
> Ack for asserting the reset for 10 ms here, that is the only part
> of this patch which seems to actually be useful.

Quick note on this, your commit msg says the datasheet requires 5 ms,
so 10 seems a bit much for the next version please
use a usleep_range() with 5 - 7 ms. Or just use fsleep(5000) which
turns this into a usleep_range() for you.

Regards,

Hans