From: Wesley Cheng <wcheng@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
vinod.koul@linaro.org, Jack Pham <jackp@codeaurora.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sm8150: Add USB and PHY device nodes
Date: Fri, 10 Apr 2020 17:50:08 -0700 [thread overview]
Message-ID: <b54f9190-78c9-5b6a-932c-ad2b7b4444f3@codeaurora.org> (raw)
In-Reply-To: <20200407233848.GN20625@builder.lan>
On 4/7/2020 4:38 PM, Bjorn Andersson wrote:
> On Tue 07 Apr 15:24 PDT 2020, Wesley Cheng wrote:
>
>> From: Jack Pham <jackp@codeaurora.org>
>>
>> Add device nodes for the USB3 controller, QMP SS PHY and
>> SNPS HS PHY.
>>
>
> Thanks for the respin Wesley, and thanks for testing Vinod. Just spotted
> one little details below.
>
>> Signed-off-by: Jack Pham <jackp@codeaurora.org>
>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Tested-by: Vinod Koul <vinod.koul@linaro.org>
>> ---
>
> Please make a habit of documenting what changed since the previous
> version here, below the ---.
>
>> arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 21 ++++++++
>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 92 +++++++++++++++++++++++++++++++++
>> 2 files changed, 113 insertions(+)
> [..]
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> [..]
>> + usb_1_hsphy: phy@88e2000 {
>> + compatible = "qcom,usb-snps-hs-7nm-phy",
>> + "qcom,sm8150-usb-hs-phy";
> [..]
>> + usb_1: usb@a6f8800 {
>> + compatible = "qcom,sdm845-dwc3", "qcom,dwc3";
>
> The first cell here should be qcom,sm8150-dwc3. The Linux driver will
> "fall through" and match on the less specific "qcom,dwc3", but if we in
> the future realize that we have sm8150 specific behavior/quirks we can
> make the driver match on the more specific one to implement this.
>
> And similarly the order of the compatibles in &usb_1_hsphy should be
> reversed as well.
>
> Regards,
> Bjorn
>
Hi Bjorn,
Thanks for the input. Will do that and re-submit v4.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-04-11 0:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 22:24 [PATCH v3 0/2] Enable SS/HS USB support on SM8150 Wesley Cheng
2020-04-07 22:24 ` [PATCH v3 1/2] clk: qcom: gcc: Add USB3 PIPE clock and GDSC for SM8150 Wesley Cheng
2020-04-07 22:24 ` [PATCH v3 2/2] arm64: dts: qcom: sm8150: Add USB and PHY device nodes Wesley Cheng
2020-04-07 23:38 ` Bjorn Andersson
2020-04-11 0:50 ` Wesley Cheng [this message]
2020-04-08 4:30 ` [PATCH v3 0/2] Enable SS/HS USB support on SM8150 Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b54f9190-78c9-5b6a-932c-ad2b7b4444f3@codeaurora.org \
--to=wcheng@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).