From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Johan Hovold <johan@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: Disconnect interrupt generation for QC targets when role switch is enabled
Date: Sun, 8 Oct 2023 20:09:00 +0530 [thread overview]
Message-ID: <b5bb3d14-5ffc-44f4-99bc-aa2c97e198cb@quicinc.com> (raw)
In-Reply-To: <0bd1fddf-a05f-69a0-b4b0-1b2378bc0c58@quicinc.com>
On 8/29/2023 6:42 PM, Krishna Kurapati PSSNV wrote:
>
>
> On 8/16/2023 10:24 PM, Manivannan Sadhasivam wrote:
>>
>> Since you have quoted my series, I'd like to get clarification on one
>> issue I'm
>> seeing. When resuming from runtime suspend in host mode, dwc3-qcom
>> driver gets
>> the wakeup event and it resumes the xhci driver. But the XHCI IRQs are
>> received
>> after some delay. Due to this, xhci driver doesn't resume the device,
>> instead,
>> all the drivers (dwc3-qcom, dwc3-core, xhci) went to runtime suspend
>> again.
>>
>> But once the XHCI IRQs are received, dwc3-qcom gets the wakeup event
>> and this
>> time, xhci driver resumes the device.
>>
>> This is the reason why I added the autosuspend delay of 200ms to allow
>> the xhci
>> driver to wait for IRQs before going to runtime suspend.
>>
>> Can you clarify why there is a delay in receiving XHCI IRQs?
>>
>
> Hi Manivannan,
>
> Apologies for the delay in response. Can you help check if the phy
> clocks are ON at the instant we see that the xhci irq not coming up. I
> got to know that after resume, the clocks need to be ON for phy for it
> to signal the controller which would then generate the xhci irq. I also
> see that in resume_irq call in dwc3-qcom, we call runtime_resume for
> xhci->dev, probably causing it to resume before dwc3->dev (I might be
> wrong though). Can you confirm if the clocks for phy and GDSC for
> controller are ON when this issue is seen. Also can you let know how
> much time its taking for the xhci irq to be generated after resume.
>
Hi Manivannan,
Sorry for reviving an old thread. Can you help check whether
autosuspend is being triggered by pm framework before run_stop bit is
cleared as part of xhci_suspend in your case ?
I am trying to repro the issue, but I am seeing a different error, "host
controller error"
Regards,
Krishna,
next prev parent reply other threads:[~2023-10-08 14:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 11:51 Disconnect interrupt generation for QC targets when role switch is enabled Krishna Kurapati PSSNV
2023-08-16 16:54 ` Manivannan Sadhasivam
2023-08-29 13:12 ` Krishna Kurapati PSSNV
2023-10-08 14:39 ` Krishna Kurapati PSSNV [this message]
2023-08-28 17:20 ` Bjorn Andersson
2023-08-30 4:27 ` Krishna Kurapati PSSNV
2023-09-06 15:52 ` Pavan Kondeti
2023-09-13 3:34 ` Krishna Kurapati PSSNV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5bb3d14-5ffc-44f4-99bc-aa2c97e198cb@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox