From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5E2537B3EC for ; Thu, 5 Mar 2026 10:01:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772704886; cv=none; b=m3DDfvoWvkjhMUOiDlml3A+Ryg5lUHl243SUqyD2Ce1+XS4EQGPRAaCjaEMUuT/GISFLRxyRrOn2CU0oECLXSVqS+XYvutlWQargvLTMKV5TyMj6SjbWeIHppRjjYSGIKdPr3EC7fiMR3JonGFmYObugvFTYv3/HrV+JeX2iIoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772704886; c=relaxed/simple; bh=wDLglFX9PA5cLOwAenyb1mY6R8BcHsFLh5owe0fFwrM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Mn83xqgKMck2QQAHVwdaCd7Mp4NJ02dECASoXeoPF+bSsTJanKghS0l4iHWTeLkkq9Dy2EQK216zQZ2xfb0QYcwhTqjrRrdWTQeNwTFevAbaTEAAalhT3j0JqsdO8lg9Q7n1mh7im6jaxjO2PEbFGXOeWHhqCW/r5QdkXLSjnlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EcmSfzwj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cJQpuFvm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EcmSfzwj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cJQpuFvm" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62592KCK3160439 for ; Thu, 5 Mar 2026 10:01:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gHxqPY9FPzuJxFhy7ETC/+90zdEbUqq3ZKx36kD9wGI=; b=EcmSfzwjRjV3Sas2 SkjRmkUDYgIihfasYP/Mja6WBtDmZjnUYeW2YxgNXjOS3V9yoy7Ie5T4wJU30/z5 uckV7Wf8lPmlpFOJwP+jr6FmN7RBrUz8mwMlfc+tlpcMUNrLxPzukypOMLmbyv9a SC99ivvboChdVAghDfp2NkDY4q3XnK+1yDXRm6+QsWcNWZI2fuVntGLHl4r7EHty OASjdEalIqJ+dQDpF6RIquDIZ0Oqjm6Iu3A87CqHE0QCJTkwhpu06m4CTKafPbNd 0Ub5pWSnutdkASWoigVnh7LapJyzmJwsuq3SC/WPnHwk704A6JZSM/2zRGm1zmCY wFaU2Q== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpjh5v60h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 10:01:24 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8954b9b5da7so61649806d6.2 for ; Thu, 05 Mar 2026 02:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772704884; x=1773309684; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gHxqPY9FPzuJxFhy7ETC/+90zdEbUqq3ZKx36kD9wGI=; b=cJQpuFvmJ4slW7iwnVjgxhW8D+NFkhS1Yp+AimT/0w0qvQrXrqLKY2vbG3yYxascds Xvp8H4bEAhhHNG1Z2x/JxZPfpxIYfmRlLtEbxKCmRw9cQkHpPJMIXGwqU/s1swhj7o29 UrMNbYR+rIpJJdwZ7WsSfeHrFxkJ3nYPLEoiEA1c3/7xE6a5xwPJbKq9vlG93+wnOIEy hIwD4bZuUHw1jCrayu71ShO3FYDlCtf3o/M63m2F1zIwsNCx1bzxGi1y+f6/4jKJ5tOx rs3+UDhaFD8crfLwRF9OKpjEtDPmEd+YmtPdZqnD+5DApQva+LbGRyo2GUjArIE6QMb5 einQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772704884; x=1773309684; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gHxqPY9FPzuJxFhy7ETC/+90zdEbUqq3ZKx36kD9wGI=; b=xJzIZ8lfeoIWgImbgSni8xpbmvoDxoUO9qdt88sViKsWDcuWEqov9RSTEt0/I6g8il f/F6N3R3b1tMeuqC1jmTYrItq8SpzGP0amhg7PU19gclf296wsEK2mAghZYMx2JWKZ7n Zt7wnmXLl6yzseaYBuYPcaIZGuDpySbxXuV066YCdgCXAaDk7Jt2iwRVTfEVxLwmg0ji wzH+TIncU3zDj6BhrijbhDh8AhPIztAWDTaH5Qow/42VJ4jz4bKFfff1xjK5nFCoYeya POGHQuoepec1dwY4ejtV1pGxw8jf4juaI7ogdujmDgsFm97z6hQOv7EemTjFqDMtmMY7 TQlw== X-Forwarded-Encrypted: i=1; AJvYcCXQQwsazTinky3lxRehsFs8PaRE0MERzgoq2mJpPnaxPdC0vhySogLvK0eFis6lA5J22OEs1HyKBllMXTDc@vger.kernel.org X-Gm-Message-State: AOJu0Yyh1ySHbNz/ePXhqWXp1bEsCDekqvYYcfgiyMcii9klYKCuHd+5 TEGaqSrN0iVrR/kWXnG+bwd/IIHZ7NxBFwGcsS1PrkrwXh2XqCcnOQFYFZim/KVWWjMCaxZUUJW tWQ0RwL1vt1RpHSrdmX3qlLHjx772azsDya55gCtpYPX9Iuj/LBfR9KtdRWAUC/0J1Z/n X-Gm-Gg: ATEYQzza3H1JH1rWLk0AP5z3b+7Ng+sFFV6jlx+mI8JGep6Ug1a5dUWCXPhakvRMiu3 4xcoTupkyzyTrLpgHyq7/hPPhclBQW+66wxg9z7nN2KMtmbMTKIx9H3ngfoL1XdKlXxXA5fXCSP BK3BLw8X0N9DaB9tLJFUN8Q9Kfuzfd/+pS1dNEsX3dTMi377vbze01GVX3PTCIEt1NiZHipboWs NZ3JeAE2JYNWWXjm6Y7x24x1xKtKDOE8CaVI+DZZ2bSG/lGdSW+jgFeMZ19Lzq3aRhfaPHHJybj ESL2a2P300wS436n2mQn+nQO++dONqOYUDtKPTzMlbCEhcAwkW9Ywz4W3fbK0A3xEBvKJCgrDak dstBcjH6CcGCc7NLKGP6l9Dc56TIm+vNkIacXITq8pB7/R4mxZPvEAN/J0mLSwHyVe41e0m+UAj 0laVA= X-Received: by 2002:a05:6214:6004:b0:89a:b62:301c with SMTP id 6a1803df08f44-89a199a57d3mr50520336d6.1.1772704884056; Thu, 05 Mar 2026 02:01:24 -0800 (PST) X-Received: by 2002:a05:6214:6004:b0:89a:b62:301c with SMTP id 6a1803df08f44-89a199a57d3mr50520036d6.1.1772704883594; Thu, 05 Mar 2026 02:01:23 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b941461b52esm37668466b.29.2026.03.05.02.01.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2026 02:01:22 -0800 (PST) Message-ID: Date: Thu, 5 Mar 2026 11:01:20 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] arm64: dts: qcom: qcs6490-rubikpi3: Add audio support To: Hongyang Zhao , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Drake , Katsuhiro Suzuki , Matteo Martelli , Binbin Zhou , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Bjorn Andersson , Konrad Dybcio Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Roger Shimizu References: <20260305-rubikpi-next-20260304-v1-0-327595a4528a@thundersoft.com> <20260305-rubikpi-next-20260304-v1-6-327595a4528a@thundersoft.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260305-rubikpi-next-20260304-v1-6-327595a4528a@thundersoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 9jat18MuntyfvngmVyuLpPUbHBhTr0jC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDA4MCBTYWx0ZWRfX9is1BkBUzC0H dWDBGAXW2L3PpBWiApm7DjV/nlR467E1bsnqN7CodgF7zIjr0Cnvls/nU4RBThIb/7H3XryqoQB aIh0us/5HKfxvNuFmjB4sYFAHHc/Ty/xWZsR7UesLEdtdD7u/a1SOApRlegGySsiJcfbwjqB3G7 kXbV6gCI++PFKv89ZfrWNZIVqM5eHCFgAlJAoDMeMST2f9irrfrCUfMLESRKDMRQiHzrS/FUdQD Ww9iYsdEhll3v8lbI9IAk8u/9ipsZFsBMCMW6e3B+l+54M9fLOq7bXnVCs6XXBx0QjD9J4nPXjj NSyyL4PMFnQ84TELnr50UcaoYyG3u0P7xLDxCGz3fIPGeonaEeDBRhNbK0Sg5Vo2VGN+G30cp2n Y+fAKkXCPfJTMXMbPpQedRXrItlKR7+AyhsaZAShNL4ifSqrsvLivPVfeIIQEaQ3eSzkWz6t+IN YQffuVEybvj0lR1tsHg== X-Authority-Analysis: v=2.4 cv=JK82csKb c=1 sm=1 tr=0 ts=69a95474 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=Wdb1h0LgAAAA:8 a=2bRy7qri546BrDWxAXsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=j5gyrzqu0rbr1vhfHjzO:22 X-Proofpoint-ORIG-GUID: 9jat18MuntyfvngmVyuLpPUbHBhTr0jC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_02,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050080 On 3/5/26 6:47 AM, Hongyang Zhao wrote: > Add audio support for the Thundercomm RubikPi3 board: > - Enable AudioReach via qcs6490-audioreach.dtsi > - Add ES8316 codec on I2C0 with MCLK from LPASS PRM and jack detection > - Add fixed 3.3V regulator for ES8316 power supply > - Add MI2S playback/capture dai-links for ES8316 > - Add HDMI audio via LT9611 bridge on quaternary MI2S > - Add SPDIF TX/RX on tertiary MI2S exposed at the board 40‑pin header > - Add LPASS pin configurations for quaternary MI2S and LPI I2S1 > > Signed-off-by: Hongyang Zhao > --- [...] > + spdif_tx: spdif-tx { > + compatible = "linux,spdif-dit"; > + #sound-dai-cells = <0>; > + }; > + > + spdif_rx: spdif-rx { 'r' < 't', please swap them [...] > + mi2s-playback-dai-link { > + link-name = "MI2S-LPAIF-RX-PRIMARY"; > + cpu { > + sound-dai = <&q6apmbedai PRIMARY_MI2S_RX>; > + }; > + codec { > + sound-dai = <&es8316>; > + }; 'co'dec < 'cp'u, please reshuffle and leave a \n between the property (link-name) and the following subnode as well as between the individual subnodes (but not after the last one) [...] > +&lpass_tlmm { > + lpass_qua_mi2s_sclk: qua-mi2s-sclk-state { > + pins = "gpio0"; > + function = "qua_mi2s_sclk"; > + drive-strength = <8>; > + bias-disable; > + output-high; > + }; > + > + lpass_qua_mi2s_ws: qua-mi2s-ws-state { > + pins = "gpio1"; > + function = "qua_mi2s_ws"; > + drive-strength = <8>; > + output-high; > + }; > + > + lpass_qua_mi2s_data0: qua-mi2s-data0-state { > + pins = "gpio2"; > + function = "qua_mi2s_data"; > + drive-strength = <8>; > + bias-disable; > + }; > + > + lpass_qua_mi2s_data1: qua-mi2s-data1-state { > + pins = "gpio3"; > + function = "qua_mi2s_data"; > + drive-strength = <8>; > + bias-disable; > + }; Because they have identical properties, you can squash GPIOs 2-4 into 'lpass_qua_mi2s_data' with: gpios = "gpio2", "gpio3", "gpio4"; Konrad