From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84BAA36213D for ; Fri, 16 Jan 2026 11:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768563046; cv=none; b=TWD4tKlAfUL0bDcJWmaOGmpjonbO9gYsRiAIY2s1bG7yYzAhAlOm7nQd4Pfxyh5QZzTM/rG47TVlY3fE+eK9UxNpjiwj5otvkw2+CkXw3YCIn1F2K/IHFYbODTvrAe58yrnL7gRf1T/PM90VidaGMGUa/m5a0A0vGGWMbY7o+9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768563046; c=relaxed/simple; bh=3KWe5LSI4X1XZHcAQp2ZWEXIf8v28A93JsZ4sD5N3Wc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gIPRGN3bzail3cQdaqFu54MrCHcXcVUXMaKJwCptOsLNCaGbtDmtJscJTJcbHpunbM7KGFtWpYZGtRYpHHUNplPXvb1mlhdSAooLWZpQjoH2GIy02ZDEXZCtvu4R5p9LaoaFzChN7Q/Vr3VM4xfXyU1cTdVumgyuqhF6aukYG30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A6lb1t9A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XBr3fL0a; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A6lb1t9A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XBr3fL0a" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60G86la73714357 for ; Fri, 16 Jan 2026 11:30:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zq3RVbQZJj7c+ynI8CHvPgZnXJ5YtDGCWtBK2S8I66I=; b=A6lb1t9AldQMwh3u 62WxHuibRxMYWl2H22iAgpO07DaI1MwDZRcJFo9PwBW9VweYIvAkPKvKzVtcmUj4 fUqQOMi+QhP5oFb3t7qj05Rc/TkMG4H5IlbZpSZvQEA9TKvD6q8aeCmbkRcbg2bg KCWUD6CpBM36Z7MtTD5+vB6b0miVL640Afs82F7IFz7gqqxUtWcdVClNHnRe6CAc QiHD6Iv3KHdgyUjrZALUicP4yvXt26PJxlEkh91Z/9+/+qrCkpysgm94kUZvGBO3 pulaOBuvFXaWSoZ+LDunMWTxAz/Xmuq2yj/yj7JmIGaELN+ci60JSWpAKI7FV3r9 0z5GLQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bq96p9y34-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 16 Jan 2026 11:30:39 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-81f53036ac9so1678161b3a.3 for ; Fri, 16 Jan 2026 03:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768563039; x=1769167839; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zq3RVbQZJj7c+ynI8CHvPgZnXJ5YtDGCWtBK2S8I66I=; b=XBr3fL0aauI/SUuTQFITUya51MNdWeByH92qmXK0BzEX9yGl1cobSNrSf/tjCdwo/Y KIfN1lBagWvu3KYP/IXt+9/CCXf0vje2x+xEJfGp5SBwdxjBPWhw9AUG5HT0rPRFQD2i CUrYQXlqamkkuZ1pPE4IAtb0yM/1rv76qm5BT+3NLSdMKKdoIU7hPjcScD8Bn/MgIehT FHEjNkyc11ZmBVycnREGJGcAS3XgGPjEpLABz9+nsoRrKcq2KBO9hkUhXSqh3S22uT5F 2lpoWiVJjNcC0LNFGYj0hLirmqzhLVJlFlAv87jKgztRMKWV8eeq8BbwKp3Ey8YR4sI8 Biew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768563039; x=1769167839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zq3RVbQZJj7c+ynI8CHvPgZnXJ5YtDGCWtBK2S8I66I=; b=wJBxuLmpQUp+R+CzUrhDFHHik5nT9CMRb6cLl0BVroK4mkQBp6ClPyCX5fDjpK9Cpc pCJjh/GxeXn4XpnHy6fkq3AJRpKA8q1oWRArJfn026vXTE66SXHhAhwHvLtmajDoSsIS FERv5mK9rpJx4xwSB5FLKHNbgUNAodcUkUTXAwBH6KT5m8RuNIoeIug1AiL8ukfiqS5v 6Tl54gF0E7/a+CmMZm13tLyVVGRNmfTo1fe7YG0j2Pjj0NFJr4HD00TEtEGUbToFfdnx 4KjgWSucUIXKtk00dcV4jxHoIjk4XTqKWFRkGy1GVGEacPYDdA8zcuZPFki6LN6ZX6rF ju2Q== X-Forwarded-Encrypted: i=1; AJvYcCWw2n4QEoaguN7+9GfYHH4L1kl5X/7BoIU7P9qs0HZkmF2XQ/addg1+ApLwcKeWE5PLTabeHEBEY/nyV4j3@vger.kernel.org X-Gm-Message-State: AOJu0Yx1mL+0+inqUe3w8Soc7aHrXC9itdcl9IH694xoEx69aQvaV7RU l8OtZtnQ9tPzDiKbU1UCQNkf7CQ3k1JJFCNhpQh4pjH7cFHuO0YpYRZFiSdbMYn0IbsQTnBGH+I 8P1Uy4nMo8VNDmF6fOa+M0Itcet3R5UF4U5Ln48XQDpV3pTa0toCP2RcQ1iE3YpJXDd1x X-Gm-Gg: AY/fxX4OHB+a5nuHOv8sfdevQPAgTdoc1b7KX6zdp/MJfMOyoNLpNZcV0lHiPho3YmA tvolOBEARtPbEqgmqPWWPiQNMP9fvfoWxooCf2c+hLkoapqMlTt6hNSox5K5ZZGx5o8EtjhOPc4 LRFVRwjQi9L71Slu1RK1vNvznzdmiKW8G93qBlDqwzZn7pNkJGd6r1UmAh8z8A8CVPwpjx1OYSY xrGrtns84++R8tOF44032ITfb0ibJUoNI25VYwrHR/LpWWED+LZsBjtKRRDIq021EDw5br4N8my LlgfKgrP5fpEqP/hyA2FGbh0+9bRHYO9b5Rvp5EGS674T0d8DNghOGqGZUdW07JtXJxc59nNyWU GsiJbBGSlwJrWGJ9Ack90SMz5eUnExGlM0OIclmqwgg== X-Received: by 2002:a05:6a00:4097:b0:81f:3d32:fe53 with SMTP id d2e1a72fcca58-81fa01eefb3mr2523502b3a.32.1768563039003; Fri, 16 Jan 2026 03:30:39 -0800 (PST) X-Received: by 2002:a05:6a00:4097:b0:81f:3d32:fe53 with SMTP id d2e1a72fcca58-81fa01eefb3mr2523475b3a.32.1768563038517; Fri, 16 Jan 2026 03:30:38 -0800 (PST) Received: from [10.0.0.3] ([106.222.229.125]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa108c275sm1892989b3a.2.2026.01.16.03.30.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jan 2026 03:30:38 -0800 (PST) Message-ID: Date: Fri, 16 Jan 2026 17:00:33 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 6/6] media: iris: Introduce vpu ops for vpu4 with necessary hooks Content-Language: en-US To: Krzysztof Kozlowski , Vikash Garodia , Bryan O'Donoghue Cc: Abhinav Kumar , Rob Herring , Conor Dooley , Konrad Dybcio , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy , Mauro Carvalho Chehab , Philipp Zabel References: <20251210-knp_video-v4-0-8d11d840358a@oss.qualcomm.com> <20251210-knp_video-v4-6-8d11d840358a@oss.qualcomm.com> <54b29b03-4166-60d9-d553-d0e655749da4@oss.qualcomm.com> <98481299-4db3-41f3-a974-d9d0075d92e0@kernel.org> From: Dikshita Agarwal In-Reply-To: <98481299-4db3-41f3-a974-d9d0075d92e0@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE2MDA4MyBTYWx0ZWRfXz/j8lxuTpwg7 XlaE9ni3yC7xwW6OUrxB1ROXG/x0iVe4Rz5E9tdJTeM9F4UlEiB8ZmeauUYBx6EaVx6A6CXprUj YxBOIc+Fr9E/WBWR2kXWzQMGzg2glopoA7LcV0IIUN9ePPgz8MR40mcMXOcmd7Um4NFz8t3Flze juEcFmQfCCByufYSmRSJH3+xvS7g3U5FoRH8dr9eWkqQaojmqWvMqH880SpDOp7BmVLUz2Ol7oW gEn8z5Y4XqZ8PkB41wjQjeF8pyITimDKqn7YzqVKtoPGTli8M+VjpnajzWAkHSPPJBEUyh2feZZ is8AFVMGNd9GRXtT/PzwHF+72KeX2ID2GKCUNjumKBWT4sxHa3MbnukflTC8/0dyc5w0Jn1yTBV rLptxaS2SUdJELH7kAEBM4aryhENn180di3Ep9zvd1PPV+iB8bjUb/spPoloN6Qv3mc6khLuFjZ 68gv7tl6B5fXe+4YzuQ== X-Authority-Analysis: v=2.4 cv=M7ZA6iws c=1 sm=1 tr=0 ts=696a215f cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=blWSk0AuXjsE0o78ys1YMg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=uV_JhIySkRhv6rPy8r0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: OBflDp0ykiG4MxWVTOnxv_TUMMlwo4FP X-Proofpoint-ORIG-GUID: OBflDp0ykiG4MxWVTOnxv_TUMMlwo4FP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601160083 On 1/16/2026 4:16 PM, Krzysztof Kozlowski wrote: > On 16/01/2026 10:51, Dikshita Agarwal wrote: >> >> >> On 12/10/2025 6:06 PM, Vikash Garodia wrote: >>> Add power sequence for vpu4 by reusing from previous generation wherever >>> possible. Hook up vpu4 op with vpu4 specific implemtation or resue from >>> earlier generation wherever feasible, like clock calculation in this >>> case. >>> >>> Co-developed-by: Vishnu Reddy >>> Signed-off-by: Vishnu Reddy >>> Signed-off-by: Vikash Garodia >>> --- >>> drivers/media/platform/qcom/iris/Makefile | 1 + >>> .../platform/qcom/iris/iris_platform_common.h | 7 + >>> drivers/media/platform/qcom/iris/iris_vpu4x.c | 369 +++++++++++++++++++++ >>> drivers/media/platform/qcom/iris/iris_vpu_common.h | 1 + >>> 4 files changed, 378 insertions(+) >>> >> >> Reviewed-by: Dikshita Agarwal > > > Thank you for reviewing this code. I would like to point that it took > one month for Qualcomm to review this Qualcomm patch and in the same > time Vikash is sending emails (more than one!) that Bryan does not > review that fast as expected. > > I do not find it acceptable approach to harass community reviewers that > way. Even if you do it internally, not on the lists. > > I think this review timeline is final argument for Vikash to stop > pushing such narratives and complains, because your review is expected > to be BEFORE the maintainer upper in the upstream flow. Since these changes were posted by Vikash, who is a co‑maintainer of this driver, I initially waited for reviews from other community members before adding my own tags. We did receive review comments on most of the patches, and I intentionally held back my Reviewed-by tags to allow space for broader feedback. Now that the series has been on the mailing list for about a month without any remaining open comments, I have gone ahead and reviewed the patches, Since The changes look good to me and are ready for this merge cycle. Thanks, Dikshita > > Best regards, > Krzysztof