From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814F6C433EF for ; Tue, 12 Apr 2022 21:29:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbiDLVcN (ORCPT ); Tue, 12 Apr 2022 17:32:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbiDLVcL (ORCPT ); Tue, 12 Apr 2022 17:32:11 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A9C1E2F73 for ; Tue, 12 Apr 2022 14:10:44 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id e10so13185055qka.6 for ; Tue, 12 Apr 2022 14:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gBhTpRFFi4S1YoI6Y47NqVUBm/Z+66ScwXGZSk0rfic=; b=T7Sy6FLDrgLsr08CJMXwUmg3ph+n2SbtlANeDVJRGcYPLZPNFdqkGA3rd9EyBtlS3H kTjnzK8J7gmq/Ix5hk869IWHjRfyAZapgFeo9WcQo6acOPkngS7ZgD606xHdWRwdkcf4 uCNDsXroeiGCJ2dnoQVzb34/K2VNl7m6HbgnUp42Td7ihjuVDiePRgyor7tcwAF0jphx dTPNgA/R3nPsTcwHOh8eDEn9xpE1Mq90riz3Mr6D8Z7h12iUd2IXjDQeAooIdIWVePAB qgC8WMTKShtEFXeXyQDjMUSArChIukeGYjH3EdJ1+FacKEyrgQ1FlRi6Ir+VmO/dOMBJ H7gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gBhTpRFFi4S1YoI6Y47NqVUBm/Z+66ScwXGZSk0rfic=; b=4L7EAZ5I/njR7LCiSTxCR9fvujv8GoigpQrnu8gLF1eXnS1MeuOIJZ/uz9ehg4V4jT If7iMv7zkCS00Qybms8kmMXgTD+GhignXixzGOQz7s5eooaYEZdsD4r3XTb0Xg4wXqPA 3MChp3gpWAOqBWqBukPVnHy1Fg6zAlmn9GP+ydrw1ZslS0jOl80FO1i9H6kOEIfXwje/ yIz1MQ0knWO/6LIXAJwhlzg3UMYyvvYFuQ6f/Q5jfeb7IM2FKiGMSoDys2q2s7cd8GMp HDImH07ZjffX7iGXFYqJyPg1aKX5wiAoTEzVnj5YLIOIhMx1bJr+dgO4Q8jcVG24Emh7 AnXw== X-Gm-Message-State: AOAM530vTFz+yHunNxXGxyAZQ32q7tXlYshwE9dA66/44Rd22rck3B3z FsmGuo6DVwaAIoMVh6FFcj16xg== X-Google-Smtp-Source: ABdhPJxG82CB33uGk+QRkThCYGAsp4gaOqXjPDvytyFIgAT/f1JvMa50XJo0MGciBKEXLs71MyqZMA== X-Received: by 2002:a05:620a:4310:b0:67e:8460:5a10 with SMTP id u16-20020a05620a431000b0067e84605a10mr4475122qko.636.1649797633718; Tue, 12 Apr 2022 14:07:13 -0700 (PDT) Received: from [192.168.0.189] (modemcable134.222-177-173.mc.videotron.ca. [173.177.222.134]) by smtp.gmail.com with ESMTPSA id t10-20020a05620a034a00b0069c06c95bf7sm6104251qkm.14.2022.04.12.14.07.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Apr 2022 14:07:13 -0700 (PDT) Subject: Re: [PATCH] arm64: dts: qcom: sm8450: delete incorrect ufs interconnect fields To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , Krzysztof Kozlowski , Vinod Koul , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20220407172145.31903-1-jonathan@marek.ca> From: Jonathan Marek Message-ID: Date: Tue, 12 Apr 2022 17:07:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 4/12/22 4:51 PM, Bjorn Andersson wrote: > On Thu 07 Apr 12:21 CDT 2022, Jonathan Marek wrote: > >> Upstream sm8450.dtsi has #interconnect-cells = <2>; so these are wrong. >> Ignored and undocumented with upstream UFS driver so delete for now. >> > > Just to clarify, the binding do document interconnects and the property > should be there in the end. v1 (why isn't this marked v2?) was correct. > > What I asked for was a statement on why it should be picked up for > v5.18-rc (as Dmitry requested). > This isn't a v2, I sent this without seeing there was already patch for the same "problem". A reason for picking it up is that if you have a patch adding the interconnect support to the UFS driver in your tree, the incorrect dts will prevent it from probing (so the 5.18-rc1 dts could fail with newer kernel eventually, not sure if upstream cares about that?) > Regards, > Bjorn > >> Fixes: aa2d0bf04a3c ("arm64: dts: qcom: sm8450: add interconnect nodes") >> Signed-off-by: Jonathan Marek >> --- >> arch/arm64/boot/dts/qcom/sm8450.dtsi | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> index 2c18e1ef9e82d..90cdbec3cac99 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> @@ -1663,9 +1663,6 @@ ufs_mem_hc: ufshc@1d84000 { >> >> iommus = <&apps_smmu 0xe0 0x0>; >> >> - interconnects = <&aggre1_noc MASTER_UFS_MEM &mc_virt SLAVE_EBI1>, >> - <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_UFS_MEM_CFG>; >> - interconnect-names = "ufs-ddr", "cpu-ufs"; >> clock-names = >> "core_clk", >> "bus_aggr_clk", >> -- >> 2.26.1 >>