linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Caleb Connolly <caleb.connolly@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>, Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
Date: Wed, 21 Sep 2022 19:05:56 +0100	[thread overview]
Message-ID: <b7551b18-887a-c895-b347-776bb537ae9f@linaro.org> (raw)
In-Reply-To: <CN1UV8GZPKW8.3KT1X7WYEM4K5@otso>



On 21/09/2022 07:12, Luca Weiss wrote:
> Hi Lee, hi Caleb
> 
> On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote:
>> On Thu, 15 Sep 2022, Luca Weiss wrote:
>>
>>> There are some IDs that are written in uppercase. For consistency
>>> convert them to lowercase.
>>>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>> ---
>>> Changes since v2:
>>> * Split out to separate patch
>>>
>>>   include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> These aren't MFD patches.  Please reword the subject.
> 
> Do you have any suggestion what subject to use then? The most I can
> think of is "soc: qcom: " which is sometimes used for other files in
> this include directory.
> I've used the current subject because the previous two patches touching
> this file had this subject also.

This file just contains platform data which used to be in the qcom SPMI
PMIC driver. In hindsight, maybe it would have been better suited in
include/linux/mfd but I don't think it matters too much. I guess it makes
sense to follow convention for the directory and treat it like the other
platform headers, maybe something like:

soc: qcom: spmi-pmic: convert hex numbers to lowercase
> 
> Regards
> Luca
> 
>>
>> -- 
>> DEPRECATED: Please use lee@kernel.org
> 

-- 
Kind Regards,
Caleb (they/them)

  reply	other threads:[~2022-09-21 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 11:35 [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Luca Weiss
2022-09-15 11:35 ` [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs Luca Weiss
2022-09-15 14:52   ` Dmitry Baryshkov
2022-09-19 11:34   ` Caleb Connolly
2022-09-15 14:46 ` [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Dmitry Baryshkov
2022-09-19 11:35 ` Caleb Connolly
2022-09-20  7:50 ` Lee Jones
2022-09-21  6:12   ` Luca Weiss
2022-09-21 18:05     ` Caleb Connolly [this message]
2022-09-22 10:20       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7551b18-887a-c895-b347-776bb537ae9f@linaro.org \
    --to=caleb.connolly@linaro.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).