From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E8502FFDEA for ; Sat, 6 Dec 2025 16:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765037542; cv=none; b=s/z17Lxije6odnq9JkJog/SIbc32Bq/koxSl/crIUXtmejBciIa0jyPtqOtkka+flT/EJeXjmz8fjyrfhXjegje9UnbyCtbj+NdvIyvQe8MGTKr3p4kMwTy6LrdZkXX2/Qyo0GJDLkCQkiPbPGsQTPihUHzVbiVFri+0bRHw6rc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765037542; c=relaxed/simple; bh=PSUb299D2dYUfFweRiNrtxHWpDEOy5t5wSnP8271FXg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mlTUB73qJ2LBAv+Cv1Ik/mijnMz05mtYSBVBxz7K4D218OJUkUTVLlDBDja3r3i1RtyffaH3yHA+8rKCX2NFK31708XpNTPnvtYX36zrutfk6Lc9YyMpBiiVsP52Y558tMwHZ0F0HnZvufWc94c3P1Yfmlc8GLa6awVZDnTrfeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SWXYd1bt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z4CL9zvQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SWXYd1bt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z4CL9zvQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B65VoAC2258795 for ; Sat, 6 Dec 2025 16:12:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OcVXm5JIAcyGqoJflm6whI5XkmDpNUJ6dOT69v0sFpE=; b=SWXYd1btFwoRiND6 APXPBBWva/xapGbLe6jvCaQoqCg7rFIzguszDcjP5q/VXt+fryuAbBjZoXp/g9v2 5EPOvmdq8St19MJEzKJ0iQYQygljJBcW2/nI3R/7oa1FKRTSOfKTCZ3zv4n9vgH+ t3v06kbPSGqzWn2/hNgOmrfPffchqpORgTn2PlFxoiFqaUJKmToHQmiuhkyWffWz NfTDkS7/xcmSnoRg+Hv+9BgPw9T1XUWT6BC50xZwZJwNkTFsedX04R2gzjHEGVfT 1Yrgv3iSVwPSYc3r0CLGlCqPy0C86nGsQGDVtDo2QNwr2kZcjSOupnxdu5x+4dGc AUqpng== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ava6f97x2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 06 Dec 2025 16:12:19 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-bddf9ce4935so2779795a12.1 for ; Sat, 06 Dec 2025 08:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765037539; x=1765642339; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OcVXm5JIAcyGqoJflm6whI5XkmDpNUJ6dOT69v0sFpE=; b=Z4CL9zvQL3TWViMItEjM+lSh+9ldKEQ33pi2ZqLw4XiyPWxEdaG/3X7F53wGykwzES Sb4a/rkwT1PDT7RQ5OiHAzBDPew70NcaIBb3kbps6fU2m3bliAW24gBoJxOqQfySJUAs 40MsqRMoXY8UYVoWIkUJW9s+PXKzZ9kBBstYuGgLpgGUIA4EieNuJzuDL5X7V+LrMoF6 ml1sEpqYmTTFAcit42woRm56VLZuq/jEDcKlkM2GwW7Wtgm58rhEbVo3xbICE+7t/vpx LnDwdMl2lmEiXTOuQDhSa2Ki1stI67ZFChqmfRigcg4iDLIiDYoX+SD3x79fVOZQBazu HU3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765037539; x=1765642339; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OcVXm5JIAcyGqoJflm6whI5XkmDpNUJ6dOT69v0sFpE=; b=vyB/Lcw6Ab1IO89fALzNbkASAJSn2t7k/fwRFxBJe5CiJYQqdt9hfzFZQyU9MlQtvI fYaLSua8fzhJXS7At5Ob+jXHydc+9sRmKS1ACF4X+U3SKIJ+UNGnHlojR4hgW4lc5yp3 XWR3bjz3mwcD4nf8Q45dGnkpflpuDV+Hqc3fNSPPvo/LOdXuhoK+5UAT0P9IwIC6QD4X edEMn+BaVlO7Wae/X5Zyby9/xRm0Vl1mudDJeQw4i9TAPK8dpDPXlAS+ZxiS5bHnfjBH D3Nio4/fVmvnYJj+YqJFCtlmD0MFszEsqEQ4v9bUOMPf09XvhhmJblBNBk4Py5UJV5n2 adMw== X-Gm-Message-State: AOJu0Yx9W6qqQAE6qZnksY7uCaCHkcDVmIJrVFBPRIAX3//6hC0BNbty JhSHQ/Ubqh+CLPBrgoozerBmpezF9lzuCWSmg2Kvrp0zYoj3lKPrCYe0faDwcesTNdeN2X8nwXe x1MRpMsehXLaglJVgLcUNT1nuFzMrPizlcS9gvbB6KCXyUDVBw8qVOO2JZ8irZ1YHbG8Q X-Gm-Gg: ASbGncs3Cnr7iZ5fEW2OZTxzLpmeVUD4lYDU6NoO+8ZbqhbIA1XxQnBXbnQJCn9xUKL 2ZS4vU/f3q+KoGkmnx1G6rJ5aNvJYqGIcG9+vcE0Hr4xwwOAbhu73g14bKAm4a/eO2OzI+Qr1BE 5q7nx3zVxeMnxVhkhLBzFc6b/zD6jjmdxzBXlJCq18gc0PRf7D06BZMYgkgSQTFfYy12tSRdWXd n0Ac3QzbgvwvzrQTME+ax2kKG9Pz9sZCmfGWAC5LAlKd2qUKQMCoi+xU+xyf9v9XU/AUnkVemit HhRRGLHdF9BQL0BkTF8JxLpXN9I8uJLZ1wWWDdDgBLRHGIHGX4OgnkjhRfFtiOAnFfHVJ+cEddp xxS/eqUfzpzrFCcIpcoSpNlcs3nW9iJHl574hiv2eHJWpdw== X-Received: by 2002:a05:7022:f89:b0:119:e55a:9c04 with SMTP id a92af1059eb24-11e032ac37dmr2065793c88.32.1765037539127; Sat, 06 Dec 2025 08:12:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6Q72hT1tfm6ehPxRu0e2geTtWEprk5QX5IDwHV/oq7L2zAoa9XsSYNu2EY3vjHRgUFdsabA== X-Received: by 2002:a05:7022:f89:b0:119:e55a:9c04 with SMTP id a92af1059eb24-11e032ac37dmr2065761c88.32.1765037538505; Sat, 06 Dec 2025 08:12:18 -0800 (PST) Received: from [192.168.1.3] ([122.177.243.159]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df7552211sm31523490c88.1.2025.12.06.08.12.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Dec 2025 08:12:18 -0800 (PST) Message-ID: Date: Sat, 6 Dec 2025 21:42:11 +0530 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss , Neil Armstrong , Johan Hovold , Pengyu Luo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251204044644.3072086-1-krishna.kurapati@oss.qualcomm.com> <20251204044644.3072086-3-krishna.kurapati@oss.qualcomm.com> <755b7579-757f-4ced-b3c4-39c20e6b25a7@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <755b7579-757f-4ced-b3c4-39c20e6b25a7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: CGD0tDEWAMjpZyRqJolZ3WwZHweOh2dr X-Authority-Analysis: v=2.4 cv=NYXrFmD4 c=1 sm=1 tr=0 ts=693455e3 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=mGeNq4HQZpM0LKVKY7z1pw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7OXqrvXZNe0mwyzepZkA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: CGD0tDEWAMjpZyRqJolZ3WwZHweOh2dr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA2MDEzMiBTYWx0ZWRfX9xGH5LHGgTi+ a2VfenzaP7r1mkxGRxXXlhyIjnjtqoFdCywnJQGEmWQSRk/Z3nG/TNLdLMrdSvwJRq/Jl8K2HT6 IDdWz0WuhBp+pTesuXTv/s6HM0OxILfYAVfJrekyrqASZ/a1ln8hJC75f4QN6rGbTwcXwwL47SY kNt84NjfMvg5CxSD8Vx0R9FhmLkDAStfVDyQexN2zB2NptnDW6Z0d7LxxJZBQaiGpZ3ts2J7prS U2v9YeYkTYx4Mgsvxy7Kg914vuMi88BFM3WTfaF+uFuLS3nqcqeuivWIGgFtpAMT1t+rW+emSYI pV+YyorVKv7a+keyZDGxGnu1gTSBJMzQZjTPKERanb8j4MY0LHU9sT5y6EZe0z0eTCmZk7zSjhb kvQWHYCKM4B6GHN/O3IKQCit1MmxSQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512060132 On 12/5/2025 7:01 PM, Konrad Dybcio wrote: > On 12/4/25 5:46 AM, Krishna Kurapati wrote: >> Add support for overriding Squelch Detect parameter. >> >> Signed-off-by: Krishna Kurapati >> --- >> .../phy/qualcomm/phy-qcom-eusb2-repeater.c | 22 +++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c >> index 651a12b59bc8..a75b37d4e16d 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c >> +++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c >> @@ -37,6 +37,17 @@ >> #define EUSB2_TUNE_EUSB_EQU 0x5A >> #define EUSB2_TUNE_EUSB_HS_COMP_CUR 0x5B >> >> +static const int squelch_detector[] = { >> + [0] = -6000, >> + [1] = -5000, >> + [2] = -4000, >> + [3] = -3000, >> + [4] = -2000, >> + [5] = -1000, >> + [6] = 0, >> + [7] = 1000, >> +}; > > I forgot to ask, do these values apply to all of the supported repeaters? > I checked smb2360/pmih010x_eusb2_repeater and pm8550b repeaters (SM8{5/6/7}50/ Kaanapali/ Hamoa). For all of them, the above table is same. Regards, Krishna, > i.e. > > PM8550B > PMIV0104 > SMB2360 > > Konrad