From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FAAAC77B7A for ; Wed, 7 Jun 2023 23:26:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232842AbjFGX0U (ORCPT ); Wed, 7 Jun 2023 19:26:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230290AbjFGX0T (ORCPT ); Wed, 7 Jun 2023 19:26:19 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D300212E for ; Wed, 7 Jun 2023 16:26:18 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f611ac39c5so49680e87.2 for ; Wed, 07 Jun 2023 16:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686180376; x=1688772376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=clAyQHagKADMcGEukzKqm8FN+4BHghHI7AVIxMqM/aY=; b=d44tE+KKQjfk93ENTy8SveEMHyx6yvK7RQwcjKSFZ+faU2g5xHT86cZ+a65AZVmEjh vsP6TBwGAdP/b5pMlRKbgkb0eyPyf63isIOb6EyRxuzMZZlEjefMzN9A4hZB92aVhDC/ Rtc05tHDQCx0CwE6LDJEMOhveN3R0LwhixWwNdJfCFdkuBQMd5oC0DeXM8NUJFtf5QCm JJ/2H2N3qXN2aZ0IN+QyDUqYseyGvQE5yLzfm+T2SK1rLS/D1X8YgNrrhplCxaKua7e+ y25UddS/c5IbknVfE9a2kCvI1ELwZaaCDd24LYanhIleshJ739CqXQq01i3RS2icJQ+I fLDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686180376; x=1688772376; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=clAyQHagKADMcGEukzKqm8FN+4BHghHI7AVIxMqM/aY=; b=iKdhpUk+LCJCqkHYVoRbUUp5YaTzLo4ZtWWCQP5RDcmBYyfJ5/28pReNFFAO9oixCR sMVyXunrFVXVJ+2uYxen4lyzp0ICbuVthDai1KkPFu+ji7085aF0U99JqaP2BVrQVJmJ 17oWfM9hl3LQuLWljVBBeR70W53YnIx80SVOdTIwhNXjxsD/a78ZcuLNEJ0INCyrR2Nf 29mw7Ugnox9b2v+4Qumd5zB8Om8r49ODWVZQnTI1eQk8GnX1wiRyuZOkBZ1cVjWVZIo4 WH9r7DuaVWwnfdF6CFP4zMrYp7X6dPkWNtugPfi3eR/FiEhVXkvdoh0jE4tCx6499U2G EVPQ== X-Gm-Message-State: AC+VfDwalEbuHocVUiResKQGjCVZHqvlfX8Apx/KONq9j7wgs3DZl5lm TizfzLIfUe8QeyUZFrCFqunAUg== X-Google-Smtp-Source: ACHHUZ7tMkaummVBZmyBdPLwUs1cTQAxIPGZmcOMvJLsSTK+PfiT6YW5LuYLDmRrqxDaizf+iAijAw== X-Received: by 2002:ac2:549c:0:b0:4f6:3fa1:19b7 with SMTP id t28-20020ac2549c000000b004f63fa119b7mr1295642lfk.7.1686180376398; Wed, 07 Jun 2023 16:26:16 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id q5-20020ac25a05000000b004f63eea01a7sm468156lfn.192.2023.06.07.16.26.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 16:26:15 -0700 (PDT) Message-ID: Date: Thu, 8 Jun 2023 02:26:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] drm/msm/dpu: tidy up some error checking Content-Language: en-GB To: Dan Carpenter , Marijn Suijten Cc: Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Jessica Zhang , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org References: From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 07/06/2023 17:42, Dan Carpenter wrote: > On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: >>> @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( >>> * frequency divided by the no. of rows (lines) in the LCDpanel. >>> */ >>> vsync_hz = dpu_kms_get_clk_rate(dpu_kms, "vsync"); >>> - if (vsync_hz <= 0) { >>> - DPU_DEBUG_CMDENC(cmd_enc, "invalid - vsync_hz %u\n", >>> + if (!vsync_hz) { >>> + DPU_DEBUG_CMDENC(cmd_enc, "invalid - vsync_hz %lu\n", >>> vsync_hz); >> >> Nit: no need to print the value here, you know it's zero. Could be >> clarified to just "no vsync clock". >> > > Yeah. That's obviously not useful. Sorry, I will resend. I'll fix while applying. Seems easier. -- With best wishes Dmitry