From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tvaT9HmK" Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9143B191 for ; Wed, 22 Nov 2023 11:58:53 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50aaaf6e58fso122762e87.2 for ; Wed, 22 Nov 2023 11:58:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700683132; x=1701287932; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=owGEeKQSkUhkxsVwujRwMFyJouN+ra21rm+Zo53wjqY=; b=tvaT9HmKRdWu84mo5ZPHWsY8T9pmn1kNg0kicHvaDcySX/AY4EBXLHFBAPShQ2dKnH aWjjKBBhnY2SabxcgPt19YuIAE3vlIdYpRQtY7G4byKJxj0e7qVC4YVGyjyOiSZ0/zWb 04yTfH/DkJEbargl75isHL5TOP+AJsas9MLcpQTwndFTFhEZfuqs4AEpFdThrx5l37eb Z6t9CQAreVFxVWYF7rHtlMHnHw6HRAKsVRnlvlUOrCbywTrglqpXob1kl9kAl8XgUpdl 7CUer/lEy2akSBEj3B00r5gShYAUbezhLQJ41cDT7QHFVyWuDJoz1ngD6k0npX7whSRp voeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700683132; x=1701287932; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=owGEeKQSkUhkxsVwujRwMFyJouN+ra21rm+Zo53wjqY=; b=ElN01RN5hP5y17o7EZEWQEFI00kEtM5uY6mEAZjvJz8Jq0hBnpZib3Q7MJCWioEQa6 yoi3gzRQ/gY9SVpPsrNM4rMJXjAQmTX5W/sctJkdW7z+Y5bsA9E97LW9zi4EwaNdAkrw 416fU+JfHrQllJf+R6geQ9UXj6pVyFWVGVa6YjhlSaGUqhL4fquRcOzAsNRmLK7ou2qW b2/3X/rYsSS+dS1laqQlqosztqYp9mSWmoF+KpragBINpFfNN5s6R+q/Y3CFE4CrnL4k /AAcK3+i2Xz2Qi4XjBc19LeNWVqAF1Hfi4lFukCm0p102gWlMtfLOCtPkgv4iaISccjW KAlA== X-Gm-Message-State: AOJu0YxG9Rao+SQ6nlp0wVN4GZ1NLhi2dfPcd7m7ZlqMtEd8nE1UOZuL q9LMUHG6aWD+XXi7XXAGDFwRCA== X-Google-Smtp-Source: AGHT+IGYqOWN7ZE1DBlANCP1hywbHhcJvA+AMBnV5R5G1Kpc69S8u66ZkA3X4OqbdUjjha8Wo36dKg== X-Received: by 2002:a05:6512:b86:b0:509:8fbf:7af0 with SMTP id b6-20020a0565120b8600b005098fbf7af0mr1044667lfv.69.1700683131795; Wed, 22 Nov 2023 11:58:51 -0800 (PST) Received: from [172.30.204.74] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id u19-20020a05651220d300b0050300e013f3sm1935876lfr.254.2023.11.22.11.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 11:58:51 -0800 (PST) Message-ID: Date: Wed, 22 Nov 2023 20:58:50 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] soundwire: qcom: move sconfig in qcom_swrm_stream_alloc_ports() out of critical section Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20231120190740.339350-1-krzysztof.kozlowski@linaro.org> <20231120190740.339350-2-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20231120190740.339350-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: * On 11/20/23 20:07, Krzysztof Kozlowski wrote: > Setting members of local variable "sconfig" in > qcom_swrm_stream_alloc_ports() does not depend on any earlier code in > this function, so can be moved up before the critical section. This > makes the code a bit easier to follow because critical section is > smaller. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad