From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23950C4332F for ; Tue, 22 Nov 2022 07:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232572AbiKVHup (ORCPT ); Tue, 22 Nov 2022 02:50:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232174AbiKVHuo (ORCPT ); Tue, 22 Nov 2022 02:50:44 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 787FF6464 for ; Mon, 21 Nov 2022 23:50:42 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id z24so17047826ljn.4 for ; Mon, 21 Nov 2022 23:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TPz0CfRWtJWXgtCnS7ds9MNbespiiT1+KjVHD4pisS8=; b=iQY5Gfp6qXqtdYsRxjlZyiRx0Lu7vUpss+/51LGs4B9Rax4lUDwTJTfPULQaneuMtx QxBz/8vp5w5UuTi4oMwlEZ08NG7BLC4yVhJdWzFywiQHu7I6HAaTXebE/d2+kFxT8ssW hf2MaaFx1n5tUCwJLhOffFqymyQoE2PSbVa620USjXi8xbuMJ7oz0LtAOhSh8Y/G60m5 TCwc6gaVzqpHMVsgOH0HPH0+BO+xqTgU2x04wjDPgx2TGsAhlEqdg+yI0Jsl9GRzUSKD Yfl64D4P8HpC+JCofEHK0hGvo5SDNfSufHR560B+Q9lFuvN5elrb3hrLqEVwipxAAraE 3Kqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TPz0CfRWtJWXgtCnS7ds9MNbespiiT1+KjVHD4pisS8=; b=yuNX5TF51lBRP3qxDxagSIDTa+z2REMt++O7hVI7C+E7bqb5eqyl+r2H/COUBpPhMW ZsnrKBTxt2x/+v1MsmaK6y3W14m5W+LBnrYQEwSORlnyfXqj8ogpKNfck9JOXlf5ENzw D2Zlj3dGk/1nePRJNBgE7eOXo1HM30lCMzxyB1HagzjFMEDDD5C0QYu/6cFGduGCQ0Bj lzZyKVihKQh+jNZhooHMw2M5o330Fqpw5J6zSfwSQI749WClJCPDni7y8FAQOF+XePev 4+CWay+Be9JXYTsYnaOrgfNnB/cLMMkaT974fnHHp2u1Dt1QAzYsDMfo0MEB629+Ea5Q M36g== X-Gm-Message-State: ANoB5pnN2GaELQYwJu3Vdbz97RY0KDD73rd7MejnOVc3w0OnoLiFVc9+ j9+A+1s5r88qhCmIWO71DjN0ZQ== X-Google-Smtp-Source: AA0mqf7dyX3euZowNC8FGmmtOg2WzEtwBgoJjCmNcNFKoHc5tllPD4n+7B4F81hioDrq3Gxi8dQULA== X-Received: by 2002:a2e:a37c:0:b0:26e:93:980d with SMTP id i28-20020a2ea37c000000b0026e0093980dmr7466963ljn.488.1669103440836; Mon, 21 Nov 2022 23:50:40 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a4-20020a056512200400b004a01105eea2sm2354702lfb.150.2022.11.21.23.50.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 23:50:40 -0800 (PST) Message-ID: Date: Tue, 22 Nov 2022 08:50:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 1/3] dt-bindings: interconnect: Add rpmh virt devices Content-Language: en-US To: Melody Olvera , Andy Gross , Bjorn Andersson , Konrad Dybcio , Georgi Djakov , Rob Herring , Krzysztof Kozlowski Cc: Odelu Kukatla , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118182245.31035-1-quic_molvera@quicinc.com> <20221118182245.31035-2-quic_molvera@quicinc.com> <536af0d9-aa00-ddf1-753d-670ec2adef91@linaro.org> <3ada611b-96e0-5cf0-d79d-b90ca4202ddb@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <3ada611b-96e0-5cf0-d79d-b90ca4202ddb@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21/11/2022 18:39, Melody Olvera wrote: > > > On 11/20/2022 5:13 AM, Krzysztof Kozlowski wrote: >> On 18/11/2022 19:22, Melody Olvera wrote: >>> Add documentation for virtual rpmh devices. These interconnects >>> are not controlled by the application processor and thus >>> require separate bindings. Also, move compatibles for sm8450 to >>> this document and add them for QDU1000/QRU1000 platforms. >>> >>> Signed-off-by: Melody Olvera >>> --- >>> .../bindings/interconnect/qcom,rpmh-virt.yaml | 55 +++++++++++++++++++ >>> .../bindings/interconnect/qcom,rpmh.yaml | 2 - >>> 2 files changed, 55 insertions(+), 2 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml >>> new file mode 100644 >>> index 000000000000..5cbaa51df863 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh-virt.yaml >>> @@ -0,0 +1,55 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/interconnect/qcom,rpmh-virt.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm RPMh Virtual Network-On-Chip Interconnect >>> + >>> +maintainers: >>> + - Georgi Djakov >>> + - Odelu Kukatla >>> + >>> +description: | >>> + RPMh interconnect providers support system bandwidth requirements through >>> + RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is >>> + able to communicate with the BCM through the Resource State Coordinator (RSC) >>> + associated with each execution environment. Provider nodes must point to at >>> + least one RPMh device child node pertaining to their RSC and each provider >>> + can map to multiple RPMh resources. Virtual interconnect providers are not >>> + controlled by AP and do not support QoS; they should not have associated >>> + register regions. >>> + >>> +allOf: >>> + - $ref: qcom,rpmh-common.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - qcom,qdu1000-clk-virt >>> + - qcom,qdu1000-mc-virt >>> + - qcom,sm8450-clk-virt >>> + - qcom,sm8450-mc-virt >> You should also move qcom,sdx65-mc-virt, qcom,sc8280xp-mc-virt, >> qcom,sc8280xp-clk-virt and more. > > Ok. I wasn't sure since some of these entries don't seem to conform to > these bindings, even though it seems they should. I have impression that devices I listed conform to these bindings, this is why I listed them. But if you are sure that they do not, then they should not be moved. Best regards, Krzysztof