From: Caleb Connolly <caleb.connolly@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Lee Jones <lee.jones@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
Date: Mon, 19 Sep 2022 12:35:31 +0100 [thread overview]
Message-ID: <b7dac69f-88b9-f3d2-45c1-659115de3552@linaro.org> (raw)
In-Reply-To: <20220915113523.44074-1-luca.weiss@fairphone.com>
On 15/09/2022 12:35, Luca Weiss wrote:
> There are some IDs that are written in uppercase. For consistency
> convert them to lowercase.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Kind Regards,
Caleb
> ---
> Changes since v2:
> * Split out to separate patch
>
> include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
> index 72398ff44719..fde0148d0077 100644
> --- a/include/soc/qcom/qcom-spmi-pmic.h
> +++ b/include/soc/qcom/qcom-spmi-pmic.h
> @@ -29,9 +29,9 @@
> #define PM8998_SUBTYPE 0x14
> #define PMI8998_SUBTYPE 0x15
> #define PM8005_SUBTYPE 0x18
> -#define PM660L_SUBTYPE 0x1A
> -#define PM660_SUBTYPE 0x1B
> -#define PM8150_SUBTYPE 0x1E
> +#define PM660L_SUBTYPE 0x1a
> +#define PM660_SUBTYPE 0x1b
> +#define PM8150_SUBTYPE 0x1e
> #define PM8150L_SUBTYPE 0x1f
> #define PM8150B_SUBTYPE 0x20
> #define PMK8002_SUBTYPE 0x21
next prev parent reply other threads:[~2022-09-19 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 11:35 [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Luca Weiss
2022-09-15 11:35 ` [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs Luca Weiss
2022-09-15 14:52 ` Dmitry Baryshkov
2022-09-19 11:34 ` Caleb Connolly
2022-09-15 14:46 ` [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Dmitry Baryshkov
2022-09-19 11:35 ` Caleb Connolly [this message]
2022-09-20 7:50 ` Lee Jones
2022-09-21 6:12 ` Luca Weiss
2022-09-21 18:05 ` Caleb Connolly
2022-09-22 10:20 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7dac69f-88b9-f3d2-45c1-659115de3552@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).