* [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs
2022-09-15 11:35 [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Luca Weiss
@ 2022-09-15 11:35 ` Luca Weiss
2022-09-15 14:52 ` Dmitry Baryshkov
2022-09-19 11:34 ` Caleb Connolly
2022-09-15 14:46 ` [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Dmitry Baryshkov
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: Luca Weiss @ 2022-09-15 11:35 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss,
Jonathan Cameron, Caleb Connolly, Dmitry Baryshkov, Lee Jones,
linux-kernel
Add more IDs that are found in the downstream msm-4.19 kernel under the
path include/linux/qpnp/qpnp-revid.h.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes since v2:
* Convert hex numbers lowercase
* Remove SMB* IDs added in v1, given it's not sure they're actually spmi
pmics or just i2c pmics (keep SMB2351 because it supports spmi)
include/soc/qcom/qcom-spmi-pmic.h | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
index fde0148d0077..c47cc71a999e 100644
--- a/include/soc/qcom/qcom-spmi-pmic.h
+++ b/include/soc/qcom/qcom-spmi-pmic.h
@@ -26,6 +26,8 @@
#define PM8901_SUBTYPE 0x0f
#define PM8950_SUBTYPE 0x10
#define PMI8950_SUBTYPE 0x11
+#define PMK8001_SUBTYPE 0x12
+#define PMI8996_SUBTYPE 0x13
#define PM8998_SUBTYPE 0x14
#define PMI8998_SUBTYPE 0x15
#define PM8005_SUBTYPE 0x18
@@ -36,8 +38,17 @@
#define PM8150B_SUBTYPE 0x20
#define PMK8002_SUBTYPE 0x21
#define PM8009_SUBTYPE 0x24
+#define PMI632_SUBTYPE 0x25
#define PM8150C_SUBTYPE 0x26
+#define PM6150_SUBTYPE 0x28
#define SMB2351_SUBTYPE 0x29
+#define PM8008_SUBTYPE 0x2c
+#define PM6125_SUBTYPE 0x2d
+#define PM7250B_SUBTYPE 0x2e
+#define PMK8350_SUBTYPE 0x2f
+#define PMR735B_SUBTYPE 0x34
+#define PM6350_SUBTYPE 0x36
+#define PM2250_SUBTYPE 0x37
#define PMI8998_FAB_ID_SMIC 0x11
#define PMI8998_FAB_ID_GF 0x30
--
2.37.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs
2022-09-15 11:35 ` [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs Luca Weiss
@ 2022-09-15 14:52 ` Dmitry Baryshkov
2022-09-19 11:34 ` Caleb Connolly
1 sibling, 0 replies; 10+ messages in thread
From: Dmitry Baryshkov @ 2022-09-15 14:52 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Jonathan Cameron,
Caleb Connolly, Lee Jones, linux-kernel
On 15/09/2022 14:35, Luca Weiss wrote:
> Add more IDs that are found in the downstream msm-4.19 kernel under the
> path include/linux/qpnp/qpnp-revid.h.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes since v2:
> * Convert hex numbers lowercase
> * Remove SMB* IDs added in v1, given it's not sure they're actually spmi
> pmics or just i2c pmics (keep SMB2351 because it supports spmi)
>
> include/soc/qcom/qcom-spmi-pmic.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs
2022-09-15 11:35 ` [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs Luca Weiss
2022-09-15 14:52 ` Dmitry Baryshkov
@ 2022-09-19 11:34 ` Caleb Connolly
1 sibling, 0 replies; 10+ messages in thread
From: Caleb Connolly @ 2022-09-19 11:34 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Jonathan Cameron,
Dmitry Baryshkov, Lee Jones, linux-kernel
On 15/09/2022 12:35, Luca Weiss wrote:
> Add more IDs that are found in the downstream msm-4.19 kernel under the
> path include/linux/qpnp/qpnp-revid.h.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Kind Regards,
Caleb
> ---
> Changes since v2:
> * Convert hex numbers lowercase
> * Remove SMB* IDs added in v1, given it's not sure they're actually spmi
> pmics or just i2c pmics (keep SMB2351 because it supports spmi)
>
> include/soc/qcom/qcom-spmi-pmic.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
> index fde0148d0077..c47cc71a999e 100644
> --- a/include/soc/qcom/qcom-spmi-pmic.h
> +++ b/include/soc/qcom/qcom-spmi-pmic.h
> @@ -26,6 +26,8 @@
> #define PM8901_SUBTYPE 0x0f
> #define PM8950_SUBTYPE 0x10
> #define PMI8950_SUBTYPE 0x11
> +#define PMK8001_SUBTYPE 0x12
> +#define PMI8996_SUBTYPE 0x13
> #define PM8998_SUBTYPE 0x14
> #define PMI8998_SUBTYPE 0x15
> #define PM8005_SUBTYPE 0x18
> @@ -36,8 +38,17 @@
> #define PM8150B_SUBTYPE 0x20
> #define PMK8002_SUBTYPE 0x21
> #define PM8009_SUBTYPE 0x24
> +#define PMI632_SUBTYPE 0x25
> #define PM8150C_SUBTYPE 0x26
> +#define PM6150_SUBTYPE 0x28
> #define SMB2351_SUBTYPE 0x29
> +#define PM8008_SUBTYPE 0x2c
> +#define PM6125_SUBTYPE 0x2d
> +#define PM7250B_SUBTYPE 0x2e
> +#define PMK8350_SUBTYPE 0x2f
> +#define PMR735B_SUBTYPE 0x34
> +#define PM6350_SUBTYPE 0x36
> +#define PM2250_SUBTYPE 0x37
>
> #define PMI8998_FAB_ID_SMIC 0x11
> #define PMI8998_FAB_ID_GF 0x30
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
2022-09-15 11:35 [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Luca Weiss
2022-09-15 11:35 ` [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs Luca Weiss
@ 2022-09-15 14:46 ` Dmitry Baryshkov
2022-09-19 11:35 ` Caleb Connolly
2022-09-20 7:50 ` Lee Jones
3 siblings, 0 replies; 10+ messages in thread
From: Dmitry Baryshkov @ 2022-09-15 14:46 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Jonathan Cameron,
Lee Jones, Caleb Connolly, linux-kernel
On 15/09/2022 14:35, Luca Weiss wrote:
> There are some IDs that are written in uppercase. For consistency
> convert them to lowercase.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Changes since v2:
> * Split out to separate patch
>
> include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
2022-09-15 11:35 [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Luca Weiss
2022-09-15 11:35 ` [PATCH v3 2/2] mfd: qcom-spmi-pmic: Add more PMIC SUBTYPE IDs Luca Weiss
2022-09-15 14:46 ` [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Dmitry Baryshkov
@ 2022-09-19 11:35 ` Caleb Connolly
2022-09-20 7:50 ` Lee Jones
3 siblings, 0 replies; 10+ messages in thread
From: Caleb Connolly @ 2022-09-19 11:35 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Jonathan Cameron,
Lee Jones, Dmitry Baryshkov, linux-kernel
On 15/09/2022 12:35, Luca Weiss wrote:
> There are some IDs that are written in uppercase. For consistency
> convert them to lowercase.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Kind Regards,
Caleb
> ---
> Changes since v2:
> * Split out to separate patch
>
> include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h
> index 72398ff44719..fde0148d0077 100644
> --- a/include/soc/qcom/qcom-spmi-pmic.h
> +++ b/include/soc/qcom/qcom-spmi-pmic.h
> @@ -29,9 +29,9 @@
> #define PM8998_SUBTYPE 0x14
> #define PMI8998_SUBTYPE 0x15
> #define PM8005_SUBTYPE 0x18
> -#define PM660L_SUBTYPE 0x1A
> -#define PM660_SUBTYPE 0x1B
> -#define PM8150_SUBTYPE 0x1E
> +#define PM660L_SUBTYPE 0x1a
> +#define PM660_SUBTYPE 0x1b
> +#define PM8150_SUBTYPE 0x1e
> #define PM8150L_SUBTYPE 0x1f
> #define PM8150B_SUBTYPE 0x20
> #define PMK8002_SUBTYPE 0x21
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
2022-09-15 11:35 [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase Luca Weiss
` (2 preceding siblings ...)
2022-09-19 11:35 ` Caleb Connolly
@ 2022-09-20 7:50 ` Lee Jones
2022-09-21 6:12 ` Luca Weiss
3 siblings, 1 reply; 10+ messages in thread
From: Lee Jones @ 2022-09-20 7:50 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Jonathan Cameron, Dmitry Baryshkov, Caleb Connolly, linux-kernel,
Lee Jones
On Thu, 15 Sep 2022, Luca Weiss wrote:
> There are some IDs that are written in uppercase. For consistency
> convert them to lowercase.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes since v2:
> * Split out to separate patch
>
> include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
These aren't MFD patches. Please reword the subject.
--
DEPRECATED: Please use lee@kernel.org
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
2022-09-20 7:50 ` Lee Jones
@ 2022-09-21 6:12 ` Luca Weiss
2022-09-21 18:05 ` Caleb Connolly
0 siblings, 1 reply; 10+ messages in thread
From: Luca Weiss @ 2022-09-21 6:12 UTC (permalink / raw)
To: Lee Jones
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Jonathan Cameron, Dmitry Baryshkov, Caleb Connolly, linux-kernel,
Lee Jones
Hi Lee, hi Caleb
On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote:
> On Thu, 15 Sep 2022, Luca Weiss wrote:
>
> > There are some IDs that are written in uppercase. For consistency
> > convert them to lowercase.
> >
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
> > Changes since v2:
> > * Split out to separate patch
> >
> > include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> These aren't MFD patches. Please reword the subject.
Do you have any suggestion what subject to use then? The most I can
think of is "soc: qcom: " which is sometimes used for other files in
this include directory.
I've used the current subject because the previous two patches touching
this file had this subject also.
Regards
Luca
>
> --
> DEPRECATED: Please use lee@kernel.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
2022-09-21 6:12 ` Luca Weiss
@ 2022-09-21 18:05 ` Caleb Connolly
2022-09-22 10:20 ` Lee Jones
0 siblings, 1 reply; 10+ messages in thread
From: Caleb Connolly @ 2022-09-21 18:05 UTC (permalink / raw)
To: Luca Weiss, Lee Jones
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Jonathan Cameron, Dmitry Baryshkov, linux-kernel, Lee Jones
On 21/09/2022 07:12, Luca Weiss wrote:
> Hi Lee, hi Caleb
>
> On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote:
>> On Thu, 15 Sep 2022, Luca Weiss wrote:
>>
>>> There are some IDs that are written in uppercase. For consistency
>>> convert them to lowercase.
>>>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>> ---
>>> Changes since v2:
>>> * Split out to separate patch
>>>
>>> include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> These aren't MFD patches. Please reword the subject.
>
> Do you have any suggestion what subject to use then? The most I can
> think of is "soc: qcom: " which is sometimes used for other files in
> this include directory.
> I've used the current subject because the previous two patches touching
> this file had this subject also.
This file just contains platform data which used to be in the qcom SPMI
PMIC driver. In hindsight, maybe it would have been better suited in
include/linux/mfd but I don't think it matters too much. I guess it makes
sense to follow convention for the directory and treat it like the other
platform headers, maybe something like:
soc: qcom: spmi-pmic: convert hex numbers to lowercase
>
> Regards
> Luca
>
>>
>> --
>> DEPRECATED: Please use lee@kernel.org
>
--
Kind Regards,
Caleb (they/them)
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] mfd: qcom-spmi-pmic: convert hex numbers lowercase
2022-09-21 18:05 ` Caleb Connolly
@ 2022-09-22 10:20 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2022-09-22 10:20 UTC (permalink / raw)
To: Caleb Connolly
Cc: Luca Weiss, linux-arm-msm, ~postmarketos/upstreaming, phone-devel,
Jonathan Cameron, Dmitry Baryshkov, linux-kernel, Lee Jones
On Wed, 21 Sep 2022, Caleb Connolly wrote:
>
>
> On 21/09/2022 07:12, Luca Weiss wrote:
> > Hi Lee, hi Caleb
> >
> > On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote:
> > > On Thu, 15 Sep 2022, Luca Weiss wrote:
> > >
> > > > There are some IDs that are written in uppercase. For consistency
> > > > convert them to lowercase.
> > > >
> > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > > > ---
> > > > Changes since v2:
> > > > * Split out to separate patch
> > > >
> > > > include/soc/qcom/qcom-spmi-pmic.h | 6 +++---
> > > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > These aren't MFD patches. Please reword the subject.
> >
> > Do you have any suggestion what subject to use then? The most I can
> > think of is "soc: qcom: " which is sometimes used for other files in
> > this include directory.
> > I've used the current subject because the previous two patches touching
> > this file had this subject also.
>
> This file just contains platform data which used to be in the qcom SPMI
> PMIC driver. In hindsight, maybe it would have been better suited in
> include/linux/mfd but I don't think it matters too much. I guess it makes
> sense to follow convention for the directory and treat it like the other
> platform headers, maybe something like:
>
> soc: qcom: spmi-pmic: convert hex numbers to lowercase
Agree.
--
DEPRECATED: Please use lee@kernel.org
^ permalink raw reply [flat|nested] 10+ messages in thread