From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org,
alex.williamson@redhat.com
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 1/2] PCI: handle CRS returned by device after FLR
Date: Sun, 6 Aug 2017 22:59:49 -0400 [thread overview]
Message-ID: <b841281a-cb6c-dfb2-001c-bc13a261c741@codeaurora.org> (raw)
In-Reply-To: <1502071792-15263-1-git-send-email-okaya@codeaurora.org>
On 8/6/2017 10:09 PM, Sinan Kaya wrote:
> + pcie_capability_read_word(dev, PCI_EXP_RTCAP, &root_cap);
> + if (root_cap & PCI_EXP_RTCAP_CRSVIS) {
> + /* don't touch the HW before waiting 100ms */
> + msleep(100);
This is obviously broken. I should have checked the capability
on the root port. I was trying to get it out before Monday.
However, I still want to hear about the preference of this
methodology.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-08-07 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 2:09 [PATCH V8 1/2] PCI: handle CRS returned by device after FLR Sinan Kaya
2017-08-07 2:09 ` [PATCH V8 2/2] PCI: display not responding message while device is unreachable Sinan Kaya
2017-08-07 2:59 ` Sinan Kaya [this message]
2017-08-08 21:19 ` [PATCH V8 1/2] PCI: handle CRS returned by device after FLR Bjorn Helgaas
2017-08-08 23:39 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b841281a-cb6c-dfb2-001c-bc13a261c741@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).