From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH V8 1/2] PCI: handle CRS returned by device after FLR Date: Sun, 6 Aug 2017 22:59:49 -0400 Message-ID: References: <1502071792-15263-1-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:38672 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbdHGC7w (ORCPT ); Sun, 6 Aug 2017 22:59:52 -0400 In-Reply-To: <1502071792-15263-1-git-send-email-okaya@codeaurora.org> Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: linux-pci@vger.kernel.org, timur@codeaurora.org, alex.williamson@redhat.com Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , linux-kernel@vger.kernel.org On 8/6/2017 10:09 PM, Sinan Kaya wrote: > + pcie_capability_read_word(dev, PCI_EXP_RTCAP, &root_cap); > + if (root_cap & PCI_EXP_RTCAP_CRSVIS) { > + /* don't touch the HW before waiting 100ms */ > + msleep(100); This is obviously broken. I should have checked the capability on the root port. I was trying to get it out before Monday. However, I still want to hear about the preference of this methodology. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.