Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Harshal Dev <harshal.dev@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	cros-qcom-dts-watchers@chromium.org,
	Eric Biggers <ebiggers@google.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Tengfei Fan <tengfei.fan@oss.qualcomm.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	David Wronek <davidwronek@gmail.com>,
	Luca Weiss <luca.weiss@fairphone.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Melody Olvera <quic_molvera@quicinc.com>,
	Alexander Koskovich <akoskovich@pm.me>,
	Abel Vesa <abelvesa@kernel.org>,
	Brian Masney <bmasney@redhat.com>,
	Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
	Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v5 01/13] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk
Date: Thu, 7 May 2026 15:50:21 +0530	[thread overview]
Message-ID: <b8805117-d54f-4e42-a7d4-6fa18af63e69@oss.qualcomm.com> (raw)
In-Reply-To: <afmuncmBrrvddHTU@gondor.apana.org.au>

Hi Bjorn,

On 5/5/2026 2:17 PM, Herbert Xu wrote:
> On Thu, Apr 16, 2026 at 05:29:18PM +0530, Harshal Dev wrote:
>> The DT bindings for inline-crypto engine do not specify the UFS_PHY_GDSC
>> power-domain and iface clock. Without enabling the iface clock and the
>> associated power-domain the ICE hardware cannot function correctly and
>> leads to unclocked hardware accesses being observed during probe.
>>
>> Fix the DT bindings for inline-crypto engine to require the UFS_PHY_GDSC
>> power-domain and iface clock for new devices (Eliza and Milos) introduced
>> in the current release (7.1) with yet-to-stabilize ABI, while preserving
>> backward compatibility for older devices.
>>
>> Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Document the Eliza ICE")
>> Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: document the Milos ICE")
>> Reviewed-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
>> ---
>>  .../bindings/crypto/qcom,inline-crypto-engine.yaml | 35 +++++++++++++++++++++-
>>  1 file changed, 34 insertions(+), 1 deletion(-)
> 
> Patch applied.  Thanks.

Herbert has pulled out of picking this patch from his tree.
As discussed, since this DT binding update relies on DTS changes in commits 12 and 13
of these series, they should all go through the same tree.

Can we aim to pick this series via the qcom-soc tree to ensure the binding and DTS changes
are applied together? Since the 7.1 fixes window is open, I am hoping for this to be
picked up this week or the next.

Regards,
Harshal


  reply	other threads:[~2026-05-07 10:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 11:59 [PATCH v5 00/13] Add explicit clock vote and enable power-domain for QCOM-ICE Harshal Dev
2026-04-16 11:59 ` [PATCH v5 01/13] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk Harshal Dev
2026-05-05  8:47   ` Herbert Xu
2026-05-07 10:20     ` Harshal Dev [this message]
2026-05-08 14:41       ` Harshal Dev
2026-05-09  1:24         ` Herbert Xu
2026-04-16 11:59 ` [PATCH v5 02/13] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE Harshal Dev
2026-04-16 11:59 ` [PATCH v5 03/13] arm64: dts: qcom: kaanapali: Add power-domain and iface clk for ice node Harshal Dev
2026-04-16 11:59 ` [PATCH v5 04/13] arm64: dts: qcom: lemans: " Harshal Dev
2026-04-20  8:53   ` Bartosz Golaszewski
2026-04-16 11:59 ` [PATCH v5 05/13] arm64: dts: qcom: monaco: " Harshal Dev
2026-04-16 11:59 ` [PATCH v5 06/13] arm64: dts: qcom: sc7180: " Harshal Dev
2026-04-16 11:59 ` [PATCH v5 07/13] arm64: dts: qcom: kodiak: " Harshal Dev
2026-04-16 11:59 ` [PATCH v5 08/13] arm64: dts: qcom: sm8450: " Harshal Dev
2026-04-16 11:59 ` [PATCH v5 09/13] arm64: dts: qcom: sm8550: " Harshal Dev
2026-04-16 11:59 ` [PATCH v5 10/13] arm64: dts: qcom: sm8650: " Harshal Dev
2026-04-16 11:59 ` [PATCH v5 11/13] arm64: dts: qcom: sm8750: " Harshal Dev
2026-04-16 11:59 ` [PATCH v5 12/13] arm64: dts: qcom: milos: " Harshal Dev
2026-04-21  9:27   ` Kuldeep Singh
2026-05-04 13:00   ` Konrad Dybcio
2026-04-16 11:59 ` [PATCH v5 13/13] arm64: dts: qcom: eliza: " Harshal Dev
2026-04-21  9:38   ` Kuldeep Singh
2026-05-04 13:03     ` Konrad Dybcio
2026-05-04 13:00   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8805117-d54f-4e42-a7d4-6fa18af63e69@oss.qualcomm.com \
    --to=harshal.dev@oss.qualcomm.com \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=davem@davemloft.net \
    --cc=davidwronek@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=ebiggers@google.com \
    --cc=gaurav.kashyap@oss.qualcomm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=neeraj.soni@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_molvera@quicinc.com \
    --cc=robh@kernel.org \
    --cc=tengfei.fan@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox